x11/freerdp: update to 2.0.0-rc4

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

x11/freerdp: update to 2.0.0-rc4

Denis Fondras
Can anyone give it a try ? The patch to overcome timerfd_create() is a bit
naive.

My usage (connecting to Windows 10, Windows 2012 & Windows 2016 with
drive redirection) did not show any problem.
xfreerdp /v:windowscomputer /u:denis /clipboard /drive:openbsd,/home/denis/documents

Denis

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/freerdp/Makefile,v
retrieving revision 1.35
diff -u -p -r1.35 Makefile
--- Makefile 11 Dec 2018 11:12:22 -0000 1.35
+++ Makefile 9 Feb 2019 14:58:50 -0000
@@ -3,10 +3,9 @@
 # Also:  __sync_fetch_and_add_4 __sync_add_and_fetch_4 __sync_sub_and_fetch_4
 BROKEN-hppa = undefined reference to __sync_val_compare_and_swap_4
 
-COMMENT = open source client for Windows Terminal Server
-DISTNAME = freerdp-2.0.0-rc1
-PKGNAME = freerdp-2.0.0rc1
-REVISION = 2
+COMMENT = open source client for the Remote Desktop Protocol
+DISTNAME = freerdp-2.0.0-rc4
+PKGNAME = freerdp-2.0.0rc4
 CATEGORIES = x11 net
 
 SHARED_LIBS +=  freerdp-client2           0.0 # 2.0
Index: distinfo
===================================================================
RCS file: /cvs/ports/x11/freerdp/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo 28 Apr 2018 19:20:17 -0000 1.8
+++ distinfo 9 Feb 2019 14:58:50 -0000
@@ -1,2 +1,2 @@
-SHA256 (freerdp-2.0.0-rc1.tar.gz) = 8JogqXEWPCeD77egtIyGBuIPl7RB9xjyUoNDgnex+Hs=
-SIZE (freerdp-2.0.0-rc1.tar.gz) = 6575999
+SHA256 (freerdp-2.0.0-rc4.tar.gz) = vRzVV5dlsta0RFCMr8ezZpxo/yJGlBoIHncfdEsVD2o=
+SIZE (freerdp-2.0.0-rc4.tar.gz) = 6662044
Index: patches/patch-CMakeLists_txt
===================================================================
RCS file: /cvs/ports/x11/freerdp/patches/patch-CMakeLists_txt,v
retrieving revision 1.6
diff -u -p -r1.6 patch-CMakeLists_txt
--- patches/patch-CMakeLists_txt 28 Apr 2018 19:20:17 -0000 1.6
+++ patches/patch-CMakeLists_txt 9 Feb 2019 14:58:50 -0000
@@ -3,7 +3,7 @@ $OpenBSD: patch-CMakeLists_txt,v 1.6 201
 Index: CMakeLists.txt
 --- CMakeLists.txt.orig
 +++ CMakeLists.txt
-@@ -953,9 +953,9 @@ if(WAYLAND_FOUND)
+@@ -1081,9 +1081,9 @@ if(WAYLAND_FOUND)
  endif()
 
  if(BSD)
Index: patches/patch-client_X11_CMakeLists_txt
===================================================================
RCS file: /cvs/ports/x11/freerdp/patches/patch-client_X11_CMakeLists_txt,v
retrieving revision 1.3
diff -u -p -r1.3 patch-client_X11_CMakeLists_txt
--- patches/patch-client_X11_CMakeLists_txt 28 Apr 2018 19:20:17 -0000 1.3
+++ patches/patch-client_X11_CMakeLists_txt 9 Feb 2019 14:58:50 -0000
@@ -3,7 +3,7 @@ $OpenBSD: patch-client_X11_CMakeLists_tx
 Index: client/X11/CMakeLists.txt
 --- client/X11/CMakeLists.txt.orig
 +++ client/X11/CMakeLists.txt
-@@ -203,7 +203,7 @@ endif()
+@@ -225,7 +225,7 @@ endif()
  include_directories(${CMAKE_SOURCE_DIR}/resources)
 
  set(${MODULE_PREFIX}_LIBS ${${MODULE_PREFIX}_LIBS} freerdp-client freerdp m)
Index: patches/patch-libfreerdp_core_nla_c
===================================================================
RCS file: patches/patch-libfreerdp_core_nla_c
diff -N patches/patch-libfreerdp_core_nla_c
--- patches/patch-libfreerdp_core_nla_c 8 Jun 2018 20:32:16 -0000 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,29 +0,0 @@
-$OpenBSD: patch-libfreerdp_core_nla_c,v 1.1 2018/06/08 20:32:16 denis Exp $
-
-Fix nla: don't use server version
-
-  https://github.com/FreeRDP/FreeRDP/commit/e7ae3f6babc881d893411a5ada9156abe8525b2f
-
-Index: libfreerdp/core/nla.c
---- libfreerdp/core/nla.c.orig
-+++ libfreerdp/core/nla.c
-@@ -1663,14 +1663,18 @@ BOOL nla_send(rdpNla* nla)
- static int nla_decode_ts_request(rdpNla* nla, wStream* s)
- {
- int length;
-+ UINT32 version = 0;
-
- /* TSRequest */
- if (!ber_read_sequence_tag(s, &length) ||
-    !ber_read_contextual_tag(s, 0, &length, TRUE) ||
--    !ber_read_integer(s, &nla->version))
-+    !ber_read_integer(s, &version))
- {
- return -1;
- }
-+
-+ if (version < nla->version)
-+ nla->version = version;
-
- /* [1] negoTokens (NegoData) */
- if (ber_read_contextual_tag(s, 1, &length, TRUE) != FALSE)
Index: patches/patch-libfreerdp_crypto_tls_c
===================================================================
RCS file: /cvs/ports/x11/freerdp/patches/patch-libfreerdp_crypto_tls_c,v
retrieving revision 1.3
diff -u -p -r1.3 patch-libfreerdp_crypto_tls_c
--- patches/patch-libfreerdp_crypto_tls_c 24 Oct 2018 17:10:22 -0000 1.3
+++ patches/patch-libfreerdp_crypto_tls_c 9 Feb 2019 14:58:50 -0000
@@ -2,10 +2,22 @@ $OpenBSD: patch-libfreerdp_crypto_tls_c,
 
 Stop reaching into libssl internals to send TLS alerts.
 
+Also, 2.0.0-rc4 do not build with LibreSSL :
+https://github.com/FreeRDP/FreeRDP/issues/5049#issuecomment-441084530
+
 Index: libfreerdp/crypto/tls.c
 --- libfreerdp/crypto/tls.c.orig
 +++ libfreerdp/crypto/tls.c
-@@ -1020,7 +1020,8 @@ BOOL tls_send_alert(rdpTls* tls)
+@@ -656,7 +656,7 @@ static BOOL tls_prepare(rdpTls* tls, BIO* underlying,
+ #endif
+
+
+-#if OPENSSL_VERSION_NUMBER >= 0x10100000L || defined(LIBRESSL_VERSION_NUMBER)
++#if OPENSSL_VERSION_NUMBER >= 0x10100000L && !defined(LIBRESSL_VERSION_NUMBER)
+ SSL_CTX_set_security_level(tls->ctx, settings->TlsSecLevel);
+ #endif
+
+@@ -1026,7 +1026,8 @@ BOOL tls_send_alert(rdpTls* tls)
  * FIXME: The following code does not work on OpenSSL > 1.1.0 because the
  *        SSL struct is opaqe now
  */
Index: patches/patch-winpr_include_winpr_crt_h
===================================================================
RCS file: patches/patch-winpr_include_winpr_crt_h
diff -N patches/patch-winpr_include_winpr_crt_h
--- patches/patch-winpr_include_winpr_crt_h 28 Apr 2018 19:20:17 -0000 1.2
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,16 +0,0 @@
-$OpenBSD: patch-winpr_include_winpr_crt_h,v 1.2 2018/04/28 19:20:17 landry Exp $
-
-__builtin_bswap32
-
-Index: winpr/include/winpr/crt.h
---- winpr/include/winpr/crt.h.orig
-+++ winpr/include/winpr/crt.h
-@@ -68,7 +68,7 @@ static INLINE UINT64 _rotr64(UINT64 value, int shift)
- }
- #endif
-
--#if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 2))
-+#if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 3))
-
- #define _byteswap_ulong(_val) __builtin_bswap32(_val)
- #define _byteswap_uint64(_val) __builtin_bswap64(_val)
Index: patches/patch-winpr_libwinpr_CMakeLists_txt
===================================================================
RCS file: /cvs/ports/x11/freerdp/patches/patch-winpr_libwinpr_CMakeLists_txt,v
retrieving revision 1.1
diff -u -p -r1.1 patch-winpr_libwinpr_CMakeLists_txt
--- patches/patch-winpr_libwinpr_CMakeLists_txt 28 Apr 2018 19:20:17 -0000 1.1
+++ patches/patch-winpr_libwinpr_CMakeLists_txt 9 Feb 2019 14:58:50 -0000
@@ -3,9 +3,9 @@ $OpenBSD: patch-winpr_libwinpr_CMakeList
 Index: winpr/libwinpr/CMakeLists.txt
 --- winpr/libwinpr/CMakeLists.txt.orig
 +++ winpr/libwinpr/CMakeLists.txt
-@@ -21,6 +21,10 @@ if (APPLE)
- set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -Wl,-flat_namespace,-undefined,warning")
- endif()
+@@ -17,6 +17,10 @@
+
+ include(CheckFunctionExists)
 
 +if (OPENBSD)
 + set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -L${LOCALBASE}/lib")
Index: patches/patch-winpr_libwinpr_synch_timer_c
===================================================================
RCS file: patches/patch-winpr_libwinpr_synch_timer_c
diff -N patches/patch-winpr_libwinpr_synch_timer_c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-winpr_libwinpr_synch_timer_c 9 Feb 2019 14:58:50 -0000
@@ -0,0 +1,20 @@
+$OpenBSD$
+
+Index: winpr/libwinpr/synch/timer.c
+--- winpr/libwinpr/synch/timer.c.orig
++++ winpr/libwinpr/synch/timer.c
+@@ -242,7 +242,14 @@ static int InitializeWaitableTimer(WINPR_TIMER* timer)
+ free(timer);
+ return -1;
+ }
++#elif defined(__OpenBSD__)
++ timer->fd = kqueue();
+
++ if (timer->fd <= 0)
++ {
++ free(timer);
++ return -1;
++ }
+ #elif defined(__APPLE__)
+ #else
+ WLog_ERR(TAG, "%s: os specific implementation is missing", __FUNCTION__);
Index: patches/patch-winpr_libwinpr_utils_CMakeLists_txt
===================================================================
RCS file: /cvs/ports/x11/freerdp/patches/patch-winpr_libwinpr_utils_CMakeLists_txt,v
retrieving revision 1.2
diff -u -p -r1.2 patch-winpr_libwinpr_utils_CMakeLists_txt
--- patches/patch-winpr_libwinpr_utils_CMakeLists_txt 28 Apr 2018 19:20:17 -0000 1.2
+++ patches/patch-winpr_libwinpr_utils_CMakeLists_txt 9 Feb 2019 14:58:50 -0000
@@ -2,7 +2,7 @@ $OpenBSD: patch-winpr_libwinpr_utils_CMa
 Index: winpr/libwinpr/utils/CMakeLists.txt
 --- winpr/libwinpr/utils/CMakeLists.txt.orig
 +++ winpr/libwinpr/utils/CMakeLists.txt
-@@ -149,6 +149,10 @@ if(WIN32)
+@@ -150,6 +150,10 @@ if(WIN32)
  winpr_library_add(Dbghelp)
  endif()
 
Index: patches/patch-winpr_libwinpr_utils_ssl_c
===================================================================
RCS file: patches/patch-winpr_libwinpr_utils_ssl_c
diff -N patches/patch-winpr_libwinpr_utils_ssl_c
--- patches/patch-winpr_libwinpr_utils_ssl_c 28 Apr 2018 19:20:17 -0000 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,25 +0,0 @@
-$OpenBSD: patch-winpr_libwinpr_utils_ssl_c,v 1.1 2018/04/28 19:20:17 landry Exp $
-
-https://github.com/FreeRDP/FreeRDP/commit/bfe3af4c72b45e33321962644d864843e1c9ce3d
-
-Index: winpr/libwinpr/utils/ssl.c
---- winpr/libwinpr/utils/ssl.c.orig
-+++ winpr/libwinpr/utils/ssl.c
-@@ -279,7 +279,7 @@ static BOOL CALLBACK _winpr_openssl_initialize(PINIT_O
-
- if (flags & WINPR_SSL_INIT_ENABLE_FIPS)
- {
--#if (OPENSSL_VERSION_NUMBER < 0x10001000L)
-+#if (OPENSSL_VERSION_NUMBER < 0x10001000L) || defined(LIBRESSL_VERSION_NUMBER)
- WLog_ERR(TAG, "Openssl fips mode ENable not available on openssl versions less than 1.0.1!");
- #else
- WLog_DBG(TAG, "Ensuring openssl fips mode is ENabled");
-@@ -348,7 +348,7 @@ BOOL winpr_CleanupSSL(DWORD flags)
-
- BOOL winpr_FIPSMode(void)
- {
--#if (OPENSSL_VERSION_NUMBER < 0x10001000L)
-+#if (OPENSSL_VERSION_NUMBER < 0x10001000L) || defined(LIBRESSL_VERSION_NUMBER)
- return FALSE;
- #else
- return (FIPS_mode() == 1);
Index: patches/patch-winpr_libwinpr_utils_trio_triodef_h
===================================================================
RCS file: patches/patch-winpr_libwinpr_utils_trio_triodef_h
diff -N patches/patch-winpr_libwinpr_utils_trio_triodef_h
--- patches/patch-winpr_libwinpr_utils_trio_triodef_h 7 Nov 2015 05:55:08 -0000 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,12 +0,0 @@
-$OpenBSD: patch-winpr_libwinpr_utils_trio_triodef_h,v 1.1 2015/11/07 05:55:08 ajacoutot Exp $
---- winpr/libwinpr/utils/trio/triodef.h.orig Thu Oct 29 07:05:37 2015
-+++ winpr/libwinpr/utils/trio/triodef.h Thu Oct 29 07:05:59 2015
-@@ -88,7 +88,7 @@
- # endif
- #endif
-
--#if defined(__NetBSD__)
-+#if defined(__NetBSD__) || defined(__OpenBSD__)
- # define TRIO_PLATFORM_UNIX
- #endif
-
Index: patches/patch-winpr_winpr_pc_in
===================================================================
RCS file: patches/patch-winpr_winpr_pc_in
diff -N patches/patch-winpr_winpr_pc_in
--- patches/patch-winpr_winpr_pc_in 28 Apr 2018 19:20:17 -0000 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -0000
@@ -1,12 +0,0 @@
-$OpenBSD: patch-winpr_winpr_pc_in,v 1.1 2018/04/28 19:20:17 landry Exp $
-
-Index: winpr/winpr.pc.in
---- winpr/winpr.pc.in.orig
-+++ winpr/winpr.pc.in
-@@ -11,5 +11,5 @@ Version: @WINPR_VERSION@
- Requires:
- Requires.private: libssl
- Libs: -L${libdir} ${libs}
--Libs.private: -ldl -lrt -lm -lpthread
-+Libs.private: -lm -lpthread
- Cflags: -I${includedir}
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/x11/freerdp/pkg/DESCR,v
retrieving revision 1.3
diff -u -p -r1.3 DESCR
--- pkg/DESCR 4 Aug 2012 14:47:00 -0000 1.3
+++ pkg/DESCR 9 Feb 2019 14:58:50 -0000
@@ -1,4 +1,3 @@
-freerdp is a fork of the rdesktop project and is an open source client
-for Windows NT and 2000 Terminal Server, capable of natively speaking
-the Remote Desktop Protocol (RDP) in order to present the user's Windows
-desktop.
+FreeRDP is a free library and clients of the Remote Desktop Protocol (RDP), a
+proprietary protocol developed by Microsoft, which provides a user with a
+graphical interface to connect to another computer over a network connection.

Reply | Threaded
Open this post in threaded view
|

Re: x11/freerdp: update to 2.0.0-rc4

Landry Breuil-5
On Sat, Feb 09, 2019 at 04:48:07PM +0100, Denis Fondras wrote:
> Can anyone give it a try ? The patch to overcome timerfd_create() is a bit
> naive.
>
> My usage (connecting to Windows 10, Windows 2012 & Windows 2016 with
> drive redirection) did not show any problem.
> xfreerdp /v:windowscomputer /u:denis /clipboard /drive:openbsd,/home/denis/documents

Well if it works that's good, but yeah i doubt replacing
timerfd_create() by kqueue() will work when those codepaths are
reached... have you checked that was the case ? If so that's great.

Reply | Threaded
Open this post in threaded view
|

Re: x11/freerdp: update to 2.0.0-rc4

Denis Fondras
On Sun, Feb 10, 2019 at 09:59:19AM +0100, Landry Breuil wrote:
> Well if it works that's good, but yeah i doubt replacing
> timerfd_create() by kqueue() will work when those codepaths are
> reached... have you checked that was the case ? If so that's great.
>

The specific timerfd_* are #ifdef'd and never reached.
timer->fd is then used by poll() so a dummy valid fd is "safe".

But I'd like another eye on it as it looks like all callbacks are NULL so I
don't understand what this timer is used for.

Reply | Threaded
Open this post in threaded view
|

Re: x11/freerdp: update to 2.0.0-rc4

Stuart Henderson
In reply to this post by Denis Fondras
On 2019/02/09 16:48, Denis Fondras wrote:
> Can anyone give it a try ? The patch to overcome timerfd_create() is a bit
> naive.

Looking again I see it doesn't actually need the linux-specific timerfd_*
functions but it *does* need the posix timer functions that are normally
in librt (timer_create, timer_delete, timer_settime, timer_gettime) or
a whole alternative implementation (as freerdp has for OSX).

Basic runtime works for me with your diff but I don't see how it can be
a correct fix so I wouldn't be too happy about committing it.. And freerdp's
test suite fails.

> ---- winpr/libwinpr/utils/trio/triodef.h.orig Thu Oct 29 07:05:37 2015
> -+++ winpr/libwinpr/utils/trio/triodef.h Thu Oct 29 07:05:59 2015
> -@@ -88,7 +88,7 @@
> - # endif
> - #endif
> -
> --#if defined(__NetBSD__)
> -+#if defined(__NetBSD__) || defined(__OpenBSD__)
> - # define TRIO_PLATFORM_UNIX
> - #endif
> -

that should be

+-#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__)
++#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__) || defined(__OpenBSD__)

> retrieving revision 1.3
> diff -u -p -r1.3 DESCR
> --- pkg/DESCR 4 Aug 2012 14:47:00 -0000 1.3
> +++ pkg/DESCR 9 Feb 2019 14:58:50 -0000
> @@ -1,4 +1,3 @@
> -freerdp is a fork of the rdesktop project and is an open source client
> -for Windows NT and 2000 Terminal Server, capable of natively speaking
> -the Remote Desktop Protocol (RDP) in order to present the user's Windows
> -desktop.
> +FreeRDP is a free library and clients of the Remote Desktop Protocol (RDP), a
> +proprietary protocol developed by Microsoft, which provides a user with a
> +graphical interface to connect to another computer over a network connection.
>

the old one was outdated but this doesn't flow so nicely .. how about
the diff below to enable tests and tweak DESCR?


Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/freerdp/Makefile,v
retrieving revision 1.35
diff -u -p -r1.35 Makefile
--- Makefile 11 Dec 2018 11:12:22 -0000 1.35
+++ Makefile 10 Feb 2019 14:36:02 -0000
@@ -6,7 +6,7 @@ BROKEN-hppa = undefined reference to __
 COMMENT = open source client for Windows Terminal Server
 DISTNAME = freerdp-2.0.0-rc1
 PKGNAME = freerdp-2.0.0rc1
-REVISION = 2
+REVISION = 3
 CATEGORIES = x11 net
 
 SHARED_LIBS +=  freerdp-client2           0.0 # 2.0
@@ -37,7 +37,8 @@ LIB_DEPENDS = devel/libexecinfo \
  print/cups,-libs \
  graphics/ffmpeg
 
-CONFIGURE_ARGS += -DWITH_CUPS=ON \
+CONFIGURE_ARGS += -DBUILD_TESTING=ON \
+ -DWITH_CUPS=ON \
  -DWITH_DIRECTFB=OFF \
  -DWITH_GSTREAMER_0_10=OFF \
  -DWITH_GSTREAMER_1_0=OFF \
@@ -45,8 +46,6 @@ CONFIGURE_ARGS += -DWITH_CUPS=ON \
  -DWITH_PCSC=ON \
  -DWITH_LIBSYSTEMD=OFF \
  -DWITH_OSS=OFF
-
-NO_TEST = Yes
 
 pre-configure:
  ${SUBST_CMD} ${WRKSRC}/winpr/libwinpr/CMakeLists.txt
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/x11/freerdp/pkg/DESCR,v
retrieving revision 1.3
diff -u -p -r1.3 DESCR
--- pkg/DESCR 4 Aug 2012 14:47:00 -0000 1.3
+++ pkg/DESCR 10 Feb 2019 14:36:02 -0000
@@ -1,4 +1,5 @@
-freerdp is a fork of the rdesktop project and is an open source client
-for Windows NT and 2000 Terminal Server, capable of natively speaking
-the Remote Desktop Protocol (RDP) in order to present the user's Windows
-desktop.
+FreeRDP is a free implementation of RDP, Microsoft's Remote Desktop Protocol.
+It provides a library and client software to provide a user with a graphical
+interface to connect to another computer over a network connection.
+
+It includes features like clipboard sharing, device and folder redirection.

Reply | Threaded
Open this post in threaded view
|

Re: x11/freerdp: update to 2.0.0-rc4

Denis Fondras-3
On Sun, Feb 10, 2019 at 02:43:37PM +0000, Stuart Henderson wrote:
> that should be
>
> +-#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__)
> ++#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__) || defined(__OpenBSD__)
>

Yes, I will send a PR upstream.

> the old one was outdated but this doesn't flow so nicely .. how about
> the diff below to enable tests and tweak DESCR?
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/freerdp/Makefile,v
> retrieving revision 1.35
> diff -u -p -r1.35 Makefile
> --- Makefile 11 Dec 2018 11:12:22 -0000 1.35
> +++ Makefile 10 Feb 2019 14:36:02 -0000
> @@ -6,7 +6,7 @@ BROKEN-hppa = undefined reference to __
>  COMMENT = open source client for Windows Terminal Server

I would replace TSE with RDP here :)

>  DISTNAME = freerdp-2.0.0-rc1
>  PKGNAME = freerdp-2.0.0rc1
> -REVISION = 2
> +REVISION = 3
>  CATEGORIES = x11 net
>  
>  SHARED_LIBS +=  freerdp-client2           0.0 # 2.0
> @@ -37,7 +37,8 @@ LIB_DEPENDS = devel/libexecinfo \
>   print/cups,-libs \
>   graphics/ffmpeg
>  
> -CONFIGURE_ARGS += -DWITH_CUPS=ON \
> +CONFIGURE_ARGS += -DBUILD_TESTING=ON \
> + -DWITH_CUPS=ON \
>   -DWITH_DIRECTFB=OFF \
>   -DWITH_GSTREAMER_0_10=OFF \
>   -DWITH_GSTREAMER_1_0=OFF \
> @@ -45,8 +46,6 @@ CONFIGURE_ARGS += -DWITH_CUPS=ON \
>   -DWITH_PCSC=ON \
>   -DWITH_LIBSYSTEMD=OFF \
>   -DWITH_OSS=OFF
> -
> -NO_TEST = Yes
>  
>  pre-configure:
>   ${SUBST_CMD} ${WRKSRC}/winpr/libwinpr/CMakeLists.txt
> Index: pkg/DESCR
> ===================================================================
> RCS file: /cvs/ports/x11/freerdp/pkg/DESCR,v
> retrieving revision 1.3
> diff -u -p -r1.3 DESCR
> --- pkg/DESCR 4 Aug 2012 14:47:00 -0000 1.3
> +++ pkg/DESCR 10 Feb 2019 14:36:02 -0000
> @@ -1,4 +1,5 @@
> -freerdp is a fork of the rdesktop project and is an open source client
> -for Windows NT and 2000 Terminal Server, capable of natively speaking
> -the Remote Desktop Protocol (RDP) in order to present the user's Windows
> -desktop.
> +FreeRDP is a free implementation of RDP, Microsoft's Remote Desktop Protocol.
> +It provides a library and client software to provide a user with a graphical
> +interface to connect to another computer over a network connection.
> +
> +It includes features like clipboard sharing, device and folder redirection.
>

OK denis@

Reply | Threaded
Open this post in threaded view
|

Re: x11/freerdp: update to 2.0.0-rc4

Stuart Henderson
On 2019/02/10 16:21, Denis Fondras wrote:
> On Sun, Feb 10, 2019 at 02:43:37PM +0000, Stuart Henderson wrote:
> > that should be
> >
> > +-#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__)
> > ++#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__) || defined(__OpenBSD__)
> >
>
> Yes, I will send a PR upstream.

hmm, that might give them the false impression that the timers thing is
no longer a problem ;)

> I would replace TSE with RDP here :)

done.


Reply | Threaded
Open this post in threaded view
|

Re: x11/freerdp: update to 2.0.0-rc4

Landry Breuil-5
On Sun, Feb 10, 2019 at 08:58:34PM +0000, Stuart Henderson wrote:

> On 2019/02/10 16:21, Denis Fondras wrote:
> > On Sun, Feb 10, 2019 at 02:43:37PM +0000, Stuart Henderson wrote:
> > > that should be
> > >
> > > +-#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__)
> > > ++#if defined(__NetBSD__) || defined(__FreeBSD__) || defined(__DragonFly__) || defined(__OpenBSD__)
> > >
> >
> > Yes, I will send a PR upstream.
>
> hmm, that might give them the false impression that the timers thing is
> no longer a problem ;)

https://github.com/FreeRDP/FreeRDP/issues/4592 fwiw