www/fcgi - patch to build perl module

[Adam Montague]

This creates a new subpackage for the perl fastcgi module.  Should I have
a no_perl pseudo flavour, or is it ok to always build the perl module?

Adam

[Okan Demirmen]

On Sat 2006.10.21 at 16:15 -0400, Adam Montague wrote:
> This creates a new subpackage for the perl fastcgi module.  Should I have
> a no_perl pseudo flavour, or is it ok to always build the perl module?

who am i, but i feel it wouldn't cost much to always have the perl
module built/included (especially since it is arch dependent). C, C++
and Perl by default ;)

> Adam
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/www/fcgi/Makefile,v
> retrieving revision 1.7
> diff -u -r1.7 Makefile
> --- Makefile 14 Jan 2006 11:46:15 -0000 1.7
> +++ Makefile 21 Oct 2006 20:10:02 -0000
> @@ -1,9 +1,11 @@
>  # $OpenBSD: Makefile,v 1.7 2006/01/14 11:46:15 espie Exp $
>  
>  COMMENT= "FastCGI Development Kit"
> -
> -DISTNAME= fcgi-2.4.0
> +COMMENT-perl= "Perl FastCGI module"
> +V= 2.4.0
> +DISTNAME= fcgi-$V
>  PKGNAME= ${DISTNAME}p1
> +PKGNAME-perl= p5-FCGI-$V
>  CATEGORIES= www
>  SHARED_LIBS= fcgi++ 1.0 \
>   fcgi 0.0
> @@ -17,7 +19,7 @@
>  PERMIT_PACKAGE_FTP=     Yes
>  PERMIT_DISTFILES_CDROM= Yes
>  PERMIT_DISTFILES_FTP=   Yes
> -WANTLIB= c
> +WANTLIB= c
>  
>  MASTER_SITES= ${HOMEPAGE}/dist/
>  
> @@ -28,6 +30,15 @@
>  CAT3_FILES= FCGI_Accept FCGI_Finish FCGI_SetExitStatus \
>   FCGI_StartFilterData
>  
> +MULTI_PACKAGES= -perl
> +SUBPACKAGE?=
> +
> +post-configure:
> + @cd ${WRKSRC}/perl && perl Makefile.PL
> +
> +post-build:
> + @cd ${WRKSRC}/perl && make
> +
>  post-install:
>   ${INSTALL_MAN} ${WRKSRC}/doc/cgi-fcgi.1 ${PREFIX}/man/cat1/cgi-fcgi.0
>  .for file in ${CAT3_FILES}
> @@ -36,5 +47,6 @@
>   ${INSTALL_DATA_DIR} ${PREFIX}/share/doc/fcgi
>   ${INSTALL_DATA} ${WRKSRC}/doc/*.htm* ${WRKSRC}/doc/*.gif \
>   ${PREFIX}/share/doc/fcgi
> + @cd ${WRKSRC}/perl && make install
>  
>  .include <bsd.port.mk>
> Index: pkg/DESCR-perl
> ===================================================================
> RCS file: pkg/DESCR-perl
> diff -N pkg/DESCR-perl
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ pkg/DESCR-perl 21 Oct 2006 20:10:02 -0000
> @@ -0,0 +1 @@
> +Perl FastCGI module
> Index: pkg/PFRAG.shared-perl
> ===================================================================
> RCS file: pkg/PFRAG.shared-perl
> diff -N pkg/PFRAG.shared-perl
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ pkg/PFRAG.shared-perl 21 Oct 2006 20:10:02 -0000
> @@ -0,0 +1,2 @@
> +@comment $OpenBSD$
> +libdata/perl5/site_perl/${MACHINE_ARCH}-openbsd/auto/FCGI/FCGI.so
> Index: pkg/PLIST-perl
> ===================================================================
> RCS file: pkg/PLIST-perl
> diff -N pkg/PLIST-perl
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ pkg/PLIST-perl 21 Oct 2006 20:10:02 -0000
> @@ -0,0 +1,8 @@
> +@comment $OpenBSD$
> +libdata/perl5/site_perl/${MACHINE_ARCH}-openbsd/
> +libdata/perl5/site_perl/${MACHINE_ARCH}-openbsd/FCGI.pm
> +libdata/perl5/site_perl/${MACHINE_ARCH}-openbsd/auto/
> +libdata/perl5/site_perl/${MACHINE_ARCH}-openbsd/auto/FCGI/
> +libdata/perl5/site_perl/${MACHINE_ARCH}-openbsd/auto/FCGI/FCGI.bs
> +@man man/man3p/FCGI.3p
> +%%SHARED%%

[Adam Montague]

Given the recent catalyst work, it would be nice to have perl fastcgi
support available.  Any comments about this?  Patch is attached again.

Adam Montague <[hidden email]> wrote:

> This creates a new subpackage for the perl fastcgi module.  Should I have
> a no_perl pseudo flavour, or is it ok to always build the perl module?
>
> Adam

[Simon Bertrang]

On Sun, Nov 05, 2006 at 02:18:58PM -0500, Adam Montague wrote:
> Given the recent catalyst work, it would be nice to have perl fastcgi
> support available.  Any comments about this?  Patch is attached again.
>
> Adam Montague <[hidden email]> wrote:
>
> > This creates a new subpackage for the perl fastcgi module.  Should I have
> > a no_perl pseudo flavour, or is it ok to always build the perl module?
> >
[snip]

Works, tested on amd64 and i386.

Thanks and regards,
Simon

[Marc Balmer-2]

* Adam Montague wrote:

> Given the recent catalyst work, it would be nice to have perl fastcgi
> support available.  Any comments about this?  Patch is attached again.

> -
> -DISTNAME= fcgi-2.4.0
> +COMMENT-perl= "Perl FastCGI module"
> +V= 2.4.0
> +DISTNAME= fcgi-$V
>  PKGNAME= ${DISTNAME}p1
> +PKGNAME-perl= p5-FCGI-$V

The creation of the ${V} variable is unnecessary.  Please try to change that.
e.g. PKGNAME-perl=p5-${DISTNAME}.

Otherwise, "why not" ;) (I don't use perl, but I use FastCGI a lot).