usbd_fill_deviceinfo page fault trap

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

usbd_fill_deviceinfo page fault trap

Florian Obser-2
on resume I was greeted by:
[typed from a photo (http://sha256.net/dump/usbd_fill_deviceinfo.jpg)]
kernel: page fault trap, code =0
Stopped at strlcpy+0x35: movzbl 0(%rsi, %rax,1), %ecx
strlcpy(ffff800001459c81,0,7f) at strlcpy+0x35
usbd_fill_deviceinfo at usbd_fill_deviceinfo+0x4f
usbioctl at usbioctl+0x409
VOP_IOCTL at VOP_IOCTL+0x61
vn_ioctl at vn_ioctl+0x6e
sys_ioctl at sys_ioctl+0x3d5
syscall at syscall+0x338
Xsyscall(6,36,4,36,3,0) at Xsyscall+0x128

I have a suspicion that this is related to my external monitor that
acts as a usb hub. Upon wake up I also turn on the monitor and then
random usb devices show up.

I also had 2 suspend failures in the last 2 weeks or so that I
couldn't track down yet. (The led keeps blinking). I usually close the
lid on the laptop and while it's suspending I hit the power button on
the monitor, so random USB devices disapear while the laptop is
suspending.

This might be a red herring though. However, suspend / resume has been
rock solid on this X1 I don't recall having an issue with that ever in
3 years or so.

OpenBSD 6.4-current (GENERIC.MP) #693: Fri Feb  8 23:49:44 MST 2019
    [hidden email]:/usr/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 8233394176 (7851MB)
avail mem = 7974166528 (7604MB)
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.7 @ 0xdcd3d000 (61 entries)
bios0: vendor LENOVO version "GRET40WW (1.17 )" date 09/02/2014
bios0: LENOVO 20A7006VUS
acpi0 at bios0: rev 2
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP SLIC DBGP ECDT HPET APIC MCFG SSDT SSDT SSDT SSDT SSDT SSDT SSDT PCCT SSDT UEFI MSDM ASF! BATB FPDT UEFI DMAR
acpi0: wakeup devices LID_(S4) SLPB(S3) IGBE(S4) EXP2(S4) XHCI(S3) EHC1(S3)
acpitimer0 at acpi0: 3579545 Hz, 24 bits
acpiec0 at acpi0
acpihpet0 at acpi0: 14318179 Hz
acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.72 MHz, 06-45-01
cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu0: 256KB 64b/line 8-way L2 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 10 var ranges, 88 fixed ranges
cpu0: apic clock running at 99MHz
cpu0: mwait min=64, max=64, C-substates=0.2.1.2.4.1.1.1, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.39 MHz, 06-45-01
cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu1: 256KB 64b/line 8-way L2 cache
cpu1: smt 1, core 0, package 0
cpu2 at mainbus0: apid 2 (application processor)
cpu2: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.39 MHz, 06-45-01
cpu2: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu2: 256KB 64b/line 8-way L2 cache
cpu2: smt 0, core 1, package 0
cpu3 at mainbus0: apid 3 (application processor)
cpu3: Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, 1995.39 MHz, 06-45-01
cpu3: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,SMX,EST,TM2,SSSE3,SDBG,FMA3,CX16,xTPR,PDCM,PCID,SSE4.1,SSE4.2,x2APIC,MOVBE,POPCNT,DEADLINE,AES,XSAVE,AVX,F16C,RDRAND,NXE,PAGE1GB,RDTSCP,LONG,LAHF,ABM,PERF,ITSC,FSGSBASE,BMI1,AVX2,SMEP,BMI2,ERMS,INVPCID,IBRS,IBPB,STIBP,L1DF,SSBD,SENSOR,ARAT,XSAVEOPT,MELTDOWN
cpu3: 256KB 64b/line 8-way L2 cache
cpu3: smt 1, core 1, package 0
ioapic0 at mainbus0: apid 2 pa 0xfec00000, version 20, 40 pins
acpimcfg0 at acpi0
acpimcfg0: addr 0xf8000000, bus 0-63
acpiprt0 at acpi0: bus 0 (PCI0)
acpiprt1 at acpi0: bus -1 (PEG_)
acpiprt2 at acpi0: bus 2 (EXP1)
acpiprt3 at acpi0: bus 3 (EXP2)
acpiprt4 at acpi0: bus -1 (EXP3)
acpicpu0 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS
acpicpu1 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS
acpicpu2 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS
acpicpu3 at acpi0: C3(200@506 mwait.1@0x60), C2(200@148 mwait.1@0x33), C1(1000@1 mwait.1), PSS
acpipwrres0 at acpi0: PUBS, resource for XHCI, EHC1
acpitz0 at acpi0: critical temperature is 200 degC
dwiic0 at acpi0 I2C1 addr 0xfe105000/0x1000 irq 7
iic0 at dwiic0
"CPLM3218" at iic0 addr 0x48 not configured
acpibtn0 at acpi0: LID_
acpibtn1 at acpi0: SLPB
acpipci0 at acpi0 PCI0: 0x00000000 0x00000011 0x00000001
acpicmos0 at acpi0
acpibat0 at acpi0: BAT0 model "45N1703" serial  3191 type LiP oem "SMP"
acpiac0 at acpi0: AC unit online
acpithinkpad0 at acpi0
"PNP0C14" at acpi0 not configured
"PNP0C14" at acpi0 not configured
"PNP0C14" at acpi0 not configured
"INT340F" at acpi0 not configured
acpivideo0 at acpi0: VID_
acpivout at acpivideo0 not configured
acpivideo1 at acpi0: VID_
cpu0: Enhanced SpeedStep 1995 MHz: speeds: 2701, 2700, 2600, 2400, 2300, 2100, 2000, 1800, 1700, 1600, 1400, 1300, 1100, 1000, 800, 756 MHz
pci0 at mainbus0 bus 0
pchb0 at pci0 dev 0 function 0 "Intel Core 4G Host" rev 0x0b
inteldrm0 at pci0 dev 2 function 0 "Intel HD Graphics" rev 0x0b
drm0 at inteldrm0
inteldrm0: msi
inteldrm0: 2560x1440, 32bpp
wsdisplay0 at inteldrm0 mux 1: console (std, vt100 emulation)
wsdisplay0: screen 1-5 added (std, vt100 emulation)
azalia0 at pci0 dev 3 function 0 "Intel Core 4G HD Audio" rev 0x0b: msi
azalia0: No codecs found
xhci0 at pci0 dev 20 function 0 "Intel 8 Series xHCI" rev 0x04: msi, xHCI 1.0
usb0 at xhci0: USB revision 3.0
uhub0 at usb0 configuration 1 interface 0 "Intel xHCI root hub" rev 3.00/1.00 addr 1
"Intel 8 Series MEI" rev 0x04 at pci0 dev 22 function 0 not configured
puc0 at pci0 dev 22 function 3 "Intel 8 Series KT" rev 0x04: ports: 16 com
com4 at puc0 port 0 apic 2 int 17: ns16550a, 16 byte fifo
com4: probed fifo depth: 0 bytes
em0 at pci0 dev 25 function 0 "Intel I218-LM" rev 0x04: msi, address 54:ee:75:3d:fb:31
azalia1 at pci0 dev 27 function 0 "Intel 8 Series HD Audio" rev 0x04: msi
azalia1: codecs: Realtek ALC292
audio0 at azalia1
ppb0 at pci0 dev 28 function 0 "Intel 8 Series PCIE" rev 0xe4: msi
pci1 at ppb0 bus 2
ppb1 at pci0 dev 28 function 1 "Intel 8 Series PCIE" rev 0xe4: msi
pci2 at ppb1 bus 3
iwm0 at pci2 dev 0 function 0 "Intel Dual Band Wireless AC 7260" rev 0x83, msi
ehci0 at pci0 dev 29 function 0 "Intel 8 Series USB" rev 0x04: apic 2 int 23
usb1 at ehci0: USB revision 2.0
uhub1 at usb1 configuration 1 interface 0 "Intel EHCI root hub" rev 2.00/1.00 addr 1
pcib0 at pci0 dev 31 function 0 "Intel 8 Series LPC" rev 0x04
ahci0 at pci0 dev 31 function 2 "Intel 8 Series AHCI" rev 0x04: msi, AHCI 1.3
ahci0: port 0: 6.0Gb/s
scsibus1 at ahci0: 32 targets
sd0 at scsibus1 targ 0 lun 0: <ATA, TOSHIBA THNSNJ51, JULA> SCSI3 0/direct fixed naa.500080dc001bf1e2
sd0: 488386MB, 512 bytes/sector, 1000215216 sectors, thin
ichiic0 at pci0 dev 31 function 3 "Intel 8 Series SMBus" rev 0x04: apic 2 int 18
iic1 at ichiic0
isa0 at pcib0
isadma0 at isa0
pckbc0 at isa0 port 0x60/5 irq 1 irq 12
pckbd0 at pckbc0 (kbd slot)
wskbd0 at pckbd0: console keyboard, using wsdisplay0
pms0 at pckbc0 (aux slot)
wsmouse0 at pms0 mux 0
wsmouse1 at pms0 mux 0
pms0: Synaptics clickpad, firmware 8.1, 0x1e2b1 0x940300
pcppi0 at isa0 port 0x61
spkr0 at pcppi0
vmm0 at mainbus0: VMX/EPT
uhub2 at uhub0 port 1 configuration 1 interface 0 "Texas Instruments product 0x8142" rev 2.10/1.00 addr 2
uhidev0 at uhub2 port 1 configuration 1 interface 1 "Texas Instruments Inc. Texas Instruments USB Billboard Device" rev 2.01/1.00 addr 3
uhidev0: iclass 3/0
uhid0 at uhidev0: input=64, output=64, feature=2
ugen0 at uhub2 port 1 configuration 1 "Texas Instruments Inc. Texas Instruments USB Billboard Device" rev 2.01/1.00 addr 3
uticom0 at uhub2 port 4 "Texas Instruments TUSB3410 EECode Ser" rev 1.10/1.01 addr 4
uhidev1 at uhub0 port 2 configuration 1 interface 0 "Microsoft Microsoft\M-. 2.4GHz Transceiver v9.0" rev 2.00/7.97 addr 5
uhidev1: iclass 3/1
ukbd0 at uhidev1: 8 variable keys, 6 key codes
wskbd1 at ukbd0 mux 1
wskbd1: connecting to wsdisplay0
uhidev2 at uhub0 port 2 configuration 1 interface 1 "Microsoft Microsoft\M-. 2.4GHz Transceiver v9.0" rev 2.00/7.97 addr 5
uhidev2: iclass 3/1, 26 report ids
uhid1 at uhidev2 reportid 18: input=0, output=0, feature=1
uhid2 at uhidev2 reportid 23: input=0, output=0, feature=1
ums0 at uhidev2 reportid 26: 5 buttons, Z and W dir
wsmouse2 at ums0 mux 0
uhidev3 at uhub0 port 2 configuration 1 interface 2 "Microsoft Microsoft\M-. 2.4GHz Transceiver v9.0" rev 2.00/7.97 addr 5
uhidev3: iclass 3/0, 39 report ids
uhid3 at uhidev3 reportid 3: input=1, output=0, feature=0
uhid4 at uhidev3 reportid 7: input=7, output=0, feature=0
uhid5 at uhidev3 reportid 32: input=0, output=0, feature=18
uhid6 at uhidev3 reportid 33: input=2, output=0, feature=0
uhid7 at uhidev3 reportid 34: input=0, output=0, feature=26
uhid8 at uhidev3 reportid 35: input=0, output=0, feature=26
uhid9 at uhidev3 reportid 36: input=0, output=0, feature=31
uhid10 at uhidev3 reportid 37: input=0, output=0, feature=31
uhid11 at uhidev3 reportid 38: input=0, output=0, feature=31
uhid12 at uhidev3 reportid 39: input=31, output=0, feature=0
umb0 at uhub0 port 4 configuration 1 interface 0 "Sierra Wireless Inc. Sierra Wireless EM7345 4G LTE" rev 2.00/17.29 addr 6
umodem0 at uhub0 port 4 configuration 1 interface 2 "Sierra Wireless Inc. Sierra Wireless EM7345 4G LTE" rev 2.00/17.29 addr 6
umodem0: data interface 3, has no CM over data, has break
umodem0: status change notification available
ucom0 at umodem0
uhub3 at uhub0 port 10 configuration 1 interface 0 "Texas Instruments product 0x8140" rev 3.00/1.00 addr 7
uhub4 at uhub1 port 1 configuration 1 interface 0 "Intel Rate Matching Hub" rev 2.00/0.04 addr 2
uhidev4 at uhub4 port 5 configuration 1 interface 0 "ELAN Touchscreen" rev 2.00/0.12 addr 3
uhidev4: iclass 3/0, 68 report ids
ums1 at uhidev4 reportid 1: 1 button, tip
wsmouse3 at ums1 mux 0
uhid13 at uhidev4 reportid 2: input=64, output=0, feature=0
uhid14 at uhidev4 reportid 3: input=0, output=31, feature=0
uhid15 at uhidev4 reportid 4: input=19, output=0, feature=0
uhid16 at uhidev4 reportid 10: input=0, output=0, feature=1
ums2 at uhidev4 reportid 68
ums2: mouse has no X report
uvideo0 at uhub4 port 8 configuration 1 interface 0 "Chicony Electronics Co.,Ltd. Integrated Camera" rev 2.00/25.09 addr 4
video0 at uvideo0
vscsi0 at root
scsibus2 at vscsi0: 256 targets
softraid0 at root
scsibus3 at softraid0: 256 targets
sd1 at scsibus3 targ 1 lun 0: <OPENBSD, SR CRYPTO, 006> SCSI2 0/direct fixed
sd1: 488381MB, 512 bytes/sector, 1000206308 sectors
root on sd1a (f3054894d8af4b99.a) swap on sd1b dump on sd1b
WARNING: / was not properly unmounted
iwm0: hw rev 0x140, fw ver 16.242414.0, address 5c:c5:d4:63:b3:d9
uticom0: error reloading device descriptor



--
I'm not entirely sure you are real.

Reply | Threaded
Open this post in threaded view
|

Re: usbd_fill_deviceinfo page fault trap

Martin Pieuchot
On 10/02/19(Sun) 10:25, Florian Obser wrote:

> on resume I was greeted by:
> [typed from a photo (http://sha256.net/dump/usbd_fill_deviceinfo.jpg)]
> kernel: page fault trap, code =0
> Stopped at strlcpy+0x35: movzbl 0(%rsi, %rax,1), %ecx
> strlcpy(ffff800001459c81,0,7f) at strlcpy+0x35
> usbd_fill_deviceinfo at usbd_fill_deviceinfo+0x4f
> usbioctl at usbioctl+0x409
> VOP_IOCTL at VOP_IOCTL+0x61
> vn_ioctl at vn_ioctl+0x6e
> sys_ioctl at sys_ioctl+0x3d5
> syscall at syscall+0x338
> Xsyscall(6,36,4,36,3,0) at Xsyscall+0x128
>
> I have a suspicion that this is related to my external monitor that
> acts as a usb hub. Upon wake up I also turn on the monitor and then
> random usb devices show up.

Looks like a race.  Does the diff below help?

Index: usb_subr.c
===================================================================
RCS file: /cvs/src/sys/dev/usb/usb_subr.c,v
retrieving revision 1.147
diff -u -p -r1.147 usb_subr.c
--- usb_subr.c 22 Jan 2019 14:25:56 -0000 1.147
+++ usb_subr.c 10 Feb 2019 17:52:26 -0000
@@ -1208,7 +1208,6 @@ usbd_new_device(struct device *parent, s
  * address does not correspond to the hardware one.
  */
  dev->address = addr;
- bus->devices[addr] = dev;
 
  err = usbd_reload_device_desc(dev);
  if (err) {
@@ -1244,6 +1243,8 @@ usbd_new_device(struct device *parent, s
  up->device = NULL;
  return (err);
    }
+
+ bus->devices[addr] = dev;
 
  err = usbd_probe_and_attach(parent, dev, port, addr);
  if (err) {

Reply | Threaded
Open this post in threaded view
|

Re: usbd_fill_deviceinfo page fault trap

Florian Obser-2
On Sun, Feb 10, 2019 at 03:55:32PM -0200, Martin Pieuchot wrote:

> On 10/02/19(Sun) 10:25, Florian Obser wrote:
> > on resume I was greeted by:
> > [typed from a photo (http://sha256.net/dump/usbd_fill_deviceinfo.jpg)]
> > kernel: page fault trap, code =0
> > Stopped at strlcpy+0x35: movzbl 0(%rsi, %rax,1), %ecx
> > strlcpy(ffff800001459c81,0,7f) at strlcpy+0x35
> > usbd_fill_deviceinfo at usbd_fill_deviceinfo+0x4f
> > usbioctl at usbioctl+0x409
> > VOP_IOCTL at VOP_IOCTL+0x61
> > vn_ioctl at vn_ioctl+0x6e
> > sys_ioctl at sys_ioctl+0x3d5
> > syscall at syscall+0x338
> > Xsyscall(6,36,4,36,3,0) at Xsyscall+0x128
> >
> > I have a suspicion that this is related to my external monitor that
> > acts as a usb hub. Upon wake up I also turn on the monitor and then
> > random usb devices show up.
>
> Looks like a race.  Does the diff below help?

I don't know :(
I tried to reproduce without the diff but I was unsuccessful.

I'm running with the diff now. But it will be hard to declare success.

>
> Index: usb_subr.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/usb/usb_subr.c,v
> retrieving revision 1.147
> diff -u -p -r1.147 usb_subr.c
> --- usb_subr.c 22 Jan 2019 14:25:56 -0000 1.147
> +++ usb_subr.c 10 Feb 2019 17:52:26 -0000
> @@ -1208,7 +1208,6 @@ usbd_new_device(struct device *parent, s
>   * address does not correspond to the hardware one.
>   */
>   dev->address = addr;
> - bus->devices[addr] = dev;
>  
>   err = usbd_reload_device_desc(dev);
>   if (err) {
> @@ -1244,6 +1243,8 @@ usbd_new_device(struct device *parent, s
>   up->device = NULL;
>   return (err);
>     }
> +
> + bus->devices[addr] = dev;
>  
>   err = usbd_probe_and_attach(parent, dev, port, addr);
>   if (err) {
>


--
I'm not entirely sure you are real.

Reply | Threaded
Open this post in threaded view
|

Re: usbd_fill_deviceinfo page fault trap

Florian Obser-2
I think you should put it in. It seems to just work.
OK florian fwiw

On Tue, Feb 12, 2019 at 08:56:13AM +0100, Florian Obser wrote:

> On Sun, Feb 10, 2019 at 03:55:32PM -0200, Martin Pieuchot wrote:
> > On 10/02/19(Sun) 10:25, Florian Obser wrote:
> > > on resume I was greeted by:
> > > [typed from a photo (http://sha256.net/dump/usbd_fill_deviceinfo.jpg)]
> > > kernel: page fault trap, code =0
> > > Stopped at strlcpy+0x35: movzbl 0(%rsi, %rax,1), %ecx
> > > strlcpy(ffff800001459c81,0,7f) at strlcpy+0x35
> > > usbd_fill_deviceinfo at usbd_fill_deviceinfo+0x4f
> > > usbioctl at usbioctl+0x409
> > > VOP_IOCTL at VOP_IOCTL+0x61
> > > vn_ioctl at vn_ioctl+0x6e
> > > sys_ioctl at sys_ioctl+0x3d5
> > > syscall at syscall+0x338
> > > Xsyscall(6,36,4,36,3,0) at Xsyscall+0x128
> > >
> > > I have a suspicion that this is related to my external monitor that
> > > acts as a usb hub. Upon wake up I also turn on the monitor and then
> > > random usb devices show up.
> >
> > Looks like a race.  Does the diff below help?
>
> I don't know :(
> I tried to reproduce without the diff but I was unsuccessful.
>
> I'm running with the diff now. But it will be hard to declare success.
>
> >
> > Index: usb_subr.c
> > ===================================================================
> > RCS file: /cvs/src/sys/dev/usb/usb_subr.c,v
> > retrieving revision 1.147
> > diff -u -p -r1.147 usb_subr.c
> > --- usb_subr.c 22 Jan 2019 14:25:56 -0000 1.147
> > +++ usb_subr.c 10 Feb 2019 17:52:26 -0000
> > @@ -1208,7 +1208,6 @@ usbd_new_device(struct device *parent, s
> >   * address does not correspond to the hardware one.
> >   */
> >   dev->address = addr;
> > - bus->devices[addr] = dev;
> >  
> >   err = usbd_reload_device_desc(dev);
> >   if (err) {
> > @@ -1244,6 +1243,8 @@ usbd_new_device(struct device *parent, s
> >   up->device = NULL;
> >   return (err);
> >     }
> > +
> > + bus->devices[addr] = dev;
> >  
> >   err = usbd_probe_and_attach(parent, dev, port, addr);
> >   if (err) {
> >
>
>
> --
> I'm not entirely sure you are real.
>

--
I'm not entirely sure you are real.