update: sysutils/sysclean 1.3

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

update: sysutils/sysclean 1.3

Sebastien Marie-2
Hi,

Here a diff for updating sysutils/sysclean to 1.3
Special thanks to espie@ for his help in the rewrite in perl.

Comments or OK ?

Changes:
--------

Major rewrite of sysclean using perl(1):

- more accurate control of path walkthough (doesn't explore unknown
  directories)
- no more manual parsing of PKG_DB files
- manage more accurately @sample directories


Incompatible changes:

- the format of sysclean.ignore as slighlty changed: patterns aren't
  possible now, but just plain filenames (example file updated).
- network configuration files (/etc/hostname.*) aren't automatically
  ignored. You should add them to sysclean.ignore

Note: this release is same as 1.2, with just example file updated to
reflect new syntax.

--
Sebastien Marie


Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/sysclean/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- Makefile 12 Mar 2016 16:04:18 -0000 1.3
+++ Makefile 18 Apr 2016 07:26:05 -0000
@@ -2,7 +2,7 @@
 
 COMMENT = help removing obsolete files between OpenBSD upgrades
 
-V = 1.1
+V = 1.3
 DISTNAME = sysclean-${V}
 
 CATEGORIES = sysutils
Index: distinfo
===================================================================
RCS file: /cvs/ports/sysutils/sysclean/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo 12 Mar 2016 16:04:18 -0000 1.3
+++ distinfo 18 Apr 2016 07:26:05 -0000
@@ -1,2 +1,2 @@
-SHA256 (sysclean-1.1.tar.gz) = 5oZI0p6mT/sAEo8ogUbUgoscbOrZN7OuUDubEk5n53s=
-SIZE (sysclean-1.1.tar.gz) = 5012
+SHA256 (sysclean-1.3.tar.gz) = WnhZYMii1G9bBz91E7++ag/eYzGJDizp/z0VwKEpwTk=
+SIZE (sysclean-1.3.tar.gz) = 4352
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/sysutils/sysclean/pkg/DESCR,v
retrieving revision 1.2
diff -u -p -r1.2 DESCR
--- pkg/DESCR 12 Mar 2016 16:04:18 -0000 1.2
+++ pkg/DESCR 18 Apr 2016 07:26:05 -0000
@@ -1,4 +1,4 @@
-sysclean is a ksh(1) script designed to help removing obsolete files between
+sysclean is a perl(1) script designed to help removing obsolete files between
 upgrades.
 
 sysclean works by comparing a reference root directory against currently

Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Marc Espie-2
On Mon, Apr 18, 2016 at 09:41:31AM +0200, Sebastien Marie wrote:

> Index: pkg/DESCR
> ===================================================================
> RCS file: /cvs/ports/sysutils/sysclean/pkg/DESCR,v
> retrieving revision 1.2
> diff -u -p -r1.2 DESCR
> --- pkg/DESCR 12 Mar 2016 16:04:18 -0000 1.2
> +++ pkg/DESCR 18 Apr 2016 07:26:05 -0000
> @@ -1,4 +1,4 @@
> -sysclean is a ksh(1) script designed to help removing obsolete files between
> +sysclean is a perl(1) script designed to help removing obsolete files between
>  upgrades.
>  
>  sysclean works by comparing a reference root directory against currently
I don't think the language actually matters. Does it really belong in
the DESCR ?

Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Sebastien Marie-2
On Mon, Apr 18, 2016 at 12:01:29PM +0200, Marc Espie wrote:

> On Mon, Apr 18, 2016 at 09:41:31AM +0200, Sebastien Marie wrote:
> > Index: pkg/DESCR
> > ===================================================================
> > RCS file: /cvs/ports/sysutils/sysclean/pkg/DESCR,v
> > retrieving revision 1.2
> > diff -u -p -r1.2 DESCR
> > --- pkg/DESCR 12 Mar 2016 16:04:18 -0000 1.2
> > +++ pkg/DESCR 18 Apr 2016 07:26:05 -0000
> > @@ -1,4 +1,4 @@
> > -sysclean is a ksh(1) script designed to help removing obsolete files between
> > +sysclean is a perl(1) script designed to help removing obsolete files between
> >  upgrades.
> >  
> >  sysclean works by comparing a reference root directory against currently
> I don't think the language actually matters. Does it really belong in
> the DESCR ?
>

The DESCR is taken from the man page description. As this part of the
man page has changed, I updated DESCR too.

But I agreed that it doesn't matter of lot.

I will update it for the next release.

Thanks.
--
Sebastien Marie

Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Amit Kulkarni-5
In reply to this post by Sebastien Marie-2
On Mon, Apr 18, 2016 at 2:41 AM, Sebastien Marie <[hidden email]>
wrote:

> Hi,
>
> Here a diff for updating sysutils/sysclean to 1.3
> Special thanks to espie@ for his help in the rewrite in perl.
>
> Comments or OK ?
>
> Changes:
> --------
>
> Major rewrite of sysclean using perl(1):
>
> - more accurate control of path walkthough (doesn't explore unknown
>   directories)
> - no more manual parsing of PKG_DB files
> - manage more accurately @sample directories
>
>
> Incompatible changes:
>
> - the format of sysclean.ignore as slighlty changed: patterns aren't
>   possible now, but just plain filenames (example file updated).
> - network configuration files (/etc/hostname.*) aren't automatically
>   ignored. You should add them to sysclean.ignore
>
> Note: this release is same as 1.2, with just example file updated to
> reflect new syntax.
>


Thanks guys for the sysclean.ignore, I was going to ask for adding
/etc/doas.conf to the ignore :), but I can set it locally as well.
Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Sebastien Marie-2
On Mon, Apr 18, 2016 at 10:25:48AM -0500, Amit Kulkarni wrote:
>
> Thanks guys for the sysclean.ignore, I was going to ask for adding
> /etc/doas.conf to the ignore :), but I can set it locally as well.

The default list of expected files (files which aren't reported as
potentially "obsolete") is taken from a default install. Anything other
is reported (if not present in sysclean.ignore).

On a standard host, it could include lot of files in /etc... but
sysclean wouldn't have any way to know if it is a wanted file (because
you added it and still use it), or an old file (because for example you
don't use anymore the associated program).

So, as `/etc/doas.conf' isn't installed in a default install, you have
added it manually. So you can add it too in /etc/sysclean.ignore :)

Here is the logic behind.

Note that /etc/hostname.* are installed during install but are reported
with version 1.3 (whereas 1.1 doesn't). This problem will addressed in
upcoming 1.4.

Thanks for your interest.
--
Sebastien Marie

Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Marc Espie-2
On Mon, Apr 18, 2016 at 07:50:53PM +0200, Sebastien Marie wrote:

> On Mon, Apr 18, 2016 at 10:25:48AM -0500, Amit Kulkarni wrote:
> >
> > Thanks guys for the sysclean.ignore, I was going to ask for adding
> > /etc/doas.conf to the ignore :), but I can set it locally as well.
>
> The default list of expected files (files which aren't reported as
> potentially "obsolete") is taken from a default install. Anything other
> is reported (if not present in sysclean.ignore).
>
> On a standard host, it could include lot of files in /etc... but
> sysclean wouldn't have any way to know if it is a wanted file (because
> you added it and still use it), or an old file (because for example you
> don't use anymore the associated program).
>
> So, as `/etc/doas.conf' isn't installed in a default install, you have
> added it manually. So you can add it too in /etc/sysclean.ignore :)

for the next version, you may want to do s,/etc/examples/,/etc,  

Those files generally belong.

Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Amit Kulkarni-5
In reply to this post by Sebastien Marie-2
On Mon, Apr 18, 2016 at 12:50 PM, Sebastien Marie <[hidden email]>
wrote:

> On Mon, Apr 18, 2016 at 10:25:48AM -0500, Amit Kulkarni wrote:
> >
> > Thanks guys for the sysclean.ignore, I was going to ask for adding
> > /etc/doas.conf to the ignore :), but I can set it locally as well.
>
> The default list of expected files (files which aren't reported as
> potentially "obsolete") is taken from a default install. Anything other
> is reported (if not present in sysclean.ignore).
>
> On a standard host, it could include lot of files in /etc... but
> sysclean wouldn't have any way to know if it is a wanted file (because
> you added it and still use it), or an old file (because for example you
> don't use anymore the associated program).
>
> So, as `/etc/doas.conf' isn't installed in a default install, you have
> added it manually. So you can add it too in /etc/sysclean.ignore :)
>
> Here is the logic behind.
>
> Note that /etc/hostname.* are installed during install but are reported
> with version 1.3 (whereas 1.1 doesn't). This problem will addressed in
> upcoming 1.4.
>
> Thanks for your interest.
>

Thanks, I cleaned my machine dating back almost 3 years of upgrades, it is
now almost like new :)
Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Dimitris Papastamos
In reply to this post by Sebastien Marie-2
On Mon, Apr 18, 2016 at 09:41:31AM +0200, Sebastien Marie wrote:
> Hi,
>
> Here a diff for updating sysutils/sysclean to 1.3
> Special thanks to espie@ for his help in the rewrite in perl.
>
> Comments or OK ?

Any ideas as to why all the manpages are listed when
I run it in filename mode?

The output is:

/usr/share/man/man1/c++.1
/usr/share/man/man1/cc.1
/usr/share/man/man1/g++.1
/usr/share/man/man1/lex.1
/usr/share/man/man1/Mail.1
.
.
.

this goes on for about 4k entries.

I run this on -current.  This issue isn't specific to 1.3 as
I had the same behaviour with 1.1.  It is probably not related
to sysclean but maybe something in base that changed?

Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3

Sebastien Marie-2
On Tue, Apr 19, 2016 at 12:38:50AM +0100, Dimitris Papastamos wrote:

>
> Any ideas as to why all the manpages are listed when
> I run it in filename mode?
>
> The output is:
>
> /usr/share/man/man1/c++.1
> /usr/share/man/man1/cc.1
> /usr/share/man/man1/g++.1
> /usr/share/man/man1/lex.1
> /usr/share/man/man1/Mail.1
> .
> .
> .
>
> this goes on for about 4k entries.
>
> I run this on -current.  This issue isn't specific to 1.3 as
> I had the same behaviour with 1.1.  It is probably not related
> to sysclean but maybe something in base that changed?
>

You are right: something in base have changed :)

http://anoncvs.spacehopper.org/openbsd-src/commit/?id=e61f05d590b15eded29cc16e6289e5841e040a29

lot of MLINKS has been removed from base, resulting lot of man page
removed (in fact, links to original man page).

here sysclean does the right thing: these files aren't present anymore
in a fresh install.
--
Sebastien Marie

Reply | Threaded
Open this post in threaded view
|

Re: update: sysutils/sysclean 1.3^W1.4

Sebastien Marie-2
In reply to this post by Sebastien Marie-2
Hi,

Release early, release often. So here a new release for sysclean.

The version corrects several problems or regressions from 1.1:
 - ignore @extra entries from ports as well
 - considers /etc/hostname.* as expected files, as they came with
   default install
 - strip comments in sysclean.ignore  

And with this version, sysclean is now pledged:
  - starts with "rpath proc exec" due to locate(1) usage for get list of
    expected files in base

  - switch to "rpath" after

The /usr/src/ports diff includes the changes proposed by espie@ for
DESCR (no need to mentions it is a perl(1) script).

Comments ?
--
Sebastien Marie


Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/sysclean/Makefile,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile
--- Makefile 18 Apr 2016 08:34:23 -0000 1.4
+++ Makefile 19 Apr 2016 07:04:21 -0000
@@ -2,7 +2,7 @@
 
 COMMENT = help removing obsolete files between OpenBSD upgrades
 
-V = 1.3
+V = 1.4
 DISTNAME = sysclean-${V}
 
 CATEGORIES = sysutils
Index: distinfo
===================================================================
RCS file: /cvs/ports/sysutils/sysclean/distinfo,v
retrieving revision 1.4
diff -u -p -r1.4 distinfo
--- distinfo 18 Apr 2016 08:34:23 -0000 1.4
+++ distinfo 19 Apr 2016 07:04:21 -0000
@@ -1,2 +1,2 @@
-SHA256 (sysclean-1.3.tar.gz) = WnhZYMii1G9bBz91E7++ag/eYzGJDizp/z0VwKEpwTk=
-SIZE (sysclean-1.3.tar.gz) = 4352
+SHA256 (sysclean-1.4.tar.gz) = B4JBu/3dlTc7MxeUl/yjVeZu9OL4Uf/AEDN/TtaZGHQ=
+SIZE (sysclean-1.4.tar.gz) = 4504
Index: pkg/DESCR
===================================================================
RCS file: /cvs/ports/sysutils/sysclean/pkg/DESCR,v
retrieving revision 1.3
diff -u -p -r1.3 DESCR
--- pkg/DESCR 18 Apr 2016 08:34:23 -0000 1.3
+++ pkg/DESCR 19 Apr 2016 07:04:21 -0000
@@ -1,5 +1,4 @@
-sysclean is a perl(1) script designed to help removing obsolete files between
-upgrades.
+sysclean is a script designed to help removing obsolete files between upgrades.
 
 sysclean works by comparing a reference root directory against currently
 installed files. It considers standard system files, configuration files