update mpv 0.33.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

update mpv 0.33.1

Nam Nguyen
Here is an update for mpv 0.33.1, which is a security fix release,
released on April 5, 2021.

Changelog: https://github.com/mpv-player/mpv/releases/tag/v0.33.1

This diff does the following:
- resyncs # 1.109 with ${WRKSRC}/DOCS/client-api-changes.rst
- paranoid major bump ahead of upstream's "eventual libmpv 2.0 bump."
  see:
  https://github.com/mpv-player/mpv/commit/4b3500dd1414d8406f77ef3e68d606d3a69f1a5e

client-api-changes.rst has been useful. check_sym reported no
changes. Diffing headers in /usr/local/include/mpv shows no changes.

Revision 1.66 of Makefile bumped libmpv 0.1 --> 0.2. However, I think
this should have been a major bump. A reason to do is that
mpv_opengl_cb_init_gl now returns an error. Upstream plans an "eventual
libmpv 2.0 bump," as noted in the commit message above. (Normally,
deprecation does not affect library versioning, but the API changed so
valid sequences are no longer valid.)

waf is used for the build system and does not need to be updated, per
the waf version in ${WRKSRC}/bootstrap.py.

I tested by playing an mkv file.

Feedback and tests are welcome. OK?

Index: Makefile
===================================================================
RCS file: /cvs/ports/multimedia/mpv/Makefile,v
retrieving revision 1.70
diff -u -p -u -p -r1.70 Makefile
--- Makefile 23 Feb 2021 19:39:30 -0000 1.70
+++ Makefile 5 Apr 2021 22:58:01 -0000
@@ -4,10 +4,9 @@ COMMENT = movie player based on MPlayer
 
 GH_ACCOUNT = mpv-player
 GH_PROJECT = mpv
-GH_TAGNAME = v0.33.0
-REVISION = 2
+GH_TAGNAME = v0.33.1
 
-SHARED_LIBS += mpv 0.2 # 1.107
+SHARED_LIBS += mpv 1.0 # 1.109
 
 CATEGORIES = multimedia x11
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/multimedia/mpv/distinfo,v
retrieving revision 1.25
diff -u -p -u -p -r1.25 distinfo
--- distinfo 21 Dec 2020 08:57:20 -0000 1.25
+++ distinfo 5 Apr 2021 22:58:01 -0000
@@ -1,4 +1,4 @@
-SHA256 (mpv-0.33.0.tar.gz) = 8bm69dwu6vN2WXwopigfrPbtmP89Vn45Vclb8kWVILQ=
+SHA256 (mpv-0.33.1.tar.gz) = EAoRa58jvc2jpZbp8mvjpp8Wak8dAJENF4m2VxxG86k=
 SHA256 (waf-2.0.20) = v5cemO3CQUloomLGqmuIVBomw80khonIn0xXNwlV7n8=
-SIZE (mpv-0.33.0.tar.gz) = 3259387
+SIZE (mpv-0.33.1.tar.gz) = 3259882
 SIZE (waf-2.0.20) = 104725

Reply | Threaded
Open this post in threaded view
|

Re: update mpv 0.33.1

Stuart Henderson
On 2021/04/05 16:32, Nam Nguyen wrote:

> Here is an update for mpv 0.33.1, which is a security fix release,
> released on April 5, 2021.
>
> Changelog: https://github.com/mpv-player/mpv/releases/tag/v0.33.1
>
> This diff does the following:
> - resyncs # 1.109 with ${WRKSRC}/DOCS/client-api-changes.rst
> - paranoid major bump ahead of upstream's "eventual libmpv 2.0 bump."
>   see:
>   https://github.com/mpv-player/mpv/commit/4b3500dd1414d8406f77ef3e68d606d3a69f1a5e

The bump is not needdd, they have specifically done it this way so that the
ABI does not change, i.e. so that a bump is not needed. Othereise OK

Reply | Threaded
Open this post in threaded view
|

Re: update mpv 0.33.1

Brad Smith-14
In reply to this post by Nam Nguyen
On 4/5/2021 7:32 PM, Nam Nguyen wrote:

> Here is an update for mpv 0.33.1, which is a security fix release,
> released on April 5, 2021.
>
> Changelog: https://github.com/mpv-player/mpv/releases/tag/v0.33.1
>
> This diff does the following:
> - resyncs # 1.109 with ${WRKSRC}/DOCS/client-api-changes.rst
> - paranoid major bump ahead of upstream's "eventual libmpv 2.0 bump."
>    see:
>    https://github.com/mpv-player/mpv/commit/4b3500dd1414d8406f77ef3e68d606d3a69f1a5e
>
> client-api-changes.rst has been useful. check_sym reported no
> changes. Diffing headers in /usr/local/include/mpv shows no changes.
>
> Revision 1.66 of Makefile bumped libmpv 0.1 --> 0.2. However, I think
> this should have been a major bump. A reason to do is that
> mpv_opengl_cb_init_gl now returns an error. Upstream plans an "eventual
> libmpv 2.0 bump," as noted in the commit message above. (Normally,
> deprecation does not affect library versioning, but the API changed so
> valid sequences are no longer valid.)
>
> waf is used for the build system and does not need to be updated, per
> the waf version in ${WRKSRC}/bootstrap.py.
>
> I tested by playing an mkv file.
>
> Feedback and tests are welcome. OK?
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/multimedia/mpv/Makefile,v
> retrieving revision 1.70
> diff -u -p -u -p -r1.70 Makefile
> --- Makefile 23 Feb 2021 19:39:30 -0000 1.70
> +++ Makefile 5 Apr 2021 22:58:01 -0000
> @@ -4,10 +4,9 @@ COMMENT = movie player based on MPlayer
>  
>   GH_ACCOUNT = mpv-player
>   GH_PROJECT = mpv
> -GH_TAGNAME = v0.33.0
> -REVISION = 2
> +GH_TAGNAME = v0.33.1
>  
> -SHARED_LIBS += mpv 0.2 # 1.107
> +SHARED_LIBS += mpv 1.0 # 1.109
>  
>   CATEGORIES = multimedia x11
>  
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/multimedia/mpv/distinfo,v
> retrieving revision 1.25
> diff -u -p -u -p -r1.25 distinfo
> --- distinfo 21 Dec 2020 08:57:20 -0000 1.25
> +++ distinfo 5 Apr 2021 22:58:01 -0000
> @@ -1,4 +1,4 @@
> -SHA256 (mpv-0.33.0.tar.gz) = 8bm69dwu6vN2WXwopigfrPbtmP89Vn45Vclb8kWVILQ=
> +SHA256 (mpv-0.33.1.tar.gz) = EAoRa58jvc2jpZbp8mvjpp8Wak8dAJENF4m2VxxG86k=
>   SHA256 (waf-2.0.20) = v5cemO3CQUloomLGqmuIVBomw80khonIn0xXNwlV7n8=
> -SIZE (mpv-0.33.0.tar.gz) = 3259387
> +SIZE (mpv-0.33.1.tar.gz) = 3259882
>   SIZE (waf-2.0.20) = 104725

Without umping the lib rev it is fine. OK.