[update] liblognorm 2.0.6

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[update] liblognorm 2.0.6

Remi Locherer
Hi porters,

This updates liblognorm to version 2.0.6.

Release notes can be found here:
https://www.liblognorm.com/news/liblognorm-2-0-6-released/

The tests changed and added now #!/bin/bash. With fixed shebangs
and a TEST_DEPENDS shells/bash all tests pass.

check_sym says:

/usr/local/lib/liblognorm.so.0.0 --> /usr/ports/pobj/liblognorm-2.0.6/build-amd64/src/.libs/liblognorm.so.0.0
Dynamic export changes:
added:
        ln_constructCheckpointLEA
        ln_destructCheckpointLEA

External reference changes:
removed:
        __stack_smash_handler


Is my bump for SHARED_LIBS enough or should it be 1.0?

Remi


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/liblognorm/Makefile,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile
--- Makefile 28 Apr 2018 13:04:21 -0000 1.2
+++ Makefile 4 May 2019 20:44:43 -0000
@@ -2,9 +2,9 @@
 
 COMMENT = fast-samples based normalization library
 
-DISTNAME = liblognorm-2.0.5
+DISTNAME = liblognorm-2.0.6
 
-SHARED_LIBS += lognorm 0.0 # 0.0
+SHARED_LIBS += lognorm 0.1 # 6.0
 
 CATEGORIES = devel
 
@@ -15,6 +15,8 @@ PERMIT_PACKAGE_CDROM = Yes
 
 WANTLIB += c estr fastjson
 
+MASTER_SITES = http://www.liblognorm.com/files/download/
+
 AUTOCONF_VERSION = 2.69
 AUTOMAKE_VERSION = 1.15
 
@@ -25,10 +27,15 @@ BUILD_DEPENDS = ${MODGNU_AUTOCONF_DEPEND
 LIB_DEPENDS = devel/libestr \
  devel/libfastjson
 
-MASTER_SITES = http://www.liblognorm.com/files/download/
+TEST_DEPENDS = shells/bash
+
+SEPARATE_BUILD = Yes
 
 CONFIGURE_STYLE = gnu
 CONFIGURE_ENV = CPPFLAGS="-I${LOCALBASE}/include"
+
+post-extract:
+ sed -i s,#!/bin/bash,#!${LOCALBASE}/bin/bash, ${WRKSRC}/tests/*.sh
 
 post-patch:
  cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} \
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/liblognorm/distinfo,v
retrieving revision 1.2
diff -u -p -r1.2 distinfo
--- distinfo 28 Apr 2018 13:04:21 -0000 1.2
+++ distinfo 4 May 2019 20:19:58 -0000
@@ -1,2 +1,2 @@
-SHA256 (liblognorm-2.0.5.tar.gz) = yBUdqDshAx8Ii7Ko6mdOT37lhVGCnphQKCRYQTMNsZA=
-SIZE (liblognorm-2.0.5.tar.gz) = 667709
+SHA256 (liblognorm-2.0.6.tar.gz) = z/BX6FwiA4mS+e0S641OY8Ra31OlpR+qoyefYFgJ9vI=
+SIZE (liblognorm-2.0.6.tar.gz) = 666712

Reply | Threaded
Open this post in threaded view
|

Re: [update] liblognorm 2.0.6

Jeremie Courreges-Anglas-2
On Sat, May 04 2019, Remi Locherer <[hidden email]> wrote:

> Hi porters,
>
> This updates liblognorm to version 2.0.6.
>
> Release notes can be found here:
> https://www.liblognorm.com/news/liblognorm-2-0-6-released/
>
> The tests changed and added now #!/bin/bash. With fixed shebangs
> and a TEST_DEPENDS shells/bash all tests pass.
>
> check_sym says:
>
> /usr/local/lib/liblognorm.so.0.0 --> /usr/ports/pobj/liblognorm-2.0.6/build-amd64/src/.libs/liblognorm.so.0.0
> Dynamic export changes:
> added:
>         ln_constructCheckpointLEA
>         ln_destructCheckpointLEA
>
> External reference changes:
> removed:
>         __stack_smash_handler
>
>
> Is my bump for SHARED_LIBS enough or should it be 1.0?

Looks like it's enough: no symbol removal and no change in the only
header we install, liblognorm.h.  IIUC the newly exported functions are
internal.

Looks good ports-wise, ok jca@.  I'd suggest to move HOMEPAGE and
MASTER_SITES to https while here.

PS: upstream should clear up the situation wrt the headers they install
by default.  Either those .h shouldn't be installed, or they should be
installed in an include/liblognorm subdirectory, as their name is too
generic.

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: [update] liblognorm 2.0.6

Remi Locherer
On Sun, May 05, 2019 at 01:17:55PM +0200, Jeremie Courreges-Anglas wrote:

> On Sat, May 04 2019, Remi Locherer <[hidden email]> wrote:
> > Hi porters,
> >
> > This updates liblognorm to version 2.0.6.
> >
> > Release notes can be found here:
> > https://www.liblognorm.com/news/liblognorm-2-0-6-released/
> >
> > The tests changed and added now #!/bin/bash. With fixed shebangs
> > and a TEST_DEPENDS shells/bash all tests pass.
> >
> > check_sym says:
> >
> > /usr/local/lib/liblognorm.so.0.0 --> /usr/ports/pobj/liblognorm-2.0.6/build-amd64/src/.libs/liblognorm.so.0.0
> > Dynamic export changes:
> > added:
> >         ln_constructCheckpointLEA
> >         ln_destructCheckpointLEA
> >
> > External reference changes:
> > removed:
> >         __stack_smash_handler
> >
> >
> > Is my bump for SHARED_LIBS enough or should it be 1.0?
>
> Looks like it's enough: no symbol removal and no change in the only
> header we install, liblognorm.h.  IIUC the newly exported functions are
> internal.
>
> Looks good ports-wise, ok jca@.  I'd suggest to move HOMEPAGE and
> MASTER_SITES to https while here.

sure!

> PS: upstream should clear up the situation wrt the headers they install
> by default.  Either those .h shouldn't be installed, or they should be
> installed in an include/liblognorm subdirectory, as their name is too
> generic.

I sent a mail to the project when importing the port. This time I opened
a pull request on GitHub.