update: audio/py-eyed3

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

update: audio/py-eyed3

Paco Esteban-2
Hi ports@,

This is an update for audio/py-eyed3 from  0.8.12 to latest 0.9.5
You can see the can see the changes here:

https://github.com/nicfit/eyeD3/blob/master/HISTORY.rst

The update is pretty simple.

I tried to enable tests by creating a port for the missing port
`factory_boy`, but this pulls a pretty big tree of dependencies just to
enable those tests, so I think is not worth it.

This only has one consumer, audio/py-mutagen and only on the py2 variant
(which is weird, because this is a py3 only port, so I guess it uses the
cli directly).

Tests on the consumer are the same before and after the update:

  3 failed, 3801 passed

comments ? ok ?

Index: Makefile
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- Makefile 29 Feb 2020 15:54:33 -0000 1.21
+++ Makefile 20 May 2020 17:09:09 -0000
@@ -2,7 +2,7 @@
 
 COMMENT= module and program for processing ID3 tags
 
-MODPY_EGG_VERSION= 0.8.12
+MODPY_EGG_VERSION= 0.9.5
 DISTNAME= eyeD3-${MODPY_EGG_VERSION}
 CATEGORIES= audio
 
Index: distinfo
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo 28 Dec 2019 15:13:25 -0000 1.8
+++ distinfo 20 May 2020 18:03:38 -0000
@@ -1,2 +1,2 @@
-SHA256 (eyeD3-0.8.12.tar.gz) = 5U7sCgP7jn6ei1CVRsbZLvvIcep1l2Ef4sFvA+HJS20=
-SIZE (eyeD3-0.8.12.tar.gz) = 214073
+SHA256 (eyeD3-0.9.5.tar.gz) = +vWAYZfyCT6CwoMNQfI3jwezqdoHoW+vsU/G+966xQo=
+SIZE (eyeD3-0.9.5.tar.gz) = 222994
Index: pkg/PLIST
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/pkg/PLIST,v
retrieving revision 1.5
diff -u -p -r1.5 PLIST
--- pkg/PLIST 28 Dec 2019 15:13:26 -0000 1.5
+++ pkg/PLIST 20 May 2020 18:05:38 -0000
@@ -14,10 +14,9 @@ lib/python${MODPY_VERSION}/site-packages
 ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}/
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}__about__.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
-lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}compat.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}core.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}main.${MODPY_PYC_MAGIC_TAG}pyc
-lib/python${MODPY_VERSION}/site-packages/eyed3/compat.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}mimetype.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/core.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/__init__.py
@@ -32,6 +31,7 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/headers.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/tag.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/main.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/mimetype.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/
 lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/__init__.py
 ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/${MODPY_PYCACHE}/
@@ -46,28 +46,36 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}art.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}classic.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}display.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}extract.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}fixup.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}genres.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}itunes.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}jsontag.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}lameinfo.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}lastfm.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}mimetype.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}nfo.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}pymod.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}stats.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}xep_118.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}yamltag.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/_display_parser.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/art.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/classic.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/display.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/extract.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/fixup.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/genres.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/itunes.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/jsontag.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/lameinfo.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/lastfm.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/mimetype.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/nfo.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/pymod.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/stats.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/xep_118.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/yamltag.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/utils/
 lib/python${MODPY_VERSION}/site-packages/eyed3/utils/__init__.py
 ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/utils/${MODPY_PYCACHE}/

--
Paco Esteban.
0x5818130B8A6DBC03

Reply | Threaded
Open this post in threaded view
|

Re: update: audio/py-eyed3

Stuart Henderson
On 2020/05/20 20:37, Paco Esteban wrote:

> Hi ports@,
>
> This is an update for audio/py-eyed3 from  0.8.12 to latest 0.9.5
> You can see the can see the changes here:
>
> https://github.com/nicfit/eyeD3/blob/master/HISTORY.rst
>
> The update is pretty simple.
>
> I tried to enable tests by creating a port for the missing port
> `factory_boy`, but this pulls a pretty big tree of dependencies just to
> enable those tests, so I think is not worth it.
>
> This only has one consumer, audio/py-mutagen and only on the py2 variant
> (which is weird, because this is a py3 only port, so I guess it uses the
> cli directly).

It does use the module, I think I just missed that when I changed eyeD3
to use py3. I'll fix that in mutagen.

> Tests on the consumer are the same before and after the update:
>
>   3 failed, 3801 passed
>
> comments ? ok ?

Running the eyeD3 script fails:

pkg_resources.DistributionNotFound: The 'deprecation' distribution was not found and is required by eyeD3

Also py-magic is no longer required.

Reply | Threaded
Open this post in threaded view
|

Re: update: audio/py-eyed3

Paco Esteban-2
On Thu, 21 May 2020, Stuart Henderson wrote:

> On 2020/05/20 20:37, Paco Esteban wrote:
> > Hi ports@,
> >
> > This is an update for audio/py-eyed3 from  0.8.12 to latest 0.9.5
> > You can see the can see the changes here:
> >
> > https://github.com/nicfit/eyeD3/blob/master/HISTORY.rst
> >
> > The update is pretty simple.
> >
> > I tried to enable tests by creating a port for the missing port
> > `factory_boy`, but this pulls a pretty big tree of dependencies just to
> > enable those tests, so I think is not worth it.
> >
> > This only has one consumer, audio/py-mutagen and only on the py2 variant
> > (which is weird, because this is a py3 only port, so I guess it uses the
> > cli directly).
>
> It does use the module, I think I just missed that when I changed eyeD3
> to use py3. I'll fix that in mutagen.
>
> > Tests on the consumer are the same before and after the update:
> >
> >   3 failed, 3801 passed
> >
> > comments ? ok ?
>
> Running the eyeD3 script fails:
>
> pkg_resources.DistributionNotFound: The 'deprecation' distribution was not found and is required by eyeD3
>
> Also py-magic is no longer required.

What a wonderful job I did, didn't I ?

Sorry for that, find the modified diff at the end.  The port now depends
on 2 new ports I've sent separately.  I've now tested it reading/writing
some tags to a couple of mp3 files without any problems.

Cheers,
Paco.

Index: Makefile
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- Makefile 29 Feb 2020 15:54:33 -0000 1.21
+++ Makefile 21 May 2020 14:03:37 -0000
@@ -2,7 +2,7 @@
 
 COMMENT= module and program for processing ID3 tags
 
-MODPY_EGG_VERSION= 0.8.12
+MODPY_EGG_VERSION= 0.9.5
 DISTNAME= eyeD3-${MODPY_EGG_VERSION}
 CATEGORIES= audio
 
@@ -16,7 +16,8 @@ MASTER_SITES= ${HOMEPAGE}releases/
 MODULES= lang/python
 # standalone software - intentionally no py-* prefix/FLAVOR.
 MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
-RUN_DEPENDS= devel/py-magic${MODPY_FLAVOR} \
+RUN_DEPENDS= devel/py-deprecation${MODPY_FLAVOR} \
+ devel/py-filetype${MODPY_FLAVOR} \
  devel/py-six${MODPY_FLAVOR}
 
 MODPY_SETUPTOOLS= Yes
Index: distinfo
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo 28 Dec 2019 15:13:25 -0000 1.8
+++ distinfo 20 May 2020 18:03:38 -0000
@@ -1,2 +1,2 @@
-SHA256 (eyeD3-0.8.12.tar.gz) = 5U7sCgP7jn6ei1CVRsbZLvvIcep1l2Ef4sFvA+HJS20=
-SIZE (eyeD3-0.8.12.tar.gz) = 214073
+SHA256 (eyeD3-0.9.5.tar.gz) = +vWAYZfyCT6CwoMNQfI3jwezqdoHoW+vsU/G+966xQo=
+SIZE (eyeD3-0.9.5.tar.gz) = 222994
Index: pkg/PLIST
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/pkg/PLIST,v
retrieving revision 1.5
diff -u -p -r1.5 PLIST
--- pkg/PLIST 28 Dec 2019 15:13:26 -0000 1.5

--
Paco Esteban.
0x5818130B8A6DBC03

Reply | Threaded
Open this post in threaded view
|

Re: update: audio/py-eyed3

Paco Esteban-2
Ping ?

New dependencies are already imported.
Diff at the end for convenience.

On Thu, 21 May 2020, Paco Esteban wrote:

> On Thu, 21 May 2020, Stuart Henderson wrote:
>
> > On 2020/05/20 20:37, Paco Esteban wrote:
> > > Hi ports@,
> > >
> > > This is an update for audio/py-eyed3 from  0.8.12 to latest 0.9.5
> > > You can see the can see the changes here:
> > >
> > > https://github.com/nicfit/eyeD3/blob/master/HISTORY.rst
> > >
> > > The update is pretty simple.
> > >
> > > I tried to enable tests by creating a port for the missing port
> > > `factory_boy`, but this pulls a pretty big tree of dependencies just to
> > > enable those tests, so I think is not worth it.
> > >
> > > This only has one consumer, audio/py-mutagen and only on the py2 variant
> > > (which is weird, because this is a py3 only port, so I guess it uses the
> > > cli directly).
> >
> > It does use the module, I think I just missed that when I changed eyeD3
> > to use py3. I'll fix that in mutagen.
> >
> > > Tests on the consumer are the same before and after the update:
> > >
> > >   3 failed, 3801 passed
> > >
> > > comments ? ok ?
> >
> > Running the eyeD3 script fails:
> >
> > pkg_resources.DistributionNotFound: The 'deprecation' distribution was not found and is required by eyeD3
> >
> > Also py-magic is no longer required.
>
> What a wonderful job I did, didn't I ?
>
> Sorry for that, find the modified diff at the end.  The port now depends
> on 2 new ports I've sent separately.  I've now tested it reading/writing
> some tags to a couple of mp3 files without any problems.
>
> Cheers,
> Paco.

Index: Makefile
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- Makefile 29 Feb 2020 15:54:33 -0000 1.21
+++ Makefile 21 May 2020 14:03:37 -0000
@@ -2,7 +2,7 @@
 
 COMMENT= module and program for processing ID3 tags
 
-MODPY_EGG_VERSION= 0.8.12
+MODPY_EGG_VERSION= 0.9.5
 DISTNAME= eyeD3-${MODPY_EGG_VERSION}
 CATEGORIES= audio
 
@@ -16,7 +16,8 @@ MASTER_SITES= ${HOMEPAGE}releases/
 MODULES= lang/python
 # standalone software - intentionally no py-* prefix/FLAVOR.
 MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
-RUN_DEPENDS= devel/py-magic${MODPY_FLAVOR} \
+RUN_DEPENDS= devel/py-deprecation${MODPY_FLAVOR} \
+ devel/py-filetype${MODPY_FLAVOR} \
  devel/py-six${MODPY_FLAVOR}
 
 MODPY_SETUPTOOLS= Yes
Index: distinfo
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/distinfo,v
retrieving revision 1.8
diff -u -p -r1.8 distinfo
--- distinfo 28 Dec 2019 15:13:25 -0000 1.8
+++ distinfo 20 May 2020 18:03:38 -0000
@@ -1,2 +1,2 @@
-SHA256 (eyeD3-0.8.12.tar.gz) = 5U7sCgP7jn6ei1CVRsbZLvvIcep1l2Ef4sFvA+HJS20=
-SIZE (eyeD3-0.8.12.tar.gz) = 214073
+SHA256 (eyeD3-0.9.5.tar.gz) = +vWAYZfyCT6CwoMNQfI3jwezqdoHoW+vsU/G+966xQo=
+SIZE (eyeD3-0.9.5.tar.gz) = 222994
Index: pkg/PLIST
===================================================================
RCS file: /home/cvs/ports/audio/py-eyed3/pkg/PLIST,v
retrieving revision 1.5
diff -u -p -r1.5 PLIST
--- pkg/PLIST 28 Dec 2019 15:13:26 -0000 1.5
+++ pkg/PLIST 20 May 2020 18:05:38 -0000
@@ -14,10 +14,9 @@ lib/python${MODPY_VERSION}/site-packages
 ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}/
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}__about__.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
-lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}compat.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}core.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}main.${MODPY_PYC_MAGIC_TAG}pyc
-lib/python${MODPY_VERSION}/site-packages/eyed3/compat.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}mimetype.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/core.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/__init__.py
@@ -32,6 +31,7 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/headers.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/id3/tag.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/main.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/mimetype.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/
 lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/__init__.py
 ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/${MODPY_PYCACHE}/
@@ -46,28 +46,36 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}art.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}classic.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}display.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}extract.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}fixup.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}genres.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}itunes.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}jsontag.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}lameinfo.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}lastfm.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}mimetype.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}nfo.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}pymod.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}stats.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}xep_118.${MODPY_PYC_MAGIC_TAG}pyc
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}yamltag.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/_display_parser.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/art.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/classic.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/display.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/extract.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/fixup.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/genres.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/itunes.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/jsontag.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/lameinfo.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/lastfm.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/mimetype.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/nfo.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/pymod.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/stats.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/xep_118.py
+lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/yamltag.py
 lib/python${MODPY_VERSION}/site-packages/eyed3/utils/
 lib/python${MODPY_VERSION}/site-packages/eyed3/utils/__init__.py
 ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/utils/${MODPY_PYCACHE}/

Reply | Threaded
Open this post in threaded view
|

Re: update: audio/py-eyed3

Kurt Mosiejczuk-9
On Thu, May 28, 2020 at 11:47:43AM +0200, Paco Esteban wrote:
> Ping ?

> New dependencies are already imported.
> Diff at the end for convenience.

Builds fine on amd64 and sparc64 for me. Seems to function correctly on
amd64 for me.

ok kmos

--Kurt

> On Thu, 21 May 2020, Paco Esteban wrote:

> > On Thu, 21 May 2020, Stuart Henderson wrote:
> >
> > > On 2020/05/20 20:37, Paco Esteban wrote:
> > > > Hi ports@,
> > > >
> > > > This is an update for audio/py-eyed3 from  0.8.12 to latest 0.9.5
> > > > You can see the can see the changes here:
> > > >
> > > > https://github.com/nicfit/eyeD3/blob/master/HISTORY.rst
> > > >
> > > > The update is pretty simple.
> > > >
> > > > I tried to enable tests by creating a port for the missing port
> > > > `factory_boy`, but this pulls a pretty big tree of dependencies just to
> > > > enable those tests, so I think is not worth it.
> > > >
> > > > This only has one consumer, audio/py-mutagen and only on the py2 variant
> > > > (which is weird, because this is a py3 only port, so I guess it uses the
> > > > cli directly).
> > >
> > > It does use the module, I think I just missed that when I changed eyeD3
> > > to use py3. I'll fix that in mutagen.
> > >
> > > > Tests on the consumer are the same before and after the update:
> > > >
> > > >   3 failed, 3801 passed
> > > >
> > > > comments ? ok ?
> > >
> > > Running the eyeD3 script fails:
> > >
> > > pkg_resources.DistributionNotFound: The 'deprecation' distribution was not found and is required by eyeD3
> > >
> > > Also py-magic is no longer required.
> >
> > What a wonderful job I did, didn't I ?
> >
> > Sorry for that, find the modified diff at the end.  The port now depends
> > on 2 new ports I've sent separately.  I've now tested it reading/writing
> > some tags to a couple of mp3 files without any problems.
> >
> > Cheers,
> > Paco.
>
> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/audio/py-eyed3/Makefile,v
> retrieving revision 1.21
> diff -u -p -r1.21 Makefile
> --- Makefile 29 Feb 2020 15:54:33 -0000 1.21
> +++ Makefile 21 May 2020 14:03:37 -0000
> @@ -2,7 +2,7 @@
>  
>  COMMENT= module and program for processing ID3 tags
>  
> -MODPY_EGG_VERSION= 0.8.12
> +MODPY_EGG_VERSION= 0.9.5
>  DISTNAME= eyeD3-${MODPY_EGG_VERSION}
>  CATEGORIES= audio
>  
> @@ -16,7 +16,8 @@ MASTER_SITES= ${HOMEPAGE}releases/
>  MODULES= lang/python
>  # standalone software - intentionally no py-* prefix/FLAVOR.
>  MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
> -RUN_DEPENDS= devel/py-magic${MODPY_FLAVOR} \
> +RUN_DEPENDS= devel/py-deprecation${MODPY_FLAVOR} \
> + devel/py-filetype${MODPY_FLAVOR} \
>   devel/py-six${MODPY_FLAVOR}
>  
>  MODPY_SETUPTOOLS= Yes
> Index: distinfo
> ===================================================================
> RCS file: /home/cvs/ports/audio/py-eyed3/distinfo,v
> retrieving revision 1.8
> diff -u -p -r1.8 distinfo
> --- distinfo 28 Dec 2019 15:13:25 -0000 1.8
> +++ distinfo 20 May 2020 18:03:38 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (eyeD3-0.8.12.tar.gz) = 5U7sCgP7jn6ei1CVRsbZLvvIcep1l2Ef4sFvA+HJS20=
> -SIZE (eyeD3-0.8.12.tar.gz) = 214073
> +SHA256 (eyeD3-0.9.5.tar.gz) = +vWAYZfyCT6CwoMNQfI3jwezqdoHoW+vsU/G+966xQo=
> +SIZE (eyeD3-0.9.5.tar.gz) = 222994
> Index: pkg/PLIST
> ===================================================================
> RCS file: /home/cvs/ports/audio/py-eyed3/pkg/PLIST,v
> retrieving revision 1.5
> diff -u -p -r1.5 PLIST
> --- pkg/PLIST 28 Dec 2019 15:13:26 -0000 1.5
> +++ pkg/PLIST 20 May 2020 18:05:38 -0000
> @@ -14,10 +14,9 @@ lib/python${MODPY_VERSION}/site-packages
>  ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}/
>  lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}__about__.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
> -lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}compat.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}core.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}main.${MODPY_PYC_MAGIC_TAG}pyc
> -lib/python${MODPY_VERSION}/site-packages/eyed3/compat.py
> +lib/python${MODPY_VERSION}/site-packages/eyed3/${MODPY_PYCACHE}mimetype.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/core.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/id3/
>  lib/python${MODPY_VERSION}/site-packages/eyed3/id3/__init__.py
> @@ -32,6 +31,7 @@ lib/python${MODPY_VERSION}/site-packages
>  lib/python${MODPY_VERSION}/site-packages/eyed3/id3/headers.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/id3/tag.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/main.py
> +lib/python${MODPY_VERSION}/site-packages/eyed3/mimetype.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/
>  lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/__init__.py
>  ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/mp3/${MODPY_PYCACHE}/
> @@ -46,28 +46,36 @@ lib/python${MODPY_VERSION}/site-packages
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}art.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}classic.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}display.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}extract.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}fixup.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}genres.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}itunes.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}jsontag.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}lameinfo.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}lastfm.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}mimetype.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}nfo.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}pymod.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}stats.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}xep_118.${MODPY_PYC_MAGIC_TAG}pyc
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/${MODPY_PYCACHE}yamltag.${MODPY_PYC_MAGIC_TAG}pyc
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/_display_parser.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/art.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/classic.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/display.py
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/extract.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/fixup.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/genres.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/itunes.py
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/jsontag.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/lameinfo.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/lastfm.py
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/mimetype.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/nfo.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/pymod.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/stats.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/xep_118.py
> +lib/python${MODPY_VERSION}/site-packages/eyed3/plugins/yamltag.py
>  lib/python${MODPY_VERSION}/site-packages/eyed3/utils/
>  lib/python${MODPY_VERSION}/site-packages/eyed3/utils/__init__.py
>  ${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/eyed3/utils/${MODPY_PYCACHE}/
>