two small fixes for xcompmgr

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

two small fixes for xcompmgr

David Coppa
Hi,

This fixes two small glitches in app/xcompmgr:

uninitialized bool variable
wrong casting

cheers,
david


Index: xcompmgr.c
===================================================================
RCS file: /cvs/xenocara/app/xcompmgr/xcompmgr.c,v
retrieving revision 1.4
diff -N -u -p xcompmgr.c
--- xcompmgr.c 8 Nov 2009 10:27:36 -0000 1.4
+++ xcompmgr.c 2 Dec 2009 07:55:05 -0000
@@ -389,7 +389,7 @@ static conv *
 make_gaussian_map (Display *dpy, double r)
 {
     conv    *c;
-    int    size = ((int) ceil ((r * 3)) + 1) & ~1;
+    int    size = (int)(ceil ((r * 3)) + 1) & ~1;
     int    center = size / 2;
     int    x, y;
     double    t;
@@ -774,7 +774,9 @@ root_tile (Display *dpy)
     XRenderPictureAttributes pa;
     int    p;
 
+    fill = False;
     pixmap = None;
+
     for (p = 0; backgroundProps[p]; p++)
     {
  if (XGetWindowProperty (dpy, root, XInternAtom (dpy, backgroundProps[p], False),

Reply | Threaded
Open this post in threaded view
|

Re: two small fixes for xcompmgr

Owain Ainsworth-2
On Wed, Dec 02, 2009 at 09:34:40AM +0100, David Coppa wrote:

> Hi,
>
> This fixes two small glitches in app/xcompmgr:
>
> uninitialized bool variable
> wrong casting
>
> cheers,
> david
>
>
> Index: xcompmgr.c
> ===================================================================
> RCS file: /cvs/xenocara/app/xcompmgr/xcompmgr.c,v
> retrieving revision 1.4
> diff -N -u -p xcompmgr.c
> --- xcompmgr.c 8 Nov 2009 10:27:36 -0000 1.4
> +++ xcompmgr.c 2 Dec 2009 07:55:05 -0000
> @@ -389,7 +389,7 @@ static conv *
>  make_gaussian_map (Display *dpy, double r)
>  {
>      conv    *c;
> -    int    size = ((int) ceil ((r * 3)) + 1) & ~1;
> +    int    size = (int)(ceil ((r * 3)) + 1) & ~1;
>      int    center = size / 2;
>      int    x, y;
>      double    t;
> @@ -774,7 +774,9 @@ root_tile (Display *dpy)
>      XRenderPictureAttributes pa;
>      int    p;
>  
> +    fill = False;
>      pixmap = None;
> +
>      for (p = 0; backgroundProps[p]; p++)
>      {
>   if (XGetWindowProperty (dpy, root, XInternAtom (dpy, backgroundProps[p], False),
>

You probably want to send these upstream though
([hidden email])

since xcompmgr is not one of the programs that we maintain ourselves.

I think they'll probably insist of git format-patch style patches
though.

Cheers,

-0-
--
Be braver -- you can't cross a chasm in two small jumps.