textproc/zathura: missing RUN_DEPENDS

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

textproc/zathura: missing RUN_DEPENDS

Juan Francisco Cantero Hurtado
When I install a zathura plugin because I only want a viewer for that
format, pkg_add will not install also the main package. Without the
core package, the plugin is useless.

While here, change the COMMENT.

The patch is very simple. OK?

Index: core/Makefile
===================================================================
RCS file: /cvs/ports/textproc/zathura/core/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- core/Makefile 20 Sep 2015 07:33:44 -0000 1.3
+++ core/Makefile 4 Feb 2016 01:53:39 -0000
@@ -1,7 +1,8 @@
 # $OpenBSD: Makefile,v 1.3 2015/09/20 07:33:44 landry Exp $
 
 V = 0.3.3
-COMMENT = PDF viewer with vi-like keybindings
+REVISION = 0
+COMMENT = multi-format document viewer with vi-like keybindings
 DISTNAME = zathura-${V}
 CATEGORIES = textproc x11
 
Index: plugins/Makefile.inc
===================================================================
RCS file: /cvs/ports/textproc/zathura/plugins/Makefile.inc,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile.inc
--- plugins/Makefile.inc 25 Aug 2015 14:23:25 -0000 1.4
+++ plugins/Makefile.inc 4 Feb 2016 01:53:39 -0000
@@ -8,7 +8,8 @@ PERMIT_PACKAGE_CDROM ?= Yes
 PERMIT_PACKAGE_FTP ?= Yes
 PERMIT_DISTFILES_FTP ?= Yes
 
-RUN_DEPENDS ?= devel/desktop-file-utils
+RUN_DEPENDS ?= devel/desktop-file-utils \
+ textproc/zathura/core
 LIB_DEPENDS += x11/girara
 BUILD_DEPENDS ?= textproc/zathura/core
 
Index: plugins/cb/Makefile
===================================================================
RCS file: /cvs/ports/textproc/zathura/plugins/cb/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- plugins/cb/Makefile 25 Aug 2015 14:23:25 -0000 1.3
+++ plugins/cb/Makefile 4 Feb 2016 01:53:39 -0000
@@ -3,7 +3,7 @@
 V = 0.1.2
 COMMENT = comic book plugin for zathura
 DISTNAME = zathura-cb-${V}
-REVISION = 1
+REVISION = 2
 
 HOMEPAGE = http://pwmt.org/projects/zathura/plugins/zathura-cb/
 
Index: plugins/djvu/Makefile
===================================================================
RCS file: /cvs/ports/textproc/zathura/plugins/djvu/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- plugins/djvu/Makefile 25 Aug 2015 14:23:25 -0000 1.3
+++ plugins/djvu/Makefile 4 Feb 2016 01:53:39 -0000
@@ -3,7 +3,7 @@
 V = 0.2.3
 COMMENT = djvu plugin for zathura
 DISTNAME = zathura-djvu-${V}
-REVISION = 1
+REVISION = 2
 
 HOMEPAGE = http://pwmt.org/projects/zathura/plugins/zathura-djvu
 
Index: plugins/mupdf/Makefile
===================================================================
RCS file: /cvs/ports/textproc/zathura/plugins/mupdf/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- plugins/mupdf/Makefile 25 Aug 2015 14:23:25 -0000 1.6
+++ plugins/mupdf/Makefile 4 Feb 2016 01:53:39 -0000
@@ -1,7 +1,7 @@
 # $OpenBSD: Makefile,v 1.6 2015/08/25 14:23:25 sthen Exp $
 
 V = 0.2.7
-REVISION = 2
+REVISION = 3
 COMMENT = mupdf pdf plugin for zathura
 DISTNAME = zathura-pdf-mupdf-${V}
 
Index: plugins/poppler/Makefile
===================================================================
RCS file: /cvs/ports/textproc/zathura/plugins/poppler/Makefile,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile
--- plugins/poppler/Makefile 25 Aug 2015 14:23:25 -0000 1.4
+++ plugins/poppler/Makefile 4 Feb 2016 01:53:39 -0000
@@ -3,7 +3,7 @@
 V = 0.2.5
 COMMENT = poppler pdf plugin for zathura
 DISTNAME = zathura-pdf-poppler-${V}
-REVISION = 1
+REVISION = 2
 
 HOMEPAGE = http://pwmt.org/projects/zathura/plugins/zathura-pdf-poppler/
 
Index: plugins/ps/Makefile
===================================================================
RCS file: /cvs/ports/textproc/zathura/plugins/ps/Makefile,v
retrieving revision 1.4
diff -u -p -r1.4 Makefile
--- plugins/ps/Makefile 25 Aug 2015 14:23:25 -0000 1.4
+++ plugins/ps/Makefile 4 Feb 2016 01:53:39 -0000
@@ -3,7 +3,7 @@
 V = 0.2.2
 COMMENT = spectre postscript plugin for zathura
 DISTNAME = zathura-ps-${V}
-REVISION = 2
+REVISION = 3
 
 HOMEPAGE = http://pwmt.org/projects/zathura/plugins/zathura-ps/
 

Reply | Threaded
Open this post in threaded view
|

Re: textproc/zathura: missing RUN_DEPENDS

Landry Breuil-6
On Thu, Feb 04, 2016 at 03:05:24AM +0100, Juan Francisco Cantero Hurtado wrote:
> When I install a zathura plugin because I only want a viewer for that
> format, pkg_add will not install also the main package. Without the
> core package, the plugin is useless.
>
> While here, change the COMMENT.
>
> The patch is very simple. OK?

I *think* there was a reason for this...dunno if this was circular
dependencies at build time or something like this.
Maybe look into the ports@ archives for justifications ?

Landry

Reply | Threaded
Open this post in threaded view
|

Re: textproc/zathura: missing RUN_DEPENDS

Juan Francisco Cantero Hurtado
On Thu, Feb 04, 2016 at 08:49:37AM +0100, Landry Breuil wrote:

> On Thu, Feb 04, 2016 at 03:05:24AM +0100, Juan Francisco Cantero Hurtado wrote:
> > When I install a zathura plugin because I only want a viewer for that
> > format, pkg_add will not install also the main package. Without the
> > core package, the plugin is useless.
> >
> > While here, change the COMMENT.
> >
> > The patch is very simple. OK?
>
> I *think* there was a reason for this...dunno if this was circular
> dependencies at build time or something like this.
> Maybe look into the ports@ archives for justifications ?

Sorry, I didn't read your reply before of to commit the change.

The plugins depend of core at build time. I only changed the
RUN_DEPENDS.

--
Juan Francisco Cantero Hurtado http://juanfra.info