system/5389: authpf: symset and infile still needed?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

system/5389: authpf: symset and infile still needed?

Stefan Krah
>Number:         5389
>Category:       system
>Synopsis:       authpf: symset and infile still needed?
>Confidential:   yes
>Severity:       non-critical
>Priority:       low
>Responsible:    bugs
>State:          open
>Quarter:        
>Keywords:      
>Date-Required:
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 22 19:40:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Stefan Krah
>Release:        OpenBSD 4.0
>Organization:
net
>Environment:
        <machine, os, target, libraries (multiple lines)>
        System      : OpenBSD 4.0
        Architecture: OpenBSD.i386
        Machine     : i386
>Description:

I wonder if symset and infile are still needed since revision 1.77.


In case they aren't, this would be the cleanup:


>How-To-Repeat:
>Fix:

Index: authpf.c
===================================================================
RCS file: /cvs/src/usr.sbin/authpf/authpf.c,v
retrieving revision 1.99
diff -u -r1.99 authpf.c
--- authpf.c    9 Aug 2006 16:21:39 -0000       1.99
+++ authpf.c    22 Feb 2007 18:56:54 -0000
@@ -50,7 +50,6 @@

 #include "pathnames.h"

-extern int     symset(const char *, const char *, int);

 static int     read_config(FILE *);
 static void    print_message(char *);
@@ -67,7 +66,6 @@
 char   tablename[PF_TABLE_NAME_SIZE] = "authpf_users";

 FILE   *pidfp;
-char   *infile;                /* file name printed by yyerror() in parse.y */
 char    luser[MAXLOGNAME];     /* username */
 char    ipsrc[256];            /* ip as a string */
 char    pidfile[MAXPATHLEN];   /* we save pid in this file. */
@@ -727,7 +725,6 @@
        ipstr = NULL;
        free(fn);
        fn = NULL;
-       infile = NULL;
        return (-1);
 }


>Release-Note:
>Audit-Trail:
>Unformatted: