system/5383: ci drops x-bit

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

system/5383: ci drops x-bit

Martin Schröder
>Number:         5383
>Category:       system
>Synopsis:       ci drops x-bit
>Confidential:   yes
>Severity:       non-critical
>Priority:       low
>Responsible:    bugs
>State:          open
>Quarter:        
>Keywords:      
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb 20 15:00:01 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Martin Schrvder
>Release:        4.0 stable
>Organization:
net
>Environment:
       
        System      : OpenBSD 4.0
        Architecture: OpenBSD.i386
        Machine     : i386
>Description:
ci of a file with x-bit set drops the x-bit of the file.
>How-To-Repeat:
> touch foo
> chmod +x foo
> l foo
-rwxr-xr-x  1 ms  wheel  0 Feb 20 14:38 foo*
> ci -l foo
foo,v  <--  foo
enter description, terminated with single '.' or end of file:
NOTE: This is NOT the log message!
>Fix:
The same as for system/5379?

>Release-Note:
>Audit-Trail:
>Unformatted:
 >> .
 initial revision: 1.1
 done
 > l foo*
 -rw-r--r--  1 ms  wheel    0 Feb 20 14:38 foo
 -r-xr-xr-x  1 ms  wheel  183 Feb 20 14:38 foo,v*

Reply | Threaded
Open this post in threaded view
|

Re: system/5383: ci drops x-bit

Niall O'Higgins
The following reply was made to PR system/5383; it has been noted by GNATS.

From: "Niall O'Higgins" <[hidden email]>
To: [hidden email]
Cc: [hidden email]
Subject: Re: system/5383: ci drops x-bit
Date: Tue, 20 Feb 2007 19:21:41 +0000

 Can you try this patch against -current sources?
 
 Index: co.c
 ===================================================================
 RCS file: /usr/cvs//src/usr.bin/rcs/co.c,v
 retrieving revision 1.102
 diff -u -p -r1.102 co.c
 --- co.c 18 Feb 2007 20:54:18 -0000 1.102
 +++ co.c 20 Feb 2007 19:17:34 -0000
 @@ -355,6 +355,8 @@ checkout_rev(RCSFILE *file, RCSNUM *frev
  if (fstat(file->rf_fd, &st) == -1)
  err(1, "%s", file->rf_path);
  file->rf_mode = mode = st.st_mode;
 + } else {
 + mode = file->rf_mode;
  }
 
  if (flags & CO_LOCK) {

Reply | Threaded
Open this post in threaded view
|

Re: system/5383: ci drops x-bit

Martin Schröder
In reply to this post by Martin Schröder
The following reply was made to PR system/5383; it has been noted by GNATS.

From: "=?ISO-8859-1?Q?Martin_Schr=F6der?=" <[hidden email]>
To: "Niall O'Higgins" <[hidden email]>
Cc: [hidden email]
Subject: Re: system/5383: ci drops x-bit
Date: Wed, 21 Feb 2007 18:20:59 +0100

 2007/2/20, Niall O'Higgins <[hidden email]>:
 > Can you try this patch against -current sources?
 
 Works. :-)
 
 Thanks
    Martin