syspatch fails on 6.4/amd64

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

syspatch fails on 6.4/amd64

Matthieu Herrb-3
Hi,

The latest syspatch failed for me on one machine running syspatch:

$ doas syspatch
Get/Verify syspatch64-016_vmmints... 100% |*************|   170 KB
00:00
Installing patch 016_vmmints
Get/Verify syspatch64-017_rip6cks... 100% |*************|   193 KB
00:00
Installing patch 017_rip6cksum
Relinking to create unique kernel... failed!

And /usr/share/relink/kernel/GENERIC.MP/relink.log contains:

(SHA256) /bsd: OK
LD="ld" sh makegap.sh 0xcccccccc
ld -T ld.script -X --warn-common -nopie -o newbsd ${SYSTEM_HEAD} vers.o ${OBJS}
vmm.o: In function `vmm_fpurestore':
/usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
/usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
/usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
*** Error 1 in /usr/share/relink/kernel/GENERIC.MP (Makefile:988 'newbsd': @echo ld -T ld.script -X --warn-common -nopie -o newbsd '${SYSTEM...)

That left /bsd with the march 21, kernel:
-rwx------  1 root  wheel  15459450 Mar 21 23:56 /bsd


OpenBSD 6.4 (GENERIC.MP) #8: Thu Mar 21 14:26:24 CET 2019
    [hidden email]:/usr/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 4273856512 (4075MB)
avail mem = 4135051264 (3943MB)
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.7 @ 0x7fbf0420 (7 entries)
bios0: vendor coreboot version "ADI_RCCVE-01.00.00.12-nodebug" date 02/07/2017
bios0: ADI Engineering RCC-VE
acpi0 at bios0: rev 2
acpi0: sleep states S0 S4 S5
acpi0: tables DSDT FACP SPCR HPET APIC MCFG SSDT
acpi0: wakeup devices EHC1(S4)
acpitimer0 at acpi0: 3579545 Hz, 24 bits
acpihpet0 at acpi0: 14318179 Hz
acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: Intel(R) Atom(TM) CPU C2358 @ 1.74GHz, 1166.88 MHz, 06-4d-08
cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,SSE4.2,MOVBE,POPCNT,DEADLINE,AES,RDRAND,NXE,RDTSCP,LONG,LAHF,3DNOWP,PERF,ITSC,SMEP,ERMS,SENSOR,ARAT,MELTDOWN
cpu0: 1MB 64b/line 16-way L2 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
cpu0: apic clock running at 83MHz
cpu0: mwait min=64, max=64, C-substates=0.2.0.0.0.0.3, IBE
cpu1 at mainbus0: apid 2 (application processor)
cpu1: Intel(R) Atom(TM) CPU C2358 @ 1.74GHz, 1166.67 MHz, 06-4d-08
cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,SSE4.2,MOVBE,POPCNT,DEADLINE,AES,RDRAND,NXE,RDTSCP,LONG,LAHF,3DNOWP,PERF,ITSC,SMEP,ERMS,SENSOR,ARAT,MELTDOWN
cpu1: 1MB 64b/line 16-way L2 cache
cpu1: smt 0, core 1, package 0
ioapic0 at mainbus0: apid 2 pa 0xfec00000, version 20, 24 pins
acpimcfg0 at acpi0
acpimcfg0: addr 0xe0000000, bus 0-255
acpiprt0 at acpi0: bus 1 (RP01)
acpiprt1 at acpi0: bus 2 (RP02)
acpiprt2 at acpi0: bus 3 (RP03)
acpiprt3 at acpi0: bus 4 (RP04)
acpiprt4 at acpi0: bus 0 (PCI0)
acpicpu0 at acpi0: C1(@1 halt!), PSS
acpicpu1 at acpi0: C1(@1 halt!), PSS
acpicmos0 at acpi0
cpu0: Enhanced SpeedStep 1166 MHz: speeds: 2100, 1800, 1600, 1400 MHz
pci0 at mainbus0 bus 0
pchb0 at pci0 dev 0 function 0 vendor "Intel", unknown product 0x1f0e rev 0x02
ppb0 at pci0 dev 1 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
pci1 at ppb0 bus 1
ppb1 at pci0 dev 2 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
pci2 at ppb1 bus 2
ppb2 at pci0 dev 3 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
pci3 at ppb2 bus 3
ppb3 at pci0 dev 4 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
pci4 at ppb3 bus 4
vendor "Intel", unknown product 0x1f18 (class processor subclass Co-processor, rev 0x02) at pci0 dev 11 function 0 not configured
pchb1 at pci0 dev 14 function 0 "Intel Atom C2000 RAS" rev 0x02
"Intel Atom C2000 RCEC" rev 0x02 at pci0 dev 15 function 0 not configured
"Intel Atom C2000 SMBus" rev 0x02 at pci0 dev 19 function 0 not configured
em0 at pci0 dev 20 function 0 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:51
em1 at pci0 dev 20 function 1 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:52
em2 at pci0 dev 20 function 2 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:53
em3 at pci0 dev 20 function 3 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:54
ehci0 at pci0 dev 22 function 0 "Intel Atom C2000 USB" rev 0x02: apic 2 int 22
usb0 at ehci0: USB revision 2.0
uhub0 at usb0 configuration 1 interface 0 "Intel EHCI root hub" rev 2.00/1.00 addr 1
ahci0 at pci0 dev 23 function 0 "Intel Atom C2000 AHCI" rev 0x02: msi, AHCI 1.3
ahci0: port 0: 3.0Gb/s
scsibus1 at ahci0: 32 targets
sd0 at scsibus1 targ 0 lun 0: <ATA, INTEL SSDMCEAC03, LLLi> SCSI3 0/direct fixed naa.55cd2e404be954de
sd0: 28626MB, 512 bytes/sector, 58626288 sectors, thin
ahci1 at pci0 dev 24 function 0 "Intel Atom C2000 AHCI" rev 0x02: msi, AHCI 1.3
scsibus2 at ahci1: 32 targets
pcib0 at pci0 dev 31 function 0 "Intel Atom C2000 PCU" rev 0x02
ichiic0 at pci0 dev 31 function 3 "Intel Atom C2000 PCU SMBus" rev 0x02: apic 2 int 22
iic0 at ichiic0
iic0: addr 0x2e 00=3d words 00=3d3d 01=0000 02=0000 03=0000 04=0000 05=0000 06=0000 07=0000
spdmem0 at iic0 addr 0x50: 4GB DDR3 SDRAM PC3-12800 with thermal sensor
isa0 at pcib0
isadma0 at isa0
com0 at isa0 port 0x3f8/8 irq 4: ns16550a, 16 byte fifo
com1 at isa0 port 0x2f8/8 irq 3: ns16550a, 16 byte fifo
com1: console
pcppi0 at isa0 port 0x61
spkr0 at pcppi0
vmm0 at mainbus0: VMX/EPT (using slow L1TF mitigation)
uhub1 at uhub0 port 1 configuration 1 interface 0 "Intel product 0x07db" rev 2.00/0.02 addr 2
uhidev0 at uhub1 port 2 configuration 1 interface 0 "Ten X Technology, Inc. PCsensor Temper" rev 1.10/1.50 addr 3
uhidev0: iclass 3/1
uthum0 at uhidev0
uhidev1 at uhub1 port 2 configuration 1 interface 1 "Ten X Technology, Inc. PCsensor Temper" rev 1.10/1.50 addr 3
uhidev1: iclass 3/0
uthum1 at uhidev1
umass0 at uhub1 port 4 configuration 1 interface 0 "Generic Ultra Fast Media" rev 2.00/1.98 addr 4
umass0: using SCSI over Bulk-Only
scsibus3 at umass0: 2 targets, initiator 0
sd1 at scsibus3 targ 1 lun 0: <Generic, Ultra HS-COMBO, 1.98> SCSI0 0/direct removable serial.04242240000000225001
sd1: 3776MB, 512 bytes/sector, 7733248 sectors
vscsi0 at root
scsibus4 at vscsi0: 256 targets
softraid0 at root
scsibus5 at softraid0: 256 targets
root on sd0a (d3f1a22c1d4f10ad.a) swap on sd0b dump on sd0b

--
Matthieu Herrb

Reply | Threaded
Open this post in threaded view
|

Re: syspatch fails on 6.4/amd64

Mike Larkin-2
On Wed, May 22, 2019 at 08:46:06AM +0200, Matthieu Herrb wrote:

> Hi,
>
> The latest syspatch failed for me on one machine running syspatch:
>
> $ doas syspatch
> Get/Verify syspatch64-016_vmmints... 100% |*************|   170 KB
> 00:00
> Installing patch 016_vmmints
> Get/Verify syspatch64-017_rip6cks... 100% |*************|   193 KB
> 00:00
> Installing patch 017_rip6cksum
> Relinking to create unique kernel... failed!
>
> And /usr/share/relink/kernel/GENERIC.MP/relink.log contains:
>
> (SHA256) /bsd: OK
> LD="ld" sh makegap.sh 0xcccccccc
> ld -T ld.script -X --warn-common -nopie -o newbsd ${SYSTEM_HEAD} vers.o ${OBJS}
> vmm.o: In function `vmm_fpurestore':
> /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
> /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
> /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
> *** Error 1 in /usr/share/relink/kernel/GENERIC.MP (Makefile:988 'newbsd': @echo ld -T ld.script -X --warn-common -nopie -o newbsd '${SYSTEM...)
>

Odd. That function is present in 6.4, not sure why it isn't being found.

Can you objdump your KARL locore.o and see if xsetbv_user is there?

-ml

> That left /bsd with the march 21, kernel:
> -rwx------  1 root  wheel  15459450 Mar 21 23:56 /bsd
>
>
> OpenBSD 6.4 (GENERIC.MP) #8: Thu Mar 21 14:26:24 CET 2019
>     [hidden email]:/usr/src/sys/arch/amd64/compile/GENERIC.MP
> real mem = 4273856512 (4075MB)
> avail mem = 4135051264 (3943MB)
> mpath0 at root
> scsibus0 at mpath0: 256 targets
> mainbus0 at root
> bios0 at mainbus0: SMBIOS rev. 2.7 @ 0x7fbf0420 (7 entries)
> bios0: vendor coreboot version "ADI_RCCVE-01.00.00.12-nodebug" date 02/07/2017
> bios0: ADI Engineering RCC-VE
> acpi0 at bios0: rev 2
> acpi0: sleep states S0 S4 S5
> acpi0: tables DSDT FACP SPCR HPET APIC MCFG SSDT
> acpi0: wakeup devices EHC1(S4)
> acpitimer0 at acpi0: 3579545 Hz, 24 bits
> acpihpet0 at acpi0: 14318179 Hz
> acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat
> cpu0 at mainbus0: apid 0 (boot processor)
> cpu0: Intel(R) Atom(TM) CPU C2358 @ 1.74GHz, 1166.88 MHz, 06-4d-08
> cpu0: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,SSE4.2,MOVBE,POPCNT,DEADLINE,AES,RDRAND,NXE,RDTSCP,LONG,LAHF,3DNOWP,PERF,ITSC,SMEP,ERMS,SENSOR,ARAT,MELTDOWN
> cpu0: 1MB 64b/line 16-way L2 cache
> cpu0: smt 0, core 0, package 0
> mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
> cpu0: apic clock running at 83MHz
> cpu0: mwait min=64, max=64, C-substates=0.2.0.0.0.0.3, IBE
> cpu1 at mainbus0: apid 2 (application processor)
> cpu1: Intel(R) Atom(TM) CPU C2358 @ 1.74GHz, 1166.67 MHz, 06-4d-08
> cpu1: FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,PCLMUL,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,SSE4.2,MOVBE,POPCNT,DEADLINE,AES,RDRAND,NXE,RDTSCP,LONG,LAHF,3DNOWP,PERF,ITSC,SMEP,ERMS,SENSOR,ARAT,MELTDOWN
> cpu1: 1MB 64b/line 16-way L2 cache
> cpu1: smt 0, core 1, package 0
> ioapic0 at mainbus0: apid 2 pa 0xfec00000, version 20, 24 pins
> acpimcfg0 at acpi0
> acpimcfg0: addr 0xe0000000, bus 0-255
> acpiprt0 at acpi0: bus 1 (RP01)
> acpiprt1 at acpi0: bus 2 (RP02)
> acpiprt2 at acpi0: bus 3 (RP03)
> acpiprt3 at acpi0: bus 4 (RP04)
> acpiprt4 at acpi0: bus 0 (PCI0)
> acpicpu0 at acpi0: C1(@1 halt!), PSS
> acpicpu1 at acpi0: C1(@1 halt!), PSS
> acpicmos0 at acpi0
> cpu0: Enhanced SpeedStep 1166 MHz: speeds: 2100, 1800, 1600, 1400 MHz
> pci0 at mainbus0 bus 0
> pchb0 at pci0 dev 0 function 0 vendor "Intel", unknown product 0x1f0e rev 0x02
> ppb0 at pci0 dev 1 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
> pci1 at ppb0 bus 1
> ppb1 at pci0 dev 2 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
> pci2 at ppb1 bus 2
> ppb2 at pci0 dev 3 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
> pci3 at ppb2 bus 3
> ppb3 at pci0 dev 4 function 0 "Intel Atom C2000 PCIE" rev 0x02: msi
> pci4 at ppb3 bus 4
> vendor "Intel", unknown product 0x1f18 (class processor subclass Co-processor, rev 0x02) at pci0 dev 11 function 0 not configured
> pchb1 at pci0 dev 14 function 0 "Intel Atom C2000 RAS" rev 0x02
> "Intel Atom C2000 RCEC" rev 0x02 at pci0 dev 15 function 0 not configured
> "Intel Atom C2000 SMBus" rev 0x02 at pci0 dev 19 function 0 not configured
> em0 at pci0 dev 20 function 0 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:51
> em1 at pci0 dev 20 function 1 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:52
> em2 at pci0 dev 20 function 2 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:53
> em3 at pci0 dev 20 function 3 "Intel I354 SGMII" rev 0x03: msi, address 00:08:a2:09:99:54
> ehci0 at pci0 dev 22 function 0 "Intel Atom C2000 USB" rev 0x02: apic 2 int 22
> usb0 at ehci0: USB revision 2.0
> uhub0 at usb0 configuration 1 interface 0 "Intel EHCI root hub" rev 2.00/1.00 addr 1
> ahci0 at pci0 dev 23 function 0 "Intel Atom C2000 AHCI" rev 0x02: msi, AHCI 1.3
> ahci0: port 0: 3.0Gb/s
> scsibus1 at ahci0: 32 targets
> sd0 at scsibus1 targ 0 lun 0: <ATA, INTEL SSDMCEAC03, LLLi> SCSI3 0/direct fixed naa.55cd2e404be954de
> sd0: 28626MB, 512 bytes/sector, 58626288 sectors, thin
> ahci1 at pci0 dev 24 function 0 "Intel Atom C2000 AHCI" rev 0x02: msi, AHCI 1.3
> scsibus2 at ahci1: 32 targets
> pcib0 at pci0 dev 31 function 0 "Intel Atom C2000 PCU" rev 0x02
> ichiic0 at pci0 dev 31 function 3 "Intel Atom C2000 PCU SMBus" rev 0x02: apic 2 int 22
> iic0 at ichiic0
> iic0: addr 0x2e 00=3d words 00=3d3d 01=0000 02=0000 03=0000 04=0000 05=0000 06=0000 07=0000
> spdmem0 at iic0 addr 0x50: 4GB DDR3 SDRAM PC3-12800 with thermal sensor
> isa0 at pcib0
> isadma0 at isa0
> com0 at isa0 port 0x3f8/8 irq 4: ns16550a, 16 byte fifo
> com1 at isa0 port 0x2f8/8 irq 3: ns16550a, 16 byte fifo
> com1: console
> pcppi0 at isa0 port 0x61
> spkr0 at pcppi0
> vmm0 at mainbus0: VMX/EPT (using slow L1TF mitigation)
> uhub1 at uhub0 port 1 configuration 1 interface 0 "Intel product 0x07db" rev 2.00/0.02 addr 2
> uhidev0 at uhub1 port 2 configuration 1 interface 0 "Ten X Technology, Inc. PCsensor Temper" rev 1.10/1.50 addr 3
> uhidev0: iclass 3/1
> uthum0 at uhidev0
> uhidev1 at uhub1 port 2 configuration 1 interface 1 "Ten X Technology, Inc. PCsensor Temper" rev 1.10/1.50 addr 3
> uhidev1: iclass 3/0
> uthum1 at uhidev1
> umass0 at uhub1 port 4 configuration 1 interface 0 "Generic Ultra Fast Media" rev 2.00/1.98 addr 4
> umass0: using SCSI over Bulk-Only
> scsibus3 at umass0: 2 targets, initiator 0
> sd1 at scsibus3 targ 1 lun 0: <Generic, Ultra HS-COMBO, 1.98> SCSI0 0/direct removable serial.04242240000000225001
> sd1: 3776MB, 512 bytes/sector, 7733248 sectors
> vscsi0 at root
> scsibus4 at vscsi0: 256 targets
> softraid0 at root
> scsibus5 at softraid0: 256 targets
> root on sd0a (d3f1a22c1d4f10ad.a) swap on sd0b dump on sd0b
>
> --
> Matthieu Herrb
>

Reply | Threaded
Open this post in threaded view
|

Re: syspatch fails on 6.4/amd64

Matthieu Herrb-3
On Wed, May 22, 2019 at 12:31:48AM -0700, Mike Larkin wrote:

> On Wed, May 22, 2019 at 08:46:06AM +0200, Matthieu Herrb wrote:
> > Hi,
> >
> > The latest syspatch failed for me on one machine running syspatch:
> >
> > $ doas syspatch
> > Get/Verify syspatch64-016_vmmints... 100% |*************|   170 KB
> > 00:00
> > Installing patch 016_vmmints
> > Get/Verify syspatch64-017_rip6cks... 100% |*************|   193 KB
> > 00:00
> > Installing patch 017_rip6cksum
> > Relinking to create unique kernel... failed!
> >
> > And /usr/share/relink/kernel/GENERIC.MP/relink.log contains:
> >
> > (SHA256) /bsd: OK
> > LD="ld" sh makegap.sh 0xcccccccc
> > ld -T ld.script -X --warn-common -nopie -o newbsd ${SYSTEM_HEAD} vers.o ${OBJS}
> > vmm.o: In function `vmm_fpurestore':
> > /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
> > /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
> > /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
> > *** Error 1 in /usr/share/relink/kernel/GENERIC.MP (Makefile:988 'newbsd': @echo ld -T ld.script -X --warn-common -nopie -o newbsd '${SYSTEM...)
> >
>
> Odd. That function is present in 6.4, not sure why it isn't being found.
>
> Can you objdump your KARL locore.o and see if xsetbv_user is there?

Hi,

xsetbv_user isn't in locore.o on this machine.

I've checked another 6.4 machine and it's definatly here. Apparently I
managed to get a pre-6.4 snapshot on the affected machine as the
locore.o file there is dated from oct 6, 2018, while on the other
(good one) it's from oct 11.

Sorry for the noise.
--
Matthieu Herrb

Reply | Threaded
Open this post in threaded view
|

Re: syspatch fails on 6.4/amd64

Theo de Raadt-2
In reply to this post by Matthieu Herrb-3
That is weird.

Why did syspatch believe this is a system it can operate on?

+aja +robert

>On Wed, May 22, 2019 at 12:31:48AM -0700, Mike Larkin wrote:
>> On Wed, May 22, 2019 at 08:46:06AM +0200, Matthieu Herrb wrote:
>> > Hi,
>> >
>> > The latest syspatch failed for me on one machine running syspatch:
>> >
>> > $ doas syspatch
>> > Get/Verify syspatch64-016_vmmints... 100% |*************|   170 KB
>> > 00:00
>> > Installing patch 016_vmmints
>> > Get/Verify syspatch64-017_rip6cks... 100% |*************|   193 KB
>> > 00:00
>> > Installing patch 017_rip6cksum
>> > Relinking to create unique kernel... failed!
>> >
>> > And /usr/share/relink/kernel/GENERIC.MP/relink.log contains:
>> >
>> > (SHA256) /bsd: OK
>> > LD="ld" sh makegap.sh 0xcccccccc
>> > ld -T ld.script -X --warn-common -nopie -o newbsd ${SYSTEM_HEAD} vers.o ${OBJS}
>> > vmm.o: In function `vmm_fpurestore':
>> > /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
>> > /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
>> > /usr/src/sys/arch/amd64/amd64/vmm.c:3887: undefined reference to `xsetbv_user'
>> > *** Error 1 in /usr/share/relink/kernel/GENERIC.MP (Makefile:988 'newbsd': @echo ld -T ld.script -X --warn-common -nopie -o newbsd '${SYSTEM...)
>> >
>>
>> Odd. That function is present in 6.4, not sure why it isn't being found.
>>
>> Can you objdump your KARL locore.o and see if xsetbv_user is there?
>
>Hi,
>
>xsetbv_user isn't in locore.o on this machine.
>
>I've checked another 6.4 machine and it's definatly here. Apparently I
>managed to get a pre-6.4 snapshot on the affected machine as the
>locore.o file there is dated from oct 6, 2018, while on the other
>(good one) it's from oct 11.
>
>Sorry for the noise.
>--
>Matthieu Herrb
>
>

Reply | Threaded
Open this post in threaded view
|

Re: syspatch fails on 6.4/amd64

Theo Buehler-3
On Sun, May 26, 2019 at 05:05:19AM -0600, Theo de Raadt wrote:
> That is weird.
>
> Why did syspatch believe this is a system it can operate on?

The crank from 6.4-beta to 6.4 happened on Sept 29th, and the one from
6.4 to 6.4-current happened on Oct 13th. Any system built during these
two weeks would be recognized as -release by syspatch.

guenther's xsetbv commit happened on Oct 7th, a day later than the
locore.o that matthieu had.

Reply | Threaded
Open this post in threaded view
|

Re: syspatch fails on 6.4/amd64

Antoine Jacoutot-7
In reply to this post by Theo de Raadt-2
On Sun, May 26, 2019 at 05:05:19AM -0600, Theo de Raadt wrote:
> That is weird.
>
> Why did syspatch believe this is a system it can operate on?

Because it's that time of the year where there's no way to know on what we run
(release or current).
If you have a better idea than parsing the output of sysctl kern.version, I am
all ears.

--
Antoine

Reply | Threaded
Open this post in threaded view
|

Re: syspatch fails on 6.4/amd64

Stuart Henderson
On 2019/05/26 17:18, Antoine Jacoutot wrote:
> On Sun, May 26, 2019 at 05:05:19AM -0600, Theo de Raadt wrote:
> > That is weird.
> >
> > Why did syspatch believe this is a system it can operate on?
>
> Because it's that time of the year where there's no way to know on what we run
> (release or current).
> If you have a better idea than parsing the output of sysctl kern.version, I am
> all ears.

I proposed this before for another reason and it didn't get anywhere, but
maybe it's worth mentioning again. Include a build_id file in base*.tgz
containing a uuid created during mkr. When a version release is made, add
the uuids for actual releases to a file on ftp, anything that needs to
know if it's on a release build can check against that file.

There are things people might do that make it "not release" (local
builds of base or kernel), if we care about that we could just have them
invalidate the build_id.