On Mon, Feb 10, 2020 at 05:28:43PM -0600, Scott Cheloha wrote:
> The parameter name "ms" is misleading. All the calling code uses
> microseconds. I think the author's thought process in choosing that
> name was roughly: "microseconds" -> "Micro Seconds" -> "ms".
> In any case, I've renamed the parameter to the less misleading
Looks good to me.
> This driver is only built on sparc64. I think this ought to compile.
> If someone could confirm that it compiles that would help.
> If someone has one of these things that would be even better, though I
> have my doubts.
Compiles fine, but I have no real hardware to test.
> #ifdef DEBUG
> - if (nticks > 60 * hz)
> - panic("stp4020: preposterous delay: %u", nticks);
> + if (usecs > 60 * 1000000)
Counting zeroes and lack of names or units on one site always make me
double check, how about the following? Seems verbose indeed but is
obvious to read, imho.