snmpd(8) reduce generic errors

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

snmpd(8) reduce generic errors

Martijn van Duren-5
Apparently not many people check the error count in their snmp stats.
This appears to been here since day 1.

OK?

martijn@

Index: snmpe.c
===================================================================
RCS file: /cvs/src/usr.sbin/snmpd/snmpe.c,v
retrieving revision 1.60
diff -u -p -r1.60 snmpe.c
--- snmpe.c 24 Oct 2019 12:39:27 -0000 1.60
+++ snmpe.c 14 Feb 2020 14:41:44 -0000
@@ -766,6 +766,8 @@ snmpe_response(struct snmp_message *msg)
  msg->sm_varbindresp = ober_unlink_elements(msg->sm_pduend);
 
  switch (msg->sm_error) {
+ case SNMP_ERROR_NONE:
+ break;
  case SNMP_ERROR_TOOBIG:
  stats->snmp_intoobigs++;
  break;

Reply | Threaded
Open this post in threaded view
|

Re: snmpd(8) reduce generic errors

Gerhard Roth-2
On 2/14/20 3:42 PM, Martijn van Duren wrote:

> Apparently not many people check the error count in their snmp stats.
> This appears to been here since day 1.
>
> OK?
>
> martijn@
>
> Index: snmpe.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/snmpd/snmpe.c,v
> retrieving revision 1.60
> diff -u -p -r1.60 snmpe.c
> --- snmpe.c 24 Oct 2019 12:39:27 -0000 1.60
> +++ snmpe.c 14 Feb 2020 14:41:44 -0000
> @@ -766,6 +766,8 @@ snmpe_response(struct snmp_message *msg)
>   msg->sm_varbindresp = ober_unlink_elements(msg->sm_pduend);
>  
>   switch (msg->sm_error) {
> + case SNMP_ERROR_NONE:
> + break;
>   case SNMP_ERROR_TOOBIG:
>   stats->snmp_intoobigs++;
>   break;
>

ok gerhard@