remove duplicate definitions of LAPIC_ID_MASK and LAPIC_ID_SHIFT

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

remove duplicate definitions of LAPIC_ID_MASK and LAPIC_ID_SHIFT

Kevin Lo
ok?

Index: sys/arch/amd64/include/i82489reg.h
===================================================================
RCS file: /cvs/src/sys/arch/amd64/include/i82489reg.h,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 i82489reg.h
--- sys/arch/amd64/include/i82489reg.h 21 Jul 2015 04:48:33 -0000 1.4
+++ sys/arch/amd64/include/i82489reg.h 26 Jul 2019 01:36:01 -0000
@@ -105,8 +105,6 @@
 
 
 #define LAPIC_ICRHI 0x310 /* Int. cmd. RW */
-# define LAPIC_ID_MASK 0x0f000000
-# define LAPIC_ID_SHIFT 24
 
 #define LAPIC_LVTT 0x320 /* Loc.vec.(timer) RW */
 # define LAPIC_LVTT_VEC_MASK 0x000000ff
Index: sys/arch/i386/include/i82489reg.h
===================================================================
RCS file: /cvs/src/sys/arch/i386/include/i82489reg.h,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 i82489reg.h
--- sys/arch/i386/include/i82489reg.h 21 Jul 2015 06:19:50 -0000 1.4
+++ sys/arch/i386/include/i82489reg.h 26 Jul 2019 01:36:01 -0000
@@ -105,8 +105,6 @@
 
 
 #define LAPIC_ICRHI 0x310 /* Int. cmd. RW */
-# define LAPIC_ID_MASK 0x0f000000
-# define LAPIC_ID_SHIFT 24
 
 #define LAPIC_LVTT 0x320 /* Loc.vec.(timer) RW */
 # define LAPIC_LVTT_VEC_MASK 0x000000ff

Reply | Threaded
Open this post in threaded view
|

Re: remove duplicate definitions of LAPIC_ID_MASK and LAPIC_ID_SHIFT

Philip Guenther-2
On Thu, Jul 25, 2019 at 4:44 PM Kevin Lo <[hidden email]> wrote:

> ok?
>

Yes, please.  guenther@