remove devel/svk?

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

remove devel/svk?

Stefan Sperling-8
SVK development stopped in 2009:
http://lists.bestpractical.com/pipermail/svk-devel/2009-May/001224.html

Cause the cool kids use git nowadays, you know.

Is anyone still using svk?
If not I'd like to remove the corresponding ports:

  devel/svk
  devel/p5-SVN-Dump
  devel/p5-SVN-Mirror

Any objections?

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Stuart Henderson
On 2012/09/03 02:00, Stefan Sperling wrote:

> SVK development stopped in 2009:
> http://lists.bestpractical.com/pipermail/svk-devel/2009-May/001224.html
>
> Cause the cool kids use git nowadays, you know.
>
> Is anyone still using svk?
> If not I'd like to remove the corresponding ports:
>
>   devel/svk
>   devel/p5-SVN-Dump
>   devel/p5-SVN-Mirror
>
> Any objections?
>

I've used p5-SVN-Mirror before standalone, and would prefer to keep
it unless there's an alternative in the tree..

Following diff is enough to get them to build; people running them
would also need to use LD_PRELOAD themselves, or we could add a
wrapper script like I did for frozen-bubble, until we have another
solution (be it linking /usr/bin/perl -lpthread, moving to threaded
perl, or whatever else; this isn't just affecting a few very-rarely
used things, I've been sitting on an update to rrdtool for a couple
of years mostly because of this).


Index: p5-SVN-Mirror/Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-SVN-Mirror/Makefile,v
retrieving revision 1.18
diff -u -p -r1.18 Makefile
--- p5-SVN-Mirror/Makefile 3 Dec 2010 11:44:35 -0000 1.18
+++ p5-SVN-Mirror/Makefile 3 Sep 2012 11:39:07 -0000
@@ -3,7 +3,7 @@
 COMMENT= subversion repository mirroring tool
 
 DISTNAME= SVN-Mirror-0.75
-REVISION= 0
+REVISION= 1
 CATEGORIES= devel
 
 MAINTAINER= Kevin Lo <[hidden email]>
@@ -15,7 +15,6 @@ PERMIT_DISTFILES_CDROM= Yes
 PERMIT_DISTFILES_FTP= Yes
 
 MODULES= cpan
-USE_GROFF = Yes
 RUN_DEPENDS= devel/p5-SVN-Simple>=0.27 \
  devel/p5-Class-Accessor>=0.19 \
  devel/p5-Data-UUID>=0.11 \
@@ -26,5 +25,7 @@ RUN_DEPENDS= devel/p5-SVN-Simple>=0.27 \
  textproc/p5-Sort-Versions>=1.5 \
  www/p5-URI>=1.30
 BUILD_DEPENDS= ${RUN_DEPENDS}
+
+CONFIGURE_ENV+= LD_PRELOAD=libpthread.so
 
 .include <bsd.port.mk>
Index: p5-SVN-Simple/Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-SVN-Simple/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- p5-SVN-Simple/Makefile 3 Dec 2010 11:44:35 -0000 1.10
+++ p5-SVN-Simple/Makefile 3 Sep 2012 11:39:07 -0000
@@ -4,9 +4,8 @@ COMMENT= simple interface to subversion'
 
 MODULES= cpan
 DISTNAME= SVN-Simple-0.27
-REVISION= 1
-CATEGORIES= devel
-USE_GROFF = Yes
+REVISION= 2
+CATEGORIES= devel
 
 CPAN_AUTHOR= CLKAO
 
@@ -16,6 +15,9 @@ PERMIT_PACKAGE_CDROM= Yes
 PERMIT_PACKAGE_FTP= Yes
 PERMIT_DISTFILES_CDROM= Yes
 PERMIT_DISTFILES_FTP= Yes
+
+CONFIGURE_ENV= LD_PRELOAD=libpthread.so
+MAKE_ENV= LD_PRELOAD=libpthread.so
 
 RUN_DEPENDS= devel/subversion,-perl>=1.1.1
 BUILD_DEPENDS= ${RUN_DEPENDS}
Index: p5-SVN-Web/Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-SVN-Web/Makefile,v
retrieving revision 1.9
diff -u -p -r1.9 Makefile
--- p5-SVN-Web/Makefile 3 Dec 2010 11:44:35 -0000 1.9
+++ p5-SVN-Web/Makefile 3 Sep 2012 11:39:07 -0000
@@ -4,9 +4,8 @@ COMMENT= subversion repository web front
 
 MODULES= cpan
 DISTNAME= SVN-Web-0.48
-REVISION= 1
+REVISION= 2
 CATEGORIES= devel perl5
-USE_GROFF = Yes
 
 # Artistic
 PERMIT_PACKAGE_CDROM= Yes
@@ -29,6 +28,9 @@ RUN_DEPENDS= devel/subversion,-perl \
 # tests broken on sparc64, server doesn't really work either
 # www/p5-HTTP-Server-Simple
 BUILD_DEPENDS= ${RUN_DEPENDS}
+
+CONFIGURE_ENV= LD_PRELOAD=libpthread.so
+MAKE_ENV=      LD_PRELOAD=libpthread.so
 
 CONFIGURE_STYLE=modbuild
 
Index: svk/Makefile
===================================================================
RCS file: /cvs/ports/devel/svk/Makefile,v
retrieving revision 1.17
diff -u -p -r1.17 Makefile
--- svk/Makefile 26 Nov 2010 07:19:01 -0000 1.17
+++ svk/Makefile 3 Sep 2012 11:48:04 -0000
@@ -3,6 +3,7 @@
 COMMENT= decentralized version control system
 
 V= 2.2.1
+REVISION= 0
 DISTNAME= SVK-v${V}
 PKGNAME= svk-${V}
 CATEGORIES= devel perl5
@@ -46,7 +47,8 @@ RUN_DEPENDS= devel/p5-Algorithm-Annotate
 BUILD_DEPENDS= ${RUN_DEPENDS}
 
 CONFIGURE_STYLE= perl
-USE_GROFF = Yes
+
+CONFIGURE_ENV= LD_PRELOAD=libpthread.so
 
 REGRESS_DEPENDS=devel/p5-BSD-Resource \
  devel/p5-Test-Pod

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Stefan Sperling-8
On Mon, Sep 03, 2012 at 12:53:01PM +0100, Stuart Henderson wrote:
> I've used p5-SVN-Mirror before standalone, and would prefer to keep
> it unless there's an alternative in the tree..

What about svnsync shipped with Subversion?

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Stuart Henderson
On 2012/09/03 13:59, Stefan Sperling wrote:
> On Mon, Sep 03, 2012 at 12:53:01PM +0100, Stuart Henderson wrote:
> > I've used p5-SVN-Mirror before standalone, and would prefer to keep
> > it unless there's an alternative in the tree..
>
> What about svnsync shipped with Subversion?
>

Ah yes, that's probably preferable nowadays, IIRC I needed to sync from
a server running Subversion 1.3 when I did this ;)

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Stefan Sperling-8
On Mon, Sep 03, 2012 at 01:09:46PM +0100, Stuart Henderson wrote:

> On 2012/09/03 13:59, Stefan Sperling wrote:
> > On Mon, Sep 03, 2012 at 12:53:01PM +0100, Stuart Henderson wrote:
> > > I've used p5-SVN-Mirror before standalone, and would prefer to keep
> > > it unless there's an alternative in the tree..
> >
> > What about svnsync shipped with Subversion?
> >
>
> Ah yes, that's probably preferable nowadays, IIRC I needed to sync from
> a server running Subversion 1.3 when I did this ;)

Ah, yes, svnsync requires at least a 1.4 server.

With 1.3 and older servers getting a mirror of revision history
requires administrative access to the server.

There are old Subversion servers out there in wild, all the way
back to 1.0. If p5-SVN-Mirror can replicate from those over network
then it fills that niche nicely and should stay.

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Christian Weisgerber
In reply to this post by Stefan Sperling-8
Stefan Sperling <[hidden email]> wrote:

> SVK development stopped in 2009:
> http://lists.bestpractical.com/pipermail/svk-devel/2009-May/001224.html
>
> Is anyone still using svk?

Is it broken?

--
Christian "naddy" Weisgerber                          [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Kevin Lo-3
In reply to this post by Stefan Sperling-8
Stefan Sperling wrote:
> SVK development stopped in 2009:
> http://lists.bestpractical.com/pipermail/svk-devel/2009-May/001224.html
>
> Cause the cool kids use git nowadays, you know.
>
> Is anyone still using svk?

Me. As far as I know, many open source developers use svk in Taiwan.
 
> If not I'd like to remove the corresponding ports:
>
>   devel/svk
>   devel/p5-SVN-Dump
>   devel/p5-SVN-Mirror
>
> Any objections?

Is there any particular reason to remove it?

        Kevin

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Kevin Lo-3
In reply to this post by Christian Weisgerber
Christian Weisgerber wrote:
> Stefan Sperling <[hidden email]> wrote:
>
> > SVK development stopped in 2009:
> > http://lists.bestpractical.com/pipermail/svk-devel/2009-May/001224.html
> >
> > Is anyone still using svk?
>
> Is it broken?

Apparently not. I use svk on OpenBSD every day.

        Kevin


Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Stuart Henderson
On 2012/09/07 09:02, Kevin Lo wrote:

> Christian Weisgerber wrote:
> > Stefan Sperling <[hidden email]> wrote:
> >
> > > SVK development stopped in 2009:
> > > http://lists.bestpractical.com/pipermail/svk-devel/2009-May/001224.html
> > >
> > > Is anyone still using svk?
> >
> > Is it broken?
>
> Apparently not. I use svk on OpenBSD every day.
>
> Kevin
>
>

Yes, it's broken in -current. Changes I just committed to p5-SVN-* will
let it build again but it'll fail to run without LD_PRELOAD=libpthread.so;
we could maybe add a wrapper like this..

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/svk/Makefile,v
retrieving revision 1.18
diff -u -p -r1.18 Makefile
--- Makefile 7 Sep 2012 08:09:59 -0000 1.18
+++ Makefile 7 Sep 2012 08:18:17 -0000
@@ -3,7 +3,7 @@
 COMMENT= decentralized version control system
 
 V= 2.2.1
-REVISION= 0
+REVISION= 1
 DISTNAME= SVK-v${V}
 PKGNAME= svk-${V}
 CATEGORIES= devel perl5
@@ -48,9 +48,20 @@ BUILD_DEPENDS= ${RUN_DEPENDS}
 
 CONFIGURE_STYLE= perl
 
-CONFIGURE_ENV= LD_PRELOAD=libpthread.so # XXX remove when perl is -lpthread
-
 REGRESS_DEPENDS=devel/p5-BSD-Resource \
  devel/p5-Test-Pod
+
+# XXX remove entire section below when perl is -lpthread
+
+CONFIGURE_ENV= LD_PRELOAD=libpthread.so
+
+post-configure:
+ ${SUBST_CMD} -c ${FILESDIR}/wrapper.sh ${WRKDIR}/wrapper.sh
+
+post-install:
+ mv ${PREFIX}/bin/svk ${PREFIX}/libexec/
+ ${INSTALL_SCRIPT} ${WRKDIR}/wrapper.sh ${PREFIX}/bin/svk
+
+###
 
 .include <bsd.port.mk>
Index: files/wrapper.sh
===================================================================
RCS file: files/wrapper.sh
diff -N files/wrapper.sh
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ files/wrapper.sh 7 Sep 2012 08:18:17 -0000
@@ -0,0 +1,2 @@
+#!/bin/sh
+LD_PRELOAD=libpthread.so exec ${PREFIX}/libexec/svk $*
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/devel/svk/pkg/PLIST,v
retrieving revision 1.4
diff -u -p -r1.4 PLIST
--- pkg/PLIST 14 Nov 2008 09:24:42 -0000 1.4
+++ pkg/PLIST 7 Sep 2012 08:18:17 -0000
@@ -159,6 +159,7 @@ ${P5SITE}/SVK/Util.pm
 ${P5SITE}/SVK/Version.pm
 ${P5SITE}/SVK/View.pm
 ${P5SITE}/SVK/XD.pm
+libexec/svk
 @man man/man1/svk.1
 @man man/man3p/SVK.3p
 @man man/man3p/SVK::Command.3p

Reply | Threaded
Open this post in threaded view
|

Re: remove devel/svk?

Stefan Sperling-8
In reply to this post by Kevin Lo-3
On Fri, Sep 07, 2012 at 08:58:37AM +0800, Kevin Lo wrote:
> Stefan Sperling wrote:
> > Is anyone still using svk?
>
> Me. As far as I know, many open source developers use svk in Taiwan.

Ah, I wasn't aware of that.

> > If not I'd like to remove the corresponding ports:
> >
> >   devel/svk
> >   devel/p5-SVN-Dump
> >   devel/p5-SVN-Mirror
> >
> > Any objections?
>
> Is there any particular reason to remove it?

Not at all. If you're using it, it will stay.

I just hadn't heard of any svk users in a long time, and was
under the impression that svk is unused nowadays.
It's good news to me that there is still an svk user base :)