proposed patch to mention WANTLIB in Makefile.template

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

proposed patch to mention WANTLIB in Makefile.template

Moritz Grimm
Hi,


the attached patch makes Makefile.template mention WANTLIB.

The place I used is below PERMIT_*, where most ports seem to put it.
I've also added a blank line between PERMIT_* and WANTLIB, something
that most ports don't do (mine included, I was following examples at the
time.) It doesn't make that much sense to me to have it tucked closely
to PERMIT_*, so I figured that new ports based on the template should
have it in a more prominent position.


Moritz

--- Makefile.template.orig Wed Nov  9 12:18:04 2005
+++ Makefile.template Wed Nov  9 12:23:10 2005
@@ -49,6 +49,11 @@
 #PERMIT_DISTFILES_CDROM=Yes | "Reason if No"
 #PERMIT_DISTFILES_FTP= Yes | "Reason if No"
 
+# Libraries not mentioned below in LIB_DEPENDS but linked against by this
+# port, e.g. those in the base system or dependencies-of-dependencies, must
+# be registered in WANTLIB.
+#WANTLIB= ???
+
 # where the source files and patches can be fetched
 #
 MASTER_SITES= ???
Reply | Threaded
Open this post in threaded view
|

Re: proposed patch to mention WANTLIB in Makefile.template

Moritz Grimm
Moritz Grimm wrote:
> +# Libraries not mentioned below in LIB_DEPENDS but linked against by this
> +# port, e.g. those in the base system or dependencies-of-dependencies, must
> +# be registered in WANTLIB.
> +#WANTLIB= ???

Actually, this may need further rewording and a small extension that
it's about packages, not the whole port ... e.g. sub-packages should
only WANTLIB what they really need. I don't have a good idea about how
to put it, yet, though. Alternatively, the explanation in bsd.port.mk(5)
could be improved. Many people I talk to about this stuff have issues
understanding it from the official docs, even though it's really not
THAT difficult.


Moritz

Reply | Threaded
Open this post in threaded view
|

Re: proposed patch to mention WANTLIB in Makefile.template

Nikolay Sturm-2
* Moritz Grimm [2005-11-09]:
> Actually, this may need further rewording and a small extension that
> it's about packages, not the whole port ... e.g. sub-packages should

WANTLIB is documented in bsd.port.mk(5), no need to duplicate that
information. Regardless of that, I added an entry for it to
Makefile.template.

thanks,

Nikolay