powerpc bulk build report

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

powerpc bulk build report

Landry Breuil-5
bulk build on macppc-1.ports.openbsd.org
started on  Sat Jun 29 13:06:01 MDT 2019
finished at Fri Jul 12 20:44:23 MDT 2019
lasted 14D00h38m
done with kern.version=OpenBSD 6.5-current (GENERIC.MP) #542: Thu Jun 27 11:20:25 MDT 2019

built packages:9483
Jun 29:316
Jul 2:3761
Jul 3:246
Jul 4:874
Jul 5:978
Jul 6:841
Jul 7:315
Jul 8:248
Jul 9:269
Jul 10:543
Jul 11:407
Jul 12:684


critical path missing pkgs: http://build-failures.rhaalovely.net//powerpc/2019-06-29/summary.log

build failures: 82
http://build-failures.rhaalovely.net//powerpc/2019-06-29/audio/gradio.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/audio/taglib.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/benchmarks/wrk.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/cad/gnucap.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/cad/magic.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/cad/netgen.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/cad/qucs.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/geany.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/include-what-you-use.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/kf5/plasma-framework.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/py-unicorn,python3.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/pycdc.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/reposurgeon.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/woboq_codebrowser.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/xtensa-elf/gcc.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/citra.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/desmume.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/fs-uae.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/gambatte,-main.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/nestopia,-libretro.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/ppsspp.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/retroarch.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/vbam.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/emulators/xnp2.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/dxx-rebirth.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/freeorion.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/godot.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/maelstrom.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/mvdsv.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/pentobi.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/pokerth.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/prboom-plus.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/valyriatear.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/games/xevil.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/geo/qlandkartegt.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/geo/spatialite/gis.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/DevIL.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/aspect-crop.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/dibuja.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/glslang.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/makehuman.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/openscenegraph.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/spirv-tools.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/vulkan-loader.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/inputmethods/scim-fcitx.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/inputmethods/scim-hangul.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/inputmethods/scim-pinyin.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/inputmethods/scim-tables.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/lang/gambit.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/lang/gprolog.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/lang/parrot.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/lang/php/7.3.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/lang/ruby/2.4,-gdbm.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/lang/sbcl.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/mail/kopano/core,-mapi.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/math/kst.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/math/mlpack,-main.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/multimedia/mkvtoolnix.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/multimedia/qtav.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/multimedia/synfig.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/net/fastnetmon.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/net/mutella.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/net/powerdns_recursor.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/net/toxcore.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/productivity/ledger.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/security/aircrack-ng.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/security/libfprint.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/sysutils/logstalgia.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/sysutils/random_run.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/telephony/iaxclient.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/telephony/pjsua,-main.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/gnome/bijiben.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/gnome/builder.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/gnome/gedit.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/gnome/zenity.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/gtk+4,-cloudprint.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/libdbus-c++.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/libhandy.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/mate/caja.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/ogre.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/qt5/qt3d.log
http://build-failures.rhaalovely.net//powerpc/2019-06-29/x11/waimea.log

Reply | Threaded
Open this post in threaded view
|

[ports-gcc] Unbreak multimedia/qtav (was: Re: powerpc bulk build report)

Charlene Wendling
On Sun, 14 Jul 2019 06:46:44 -0600 (MDT)
[hidden email] wrote:


> http://build-failures.rhaalovely.net//powerpc/2019-06-29/multimedia/qtav.log
> http://build-failures.rhaalovely.net/sparc64/2019-06-09/multimedia/qtav.log

Classic issue here, GCC doesn't like to see NULL as an equivalent for
false. It seems like an upstream "typo", because there are many
occurrences where booleans are used.

It builds fine on amd64 and macppc (there are no tests).

Comments/feedback are welcome!

Charlène.


Index: Makefile
===================================================================
RCS file: /cvs/ports/multimedia/qtav/Makefile,v
retrieving revision 1.3
diff -u -p -u -p -r1.3 Makefile
--- Makefile 12 Jul 2019 20:47:57 -0000 1.3
+++ Makefile 15 Jul 2019 20:27:40 -0000
@@ -5,6 +5,7 @@ COMMENT = FFmpeg-based Qt multimedia fra
 GH_ACCOUNT = wang-bin
 GH_PROJECT = QtAV
 GH_TAGNAME = v1.12.0
+REVISION = 0
 
 PKGNAME = ${DISTNAME:L}
 
Index: patches/patch-src_codec_video_SurfaceInteropCUDA_cpp
===================================================================
RCS file: patches/patch-src_codec_video_SurfaceInteropCUDA_cpp
diff -N patches/patch-src_codec_video_SurfaceInteropCUDA_cpp
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_codec_video_SurfaceInteropCUDA_cpp 15 Jul 2019 20:27:40 -0000
@@ -0,0 +1,26 @@
+$OpenBSD$
+
+ports-gcc fix for:
+converting to 'bool' from 'std::nullptr_t' requires direct-initialization
+
+Index: src/codec/video/SurfaceInteropCUDA.cpp
+--- src/codec/video/SurfaceInteropCUDA.cpp.orig
++++ src/codec/video/SurfaceInteropCUDA.cpp
+@@ -132,7 +132,7 @@ bool HostInteropResource::map(int picIndex, const CUVI
+         if (!ensureResource(pitch, H)) //copy height is coded height
+             return false;
+         // the same thread (context) as cuMemAllocHost, so no ccontext switch is needed
+-        CUDA_ENSURE(cuMemcpyDtoH(host_mem.data, devptr, pitch*H*3/2), NULL);
++        CUDA_ENSURE(cuMemcpyDtoH(host_mem.data, devptr, pitch*H*3/2), false);
+         host_mem.index = picIndex;
+     }
+     // map to texture
+@@ -173,7 +173,7 @@ bool HostInteropResource::ensureResource(int pitch, in
+     if (!share_ctx) // cuMemFreeHost will be called in dtor which is not the current thread.
+         CUDA_WARN(cuCtxPushCurrent(ctx));
+     // NV12
+-    CUDA_ENSURE(cuMemAllocHost((void**)&host_mem.data, pitch*height*3/2), NULL);
++    CUDA_ENSURE(cuMemAllocHost((void**)&host_mem.data, pitch*height*3/2), false);
+     if (!share_ctx)
+         CUDA_WARN(cuCtxPopCurrent(NULL)); //can be null or &ctx
+     return true;

Reply | Threaded
Open this post in threaded view
|

[ports-gcc] Unbreak graphics/vulkan-loader (was: Re: powerpc bulk build report)

Charlene Wendling
In reply to this post by Landry Breuil-5

> http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/vulkan-loader.log

The problem here is pretty simple as soon as base-gcc is implied:

- it has missing switches (that's the failure seen in the log)
- anonymous unions require -std=gnu99 (that's also in the log,
  "declarations that declare nothing" warnings)
- i fixed those in the CMakeLists, but then it fails with another
  classic: "error: thread-local storage not supported for this target"

I guess it's enough to allow me a COMPILER change. It has fixed the
build [0], i can't say anything about runtime since no macppc
video cards are compatible.

I made no REVISION bump, because it has never been built on base-gcc
archs and it implies no changes for base-clang ones.

Comments/feedback are welcome!

Charlène.

[0] https://bin.charlenew.xyz/vulkan-loader.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/vulkan-loader/Makefile,v
retrieving revision 1.3
diff -u -p -u -p -r1.3 Makefile
--- Makefile 22 Jun 2019 17:02:24 -0000 1.3
+++ Makefile 15 Jul 2019 21:25:27 -0000
@@ -26,6 +26,9 @@ RUN_DEPENDS = graphics/vulkan-headers
 
 CONFIGURE_ARGS = -DBUILD_WSI_WAYLAND_SUPPORT=False
 
+# Thread local storage
+COMPILER = base-clang ports-gcc
+
 MODULES = devel/cmake \
  lang/python
 MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}

Reply | Threaded
Open this post in threaded view
|

[ports-gcc] Unbreak devel/pycdc (was: Re: powerpc bulk build report)

Charlene Wendling
In reply to this post by Landry Breuil-5

> http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/pycdc.log

Using -Werror for releases seems ambitious to me, especially that GCC
is very adept at generating them.

I've removed the flag, and it builds [0] on macppc. Tests pass as well.
Same thing for amd64 where there is no warning at all to start with.

Comments/feedback are welcome!

Charlène.


[0] https://bin.charlenew.xyz/pycdc.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/pycdc/Makefile,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 Makefile
--- Makefile 12 Jul 2019 20:45:56 -0000 1.4
+++ Makefile 15 Jul 2019 22:14:54 -0000
@@ -3,7 +3,7 @@
 COMMENT = python bytecode disassembler and decompiler
 
 DISTNAME = pycdc-0.0.20180428
-REVISION = 1
+REVISION = 2
 
 GH_ACCOUNT = zrax
 GH_PROJECT = pycdc
Index: patches/patch-CMakeLists_txt
===================================================================
RCS file: patches/patch-CMakeLists_txt
diff -N patches/patch-CMakeLists_txt
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-CMakeLists_txt 15 Jul 2019 22:14:54 -0000
@@ -0,0 +1,17 @@
+$OpenBSD$
+
+Fix for ports-gcc, the code generates warnings that triggers a
+build failure
+
+Index: CMakeLists.txt
+--- CMakeLists.txt.orig
++++ CMakeLists.txt
+@@ -5,7 +5,7 @@ cmake_minimum_required(VERSION 2.8)
+ find_package(PythonInterp REQUIRED)
+
+ if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
+-    set(CMAKE_CXX_FLAGS "-Wall -Wextra -Werror ${CMAKE_CXX_FLAGS}")
++    set(CMAKE_CXX_FLAGS "-Wall -Wextra ${CMAKE_CXX_FLAGS}")
+ endif()
+
+ set(PYTHON_VERSIONS

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak graphics/vulkan-loader (was: Re: powerpc bulk build report)

Thomas Frohwein-2
In reply to this post by Charlene Wendling
Thanks, I appreciate that you found the fix for it! I'm traveling currently and can commit the change only on Sunday.

I'm not sure if this should really be built if there is truly no hardware that's compatible... The alternative would excluding PPC and maybe a few other arches that are known to not work with any compatible hardware.

On Mon, Jul 15, 2019, at 3:42 PM, Charlene Wendling wrote:

>
> > http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/vulkan-loader.log
>
> The problem here is pretty simple as soon as base-gcc is implied:
>
> - it has missing switches (that's the failure seen in the log)
> - anonymous unions require -std=gnu99 (that's also in the log,
>   "declarations that declare nothing" warnings)
> - i fixed those in the CMakeLists, but then it fails with another
>   classic: "error: thread-local storage not supported for this target"
>
> I guess it's enough to allow me a COMPILER change. It has fixed the
> build [0], i can't say anything about runtime since no macppc
> video cards are compatible.
>
> I made no REVISION bump, because it has never been built on base-gcc
> archs and it implies no changes for base-clang ones.
>
> Comments/feedback are welcome!
>
> Charlène.
>
> [0] https://bin.charlenew.xyz/vulkan-loader.log
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/graphics/vulkan-loader/Makefile,v
> retrieving revision 1.3
> diff -u -p -u -p -r1.3 Makefile
> --- Makefile 22 Jun 2019 17:02:24 -0000 1.3
> +++ Makefile 15 Jul 2019 21:25:27 -0000
> @@ -26,6 +26,9 @@ RUN_DEPENDS = graphics/vulkan-headers
>  
>  CONFIGURE_ARGS = -DBUILD_WSI_WAYLAND_SUPPORT=False
>  
> +# Thread local storage
> +COMPILER = base-clang ports-gcc
> +
>  MODULES = devel/cmake \
>   lang/python
>  MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
>

--
 
[hidden email]

PGP Public Key: https://pgp.mit.edu/pks/lookup?op=get&search=0xE1A22D58D20C6D22

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak graphics/vulkan-loader (was: Re: powerpc bulk build report)

Charlene Wendling
On Thu, 18 Jul 2019 23:13:14 -0600
Thomas Frohwein wrote:

> Thanks, I appreciate that you found the fix for it! I'm traveling
> currently and can commit the change only on Sunday.
>
> I'm not sure if this should really be built if there is truly no
> hardware that's compatible... The alternative would excluding PPC and
> maybe a few other arches that are known to not work with any
> compatible hardware.

Well, there are 2 problems in fact:

- the one i address here is for all base-gcc archs, not macppc only
- but in fact most of these archs have no vulkan capable video cards

As far as macppc is concerned, all G4 system are AGP-based so no amdgpu
for them, hence no vulkan.

Some G5 ones have PCI-Express and the best upgrade official upgrade you
could get is a Radeon X1900 that doesn't as well. I'm not sure more
modern third party cards are available.

CC'ing Jeremie and Kurt, as i don't know how sparc64 is doing in this
regard.

I guess it should be only for x86* and arm* in the end.

Charlène.

> On Mon, Jul 15, 2019, at 3:42 PM, Charlene Wendling wrote:
> >
> > > http://build-failures.rhaalovely.net//powerpc/2019-06-29/graphics/vulkan-loader.log
> >
> > The problem here is pretty simple as soon as base-gcc is implied:
> >
> > - it has missing switches (that's the failure seen in the log)
> > - anonymous unions require -std=gnu99 (that's also in the log,
> >   "declarations that declare nothing" warnings)
> > - i fixed those in the CMakeLists, but then it fails with another
> >   classic: "error: thread-local storage not supported for this
> > target"
> >
> > I guess it's enough to allow me a COMPILER change. It has fixed the
> > build [0], i can't say anything about runtime since no macppc
> > video cards are compatible.
> >
> > I made no REVISION bump, because it has never been built on base-gcc
> > archs and it implies no changes for base-clang ones.
> >
> > Comments/feedback are welcome!
> >
> > Charlène.
> >
> > [0] https://bin.charlenew.xyz/vulkan-loader.log
> >
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/graphics/vulkan-loader/Makefile,v
> > retrieving revision 1.3
> > diff -u -p -u -p -r1.3 Makefile
> > --- Makefile 22 Jun 2019 17:02:24 -0000 1.3
> > +++ Makefile 15 Jul 2019 21:25:27 -0000
> > @@ -26,6 +26,9 @@ RUN_DEPENDS = graphics/vulkan-headers
> >  
> >  CONFIGURE_ARGS = -DBUILD_WSI_WAYLAND_SUPPORT=False
> >  
> > +# Thread local storage
> > +COMPILER = base-clang ports-gcc
> > +
> >  MODULES = devel/cmake \
> >   lang/python
> >  MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
> >
>
> --
>  
> [hidden email]
>
> PGP Public Key:
> https://pgp.mit.edu/pks/lookup?op=get&search=0xE1A22D58D20C6D22

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak graphics/vulkan-loader (was: Re: powerpc bulk build report)

Kurt Mosiejczuk-9
On Fri, Jul 19, 2019 at 08:47:41PM +0200, Charlene Wendling wrote:

> Well, there are 2 problems in fact:

> - the one i address here is for all base-gcc archs, not macppc only
> - but in fact most of these archs have no vulkan capable video cards

> As far as macppc is concerned, all G4 system are AGP-based so no amdgpu
> for them, hence no vulkan.

> Some G5 ones have PCI-Express and the best upgrade official upgrade you
> could get is a Radeon X1900 that doesn't as well. I'm not sure more
> modern third party cards are available.

> CC'ing Jeremie and Kurt, as i don't know how sparc64 is doing in this
> regard.

AFAIK the only desktop sparc64 to have PCI Express is the Ultra 45/25
and it has two PCI-X and three PCI-e. So 1st gen. I mean, if I ever
manage to get the one I acquired running I'll see if I can get a
Vulkan-capable card working, but don't hold your breath. :)

> I guess it should be only for x86* and arm* in the end.

--Kurt

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak graphics/vulkan-loader

Jeremie Courreges-Anglas-5
In reply to this post by Charlene Wendling
On Fri, Jul 19 2019, Charlene Wendling <[hidden email]> wrote:
> On Thu, 18 Jul 2019 23:13:14 -0600
> Thomas Frohwein wrote:
>
>> Thanks, I appreciate that you found the fix for it! I'm traveling
>> currently and can commit the change only on Sunday.

Well, Charlene wrote the diff and can commit it. :)

>> I'm not sure if this should really be built if there is truly no
>> hardware that's compatible... The alternative would excluding PPC and
>> maybe a few other arches that are known to not work with any
>> compatible hardware.
>
> Well, there are 2 problems in fact:
>
> - the one i address here is for all base-gcc archs, not macppc only
> - but in fact most of these archs have no vulkan capable video cards
>
> As far as macppc is concerned, all G4 system are AGP-based so no amdgpu
> for them, hence no vulkan.
>
> Some G5 ones have PCI-Express and the best upgrade official upgrade you
> could get is a Radeon X1900 that doesn't as well. I'm not sure more
> modern third party cards are available.
>
> CC'ing Jeremie and Kurt, as i don't know how sparc64 is doing in this
> regard.
>
> I guess it should be only for x86* and arm* in the end.

Consumers should be taken into account.  I can imagine some ports using
vulkan-loader unconditionally at build time, try to use it at runtime
and fallback on another backend if vulkan-loader doesn't work.  If you
use NOT_FOR_ARCHS in vulkan-loader, said ports won't even get a chance
to build even though runtime might be ok.  Those are only guesses.

There are no such ports right now; vkquake supposedly has a hard
requirement on vulkan-loader.  But such ports might pop up in the
future, so I'd prefer vulkan-loader to be available on all arches.

ok jca@ for the COMPILER line, I'm not sure the "Thread Local Storage"
comment makes sense since you're not only addressing a TLS problem.

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak devel/pycdc (was: Re: powerpc bulk build report)

Charlene Wendling
In reply to this post by Charlene Wendling
Ping.

On Tue, 16 Jul 2019 00:30:23 +0200
Charlene Wendling wrote:

>
> > http://build-failures.rhaalovely.net//powerpc/2019-06-29/devel/pycdc.log
>
> Using -Werror for releases seems ambitious to me, especially that GCC
> is very adept at generating them.
>
> I've removed the flag, and it builds [0] on macppc. Tests pass as
> well. Same thing for amd64 where there is no warning at all to start
> with.
>
> Comments/feedback are welcome!
>
> Charlène.
>
>
> [0] https://bin.charlenew.xyz/pycdc.log
>

Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/pycdc/Makefile,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 Makefile
--- Makefile 12 Jul 2019 20:45:56 -0000 1.4
+++ Makefile 15 Jul 2019 22:14:54 -0000
@@ -3,7 +3,7 @@
 COMMENT = python bytecode disassembler and decompiler
 
 DISTNAME = pycdc-0.0.20180428
-REVISION = 1
+REVISION = 2
 
 GH_ACCOUNT = zrax
 GH_PROJECT = pycdc
Index: patches/patch-CMakeLists_txt
===================================================================
RCS file: patches/patch-CMakeLists_txt
diff -N patches/patch-CMakeLists_txt
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-CMakeLists_txt 15 Jul 2019 22:14:54 -0000
@@ -0,0 +1,17 @@
+$OpenBSD$
+
+Fix for ports-gcc, the code generates warnings that triggers a
+build failure
+
+Index: CMakeLists.txt
+--- CMakeLists.txt.orig
++++ CMakeLists.txt
+@@ -5,7 +5,7 @@ cmake_minimum_required(VERSION 2.8)
+ find_package(PythonInterp REQUIRED)
+
+ if(CMAKE_COMPILER_IS_GNUCXX OR "${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
+-    set(CMAKE_CXX_FLAGS "-Wall -Wextra -Werror ${CMAKE_CXX_FLAGS}")
++    set(CMAKE_CXX_FLAGS "-Wall -Wextra ${CMAKE_CXX_FLAGS}")
+ endif()
+
+ set(PYTHON_VERSIONS