[ports-gcc] Unbreak telephony/pjsua

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[ports-gcc] Unbreak telephony/pjsua

Charlene Wendling
Hi,

> http://build-failures.rhaalovely.net/sparc64/last/telephony/pjsua%2C-main.log
> http://build-failures.rhaalovely.net/powerpc/last/telephony/pjsua%2C-main.log

The build used to fail for another reason, but since the last update,
it does not. Now, we're hitting a classic. The implicit MODGCC4_CPPLIBDEP
in LIB_DEPENDS is not inherited by LIB_DEPENDS-*, despite COMPILER_LIBCXX
being in WANTLIB-*.

MODGCC4_CPPLIBDEP being a noop on clang archs, this has no impact there.

The below diff adds that, allowing pjsip to be packaged on powerpc [0].
Bumping REVISION is not needed, that version never built on gcc archs.

Comments/feedback are welcome,

Charlène.


[0] https://bin.charlenew.xyz/pjsua.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/telephony/pjsua/Makefile,v
retrieving revision 1.48
diff -u -p -u -p -r1.48 Makefile
--- Makefile 10 Jan 2020 13:37:46 -0000 1.48
+++ Makefile 13 Feb 2020 21:03:57 -0000
@@ -57,6 +57,9 @@ LIB_DEPENDS-main= \
  security/libsrtp \
  telephony/bcg729
 
+# needed for gcc archs, it's not inherited by subpackages
+LIB_DEPENDS-main += ${MODGCC4_CPPLIBDEP}
+
 LIB_DEPENDS-pjsua= telephony/pjsua,-main \
  audio/portaudio-svn
 


Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak telephony/pjsua

Stuart Henderson
On 2020/02/13 22:21, Charlene Wendling wrote:
> Hi,
>
> > http://build-failures.rhaalovely.net/sparc64/last/telephony/pjsua%2C-main.log
> > http://build-failures.rhaalovely.net/powerpc/last/telephony/pjsua%2C-main.log
>
> The build used to fail for another reason, but since the last update,
> it does not. Now, we're hitting a classic. The implicit MODGCC4_CPPLIBDEP
> in LIB_DEPENDS is not inherited by LIB_DEPENDS-*, despite COMPILER_LIBCXX
> being in WANTLIB-*.

Good, I was hoping that would fix the previous failure :)

> MODGCC4_CPPLIBDEP being a noop on clang archs, this has no impact there.
>
> The below diff adds that, allowing pjsip to be packaged on powerpc [0].
> Bumping REVISION is not needed, that version never built on gcc archs.
>
> Comments/feedback are welcome,

OK.

> Charlène.
>
>
> [0] https://bin.charlenew.xyz/pjsua.log
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/telephony/pjsua/Makefile,v
> retrieving revision 1.48
> diff -u -p -u -p -r1.48 Makefile
> --- Makefile 10 Jan 2020 13:37:46 -0000 1.48
> +++ Makefile 13 Feb 2020 21:03:57 -0000
> @@ -57,6 +57,9 @@ LIB_DEPENDS-main= \
>   security/libsrtp \
>   telephony/bcg729
>  
> +# needed for gcc archs, it's not inherited by subpackages
> +LIB_DEPENDS-main += ${MODGCC4_CPPLIBDEP}
> +
>  LIB_DEPENDS-pjsua= telephony/pjsua,-main \
>   audio/portaudio-svn
>  
>
>