[ports-gcc] Unbreak games/grhino

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[ports-gcc] Unbreak games/grhino

Charlene Wendling
Hi Remi, ports,

> http://build-failures.rhaalovely.net/powerpc/2019-02-04/games/grhino.log
> http://build-failures.rhaalovely.net/sparc64/2019-02-03/games/grhino.log

There are missing headers. And while here i've fixed some warnings
because execlp(3) wants null terminated arguments list anyway.

Once these headers are added, it builds [1] and runs [2] fine.
I've tested back on amd64 - it still builds [3], runtime is good
as well.

Any comment?

Charlène.


[1] http://0x0.st/z8oR.txt
[2] https://bsd.network/@julianaito/101762588495537117
[3] http://0x0.st/z8H8.txt


Index: Makefile
===================================================================
RCS file: /cvs/ports/games/grhino/Makefile,v
retrieving revision 1.21
diff -u -p -u -p -r1.21 Makefile
--- Makefile 24 Oct 2018 14:28:03 -0000 1.21
+++ Makefile 15 Mar 2019 21:17:57 -0000
@@ -3,7 +3,7 @@
 COMMENT = Othello/Reversi-like game
 DISTNAME = grhino-${V}
 V = 0.16.1
-REVISION= 7
+REVISION= 8
 CATEGORIES = games
 HOMEPAGE = http://rhino.sourceforge.net/
 FIX_EXTRACT_PERMISSIONS=Yes
Index: patches/patch-aiai_cc
===================================================================
RCS file: patches/patch-aiai_cc
diff -N patches/patch-aiai_cc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-aiai_cc 15 Mar 2019 21:17:57 -0000
@@ -0,0 +1,33 @@
+$OpenBSD$
+Hunk 1: ports-gcc fix for:
+    aiai.cc:111:18: error: 'srand' was not declared in this scope
+Hunk 2 & 3: suppress warnings
+Index: aiai.cc
+--- aiai.cc.orig
++++ aiai.cc
+@@ -29,6 +29,7 @@
+ #include <sys/wait.h>
+ #include <unistd.h>
+ #include <string.h>
++#include <stdlib.h>
+
+ #include <exception>
+ #include <stdexcept>
+@@ -209,7 +210,7 @@ void connect_clients()
+ close(fifo_white_to_client[1]);
+ close(fifo_white_to_server[0]);
+ close(fifo_white_to_server[1]);
+- if (execlp("/bin/sh", "sh", "-c", cmd_black, 0) == -1)
++ if (execlp("/bin/sh", "sh", "-c", cmd_black, NULL) == -1)
+ throw std::runtime_error(_("cannot run black GTP client"));
+ }
+
+@@ -229,7 +230,7 @@ void connect_clients()
+ close(fifo_white_to_client[1]);
+ close(fifo_white_to_server[0]);
+ close(fifo_white_to_server[1]);
+- if (execlp("/bin/sh", "sh", "-c", cmd_white, 0) == -1)
++ if (execlp("/bin/sh", "sh", "-c", cmd_white, NULL) == -1)
+ throw std::runtime_error(_("cannot run white GTP client"));
+ }
+
Index: patches/patch-gen_book_cc
===================================================================
RCS file: patches/patch-gen_book_cc
diff -N patches/patch-gen_book_cc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-gen_book_cc 15 Mar 2019 21:17:57 -0000
@@ -0,0 +1,15 @@
+$OpenBSD$
+ports-gcc fix for:
+gen_book.cc:519:29: error: 'strcmp' was not declared in this scope
+Index: gen_book.cc
+--- gen_book.cc.orig
++++ gen_book.cc
+@@ -25,6 +25,8 @@
+
+ #include <vector>
+
++#include <string.h>
++
+ #include "book.h"
+ #include "hash.h"
+ #include "log_proc.h"
Index: patches/patch-gen_pattern_cc
===================================================================
RCS file: patches/patch-gen_pattern_cc
diff -N patches/patch-gen_pattern_cc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-gen_pattern_cc 15 Mar 2019 21:17:57 -0000
@@ -0,0 +1,14 @@
+$OpenBSD$
+ports-gcc fix for:
+gen_pattern.cc:622:28: error: 'strcmp' was not declared in this scope
+Index: gen_pattern.cc
+--- gen_pattern.cc.orig
++++ gen_pattern.cc
+@@ -26,6 +26,7 @@
+ #include <math.h>
+ #include <unistd.h>
+ #include <fcntl.h>
++#include <string.h>
+ #include <sys/stat.h>
+ #include <sys/types.h>
+

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak games/grhino

Remi Pointel
On 3/16/19 11:28 PM, Charlene Wendling wrote:

> Hi Remi, ports,
>
>> http://build-failures.rhaalovely.net/powerpc/2019-02-04/games/grhino.log
>> http://build-failures.rhaalovely.net/sparc64/2019-02-03/games/grhino.log
>
> There are missing headers. And while here i've fixed some warnings
> because execlp(3) wants null terminated arguments list anyway.
>
> Once these headers are added, it builds [1] and runs [2] fine.
> I've tested back on amd64 - it still builds [3], runtime is good
> as well.
>
> Any comment?

Hi,

thanks for your work.

The patch seems good, you also can remove me as the maintainer because I
don't use this port anymore.

Cheers,

Remi.

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak games/grhino

Charlene Wendling
On Sun, 17 Mar 2019 08:06:42 +0100
Remi Pointel <[hidden email]> wrote:

> On 3/16/19 11:28 PM, Charlene Wendling wrote:
> > Hi Remi, ports,
> >
> >> http://build-failures.rhaalovely.net/powerpc/2019-02-04/games/grhino.log
> >> http://build-failures.rhaalovely.net/sparc64/2019-02-03/games/grhino.log
> >
> > There are missing headers. And while here i've fixed some warnings
> > because execlp(3) wants null terminated arguments list anyway.
> >
> > Once these headers are added, it builds [1] and runs [2] fine.
> > I've tested back on amd64 - it still builds [3], runtime is good
> > as well.
> >
> > Any comment?
>
> Hi,
>
> thanks for your work.
>
> The patch seems good, you also can remove me as the maintainer
> because I don't use this port anymore.

You're welcome! It's done. Any objection to commit it?

> Cheers,
>
> Remi.
>

Charlène.

Index: Makefile
===================================================================
RCS file: /cvs/ports/games/grhino/Makefile,v
retrieving revision 1.21
diff -u -p -u -p -r1.21 Makefile
--- Makefile 24 Oct 2018 14:28:03 -0000 1.21
+++ Makefile 17 Mar 2019 14:17:13 -0000
@@ -3,12 +3,10 @@
 COMMENT = Othello/Reversi-like game
 DISTNAME = grhino-${V}
 V = 0.16.1
-REVISION= 7
+REVISION= 8
 CATEGORIES = games
 HOMEPAGE = http://rhino.sourceforge.net/
 FIX_EXTRACT_PERMISSIONS=Yes
-
-MAINTAINER = Remi Pointel <[hidden email]>
 
 # GPLv2
 PERMIT_PACKAGE_CDROM = Yes
Index: patches/patch-aiai_cc
===================================================================
RCS file: patches/patch-aiai_cc
diff -N patches/patch-aiai_cc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-aiai_cc 17 Mar 2019 14:17:13 -0000
@@ -0,0 +1,33 @@
+$OpenBSD$
+Hunk 1: ports-gcc fix for:
+    aiai.cc:111:18: error: 'srand' was not declared in this scope
+Hunk 2 & 3: suppress warnings
+Index: aiai.cc
+--- aiai.cc.orig
++++ aiai.cc
+@@ -29,6 +29,7 @@
+ #include <sys/wait.h>
+ #include <unistd.h>
+ #include <string.h>
++#include <stdlib.h>
+
+ #include <exception>
+ #include <stdexcept>
+@@ -209,7 +210,7 @@ void connect_clients()
+ close(fifo_white_to_client[1]);
+ close(fifo_white_to_server[0]);
+ close(fifo_white_to_server[1]);
+- if (execlp("/bin/sh", "sh", "-c", cmd_black, 0) == -1)
++ if (execlp("/bin/sh", "sh", "-c", cmd_black, NULL) == -1)
+ throw std::runtime_error(_("cannot run black GTP client"));
+ }
+
+@@ -229,7 +230,7 @@ void connect_clients()
+ close(fifo_white_to_client[1]);
+ close(fifo_white_to_server[0]);
+ close(fifo_white_to_server[1]);
+- if (execlp("/bin/sh", "sh", "-c", cmd_white, 0) == -1)
++ if (execlp("/bin/sh", "sh", "-c", cmd_white, NULL) == -1)
+ throw std::runtime_error(_("cannot run white GTP client"));
+ }
+
Index: patches/patch-gen_book_cc
===================================================================
RCS file: patches/patch-gen_book_cc
diff -N patches/patch-gen_book_cc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-gen_book_cc 17 Mar 2019 14:17:13 -0000
@@ -0,0 +1,15 @@
+$OpenBSD$
+ports-gcc fix for:
+gen_book.cc:519:29: error: 'strcmp' was not declared in this scope
+Index: gen_book.cc
+--- gen_book.cc.orig
++++ gen_book.cc
+@@ -25,6 +25,8 @@
+
+ #include <vector>
+
++#include <string.h>
++
+ #include "book.h"
+ #include "hash.h"
+ #include "log_proc.h"
Index: patches/patch-gen_pattern_cc
===================================================================
RCS file: patches/patch-gen_pattern_cc
diff -N patches/patch-gen_pattern_cc
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-gen_pattern_cc 17 Mar 2019 14:17:13 -0000
@@ -0,0 +1,14 @@
+$OpenBSD$
+ports-gcc fix for:
+gen_pattern.cc:622:28: error: 'strcmp' was not declared in this scope
+Index: gen_pattern.cc
+--- gen_pattern.cc.orig
++++ gen_pattern.cc
+@@ -26,6 +26,7 @@
+ #include <math.h>
+ #include <unistd.h>
+ #include <fcntl.h>
++#include <string.h>
+ #include <sys/stat.h>
+ #include <sys/types.h>
+