[ports-gcc] Unbreak comms/hackrf on big endian archs

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[ports-gcc] Unbreak comms/hackrf on big endian archs

Charlene Wendling

> http://build-failures.rhaalovely.net/sparc64/last/comms/hackrf.log
> http://build-failures.rhaalovely.net/powerpc/last/comms/hackrf.log

Big endianness cannot be detected with base-gcc.

I've not much to say, using ports-gcc instead just works :)

Works fine on macppc/ports-gcc-{8,4.9}.

OK?

Charlène.

Index: Makefile
===================================================================
RCS file: /cvs/ports/comms/hackrf/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 Makefile
--- Makefile 20 Nov 2018 12:46:09 -0000 1.1.1.1
+++ Makefile 20 Apr 2019 22:13:01 -0000
@@ -3,6 +3,7 @@
 COMMENT = host software for the HackRF One SDR
 
 V = 2018.01.1
+REVISION = 0
 DISTNAME = hackrf-$V
 
 SHARED_LIBS +=  hackrf                    0.0 # 0.5
@@ -25,6 +26,8 @@ EXTRACT_SUFX = .tar.xz
 MODULES = devel/cmake
 LIB_DEPENDS = devel/libusb1 \
  math/fftw3,float
+
+COMPILER = base-clang ports-gcc
 
 CONFIGURE_ARGS = -DCMAKE_C_FLAGS="${CFLAGS} -I$
{LOCALBASE}/include"

Reply | Threaded
Open this post in threaded view
|

Re: [ports-gcc] Unbreak comms/hackrf on big endian archs

Jeremie Courreges-Anglas-2
On Sun, Apr 21 2019, Charlene Wendling <[hidden email]> wrote:
>> http://build-failures.rhaalovely.net/sparc64/last/comms/hackrf.log
>> http://build-failures.rhaalovely.net/powerpc/last/comms/hackrf.log
>
> Big endianness cannot be detected with base-gcc.

It's not about big endianness, it's about the cmake files forcing the
use of -std=gnu90, a version that base-gcc doesn't understand.
${CMAKE_C90_EXTENSION_COMPILE_OPTION} should be used instead.

> I've not much to say, using ports-gcc instead just works :)

Because it understands -std=gnu90, __atomic_* and __builtin_bswap32.

> Works fine on macppc/ports-gcc-{8,4.9}.
>
> OK?

ok jca@ (a bit late since this has been committed) but I'd prefer if
COMPILER was set before MODULES/DEPENDS, as in Makefile.template.

> Charlène.
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/comms/hackrf/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -u -p -r1.1.1.1 Makefile
> --- Makefile 20 Nov 2018 12:46:09 -0000 1.1.1.1
> +++ Makefile 20 Apr 2019 22:13:01 -0000
> @@ -3,6 +3,7 @@
>  COMMENT = host software for the HackRF One SDR
>  
>  V = 2018.01.1
> +REVISION = 0
>  DISTNAME = hackrf-$V
>  
>  SHARED_LIBS +=  hackrf                    0.0 # 0.5
> @@ -25,6 +26,8 @@ EXTRACT_SUFX = .tar.xz
>  MODULES = devel/cmake
>  LIB_DEPENDS = devel/libusb1 \
>   math/fftw3,float
> +
> +COMPILER = base-clang ports-gcc
>  
>  CONFIGURE_ARGS = -DCMAKE_C_FLAGS="${CFLAGS} -I$
> {LOCALBASE}/include"
>

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE