portcheck(1) and FLAVOR

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

portcheck(1) and FLAVOR

Jeremie Courreges-Anglas-2

portcheck's method to discover PORTSDIR_PATH doesn't work well if FLAVOR
is set.  This has bugged me in the past and happened again minutes ago
when reviewing py-phonenumbers.

Maybe portcheck should ignore more values from the environment, but this
is already an improvement.  ok?


Index: portcheck
===================================================================
RCS file: /d/cvs/ports/infrastructure/bin/portcheck,v
retrieving revision 1.124
diff -u -p -p -u -r1.124 portcheck
--- portcheck 20 Oct 2018 17:14:03 -0000 1.124
+++ portcheck 12 Nov 2018 15:48:20 -0000
@@ -145,7 +145,7 @@ EOF
  )
  IFS=:
  set -A portsdir_path -- \
- $( (echo "$test_mf" | make -C / -f - show=PORTSDIR_PATH 2>/dev/null) || true)
+ $( (echo "$test_mf" | env FLAVOR= make -C / -f - show=PORTSDIR_PATH 2>/dev/null) || true)
  unset IFS
  if ((${#portsdir_path[@]} > 0)); then
  for p in "${portsdir_path[@]}"; do

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: portcheck(1) and FLAVOR

Vadim Zhukov
пн, 12 нояб. 2018 г. в 18:55, Jeremie Courreges-Anglas <[hidden email]>:

>
>
> portcheck's method to discover PORTSDIR_PATH doesn't work well if FLAVOR
> is set.  This has bugged me in the past and happened again minutes ago
> when reviewing py-phonenumbers.
>
> Maybe portcheck should ignore more values from the environment, but this
> is already an improvement.  ok?
>
>
> Index: portcheck
> ===================================================================
> RCS file: /d/cvs/ports/infrastructure/bin/portcheck,v
> retrieving revision 1.124
> diff -u -p -p -u -r1.124 portcheck
> --- portcheck   20 Oct 2018 17:14:03 -0000      1.124
> +++ portcheck   12 Nov 2018 15:48:20 -0000
> @@ -145,7 +145,7 @@ EOF
>         )
>         IFS=:
>         set -A portsdir_path -- \
> -               $( (echo "$test_mf" | make -C / -f - show=PORTSDIR_PATH 2>/dev/null) || true)
> +               $( (echo "$test_mf" | env FLAVOR= make -C / -f - show=PORTSDIR_PATH 2>/dev/null) || true)
>         unset IFS
>         if ((${#portsdir_path[@]} > 0)); then
>                 for p in "${portsdir_path[@]}"; do
>

I agree; okay & thanks!

--
  WBR,
  Vadim Zhukov