ping: patch: fix rc(8) wsconsctl invocation

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

ping: patch: fix rc(8) wsconsctl invocation

zeurkous
[not subscribed, please Cc, thanks]

This issue still affects 6.5. Note that 'HiFn' is from me wscons 'many
ttys' patches, but it equally applies to standard stuff, e.g. 'Cmd'.

The patch is the same. If someone would commit this, me'd be grateful.

         --zeur.

> The following completely plausible:
>
>  keyboard1.map+=keycode 101=HiFn
>
> in the wsconsctl.conf(5) file is not passed to wsconsctl(8) intact,
> leading to syntax errors being reported by the latter (and the requested
> action not being taken).
>
> The below patch fixes this by replacing the apparent UUOE with a
> straightforward invocation.
>
>         --zeurkous.
>
> Index: src/etc/rc
> ===================================================================
> RCS file: /cvs/src/etc/rc,v
> retrieving revision 1.529
> diff -u -p -r1.529 rc
> --- src/etc/rc 23 Jul 2018 11:54:49 -0000 1.529
> +++ src/etc/rc 24 Dec 2018 11:12:23 -0000
> @@ -80,7 +80,7 @@ wsconsctl_conf() {
>  
>   stripcom /etc/wsconsctl.conf |
>   while read _line; do
> - eval "wsconsctl $_line"
> + wsconsctl "$_line"
>   done
>  }
>

--
Friggin' Machines!

Reply | Threaded
Open this post in threaded view
|

ping^2: patch: fix rc(8) wsconsctl invocation

zeurkous
[not subscribed, please Cc, thanks]

Still in 6.6! Please commit :)

        --zeur.

> This issue still affects 6.5. Note that 'HiFn' is from me wscons 'many
> ttys' patches, but it equally applies to standard stuff, e.g. 'Cmd'.
>
> The patch is the same. If someone would commit this, me'd be grateful.
>
>         --zeur.
>
>> The following completely plausible:
>>
>>  keyboard1.map+=keycode 101=HiFn
>>
>> in the wsconsctl.conf(5) file is not passed to wsconsctl(8) intact,
>> leading to syntax errors being reported by the latter (and the requested
>> action not being taken).
>>
>> The below patch fixes this by replacing the apparent UUOE with a
>> straightforward invocation.
>>
>>         --zeurkous.
>>
>> Index: src/etc/rc
>> ===================================================================
>> RCS file: /cvs/src/etc/rc,v
>> retrieving revision 1.529
>> diff -u -p -r1.529 rc
>> --- src/etc/rc 23 Jul 2018 11:54:49 -0000 1.529
>> +++ src/etc/rc 24 Dec 2018 11:12:23 -0000
>> @@ -80,7 +80,7 @@ wsconsctl_conf() {
>>  
>>   stripcom /etc/wsconsctl.conf |
>>   while read _line; do
>> - eval "wsconsctl $_line"
>> + wsconsctl "$_line"
>>   done
>>  }
>>

--
Friggin' Machines!