php-5.6.21-no_suhosin build failure

[Devin Ceartas]

I have a amd64 VM running 5.9-stable.

The command given was: /usr/ports/lang/php/5.6# env FLAVOR=no_suhosin
SUBPACKAGE="-main" FETCH_PACKAGES=Yes make install

The output stalled at a prompt asking what file to patch. I entered
return, then "y", and it died. Here's the last screen of the output:


Link to /usr/ports/packages/amd64/ftp/tidyp-1.04p1v0.tgz
Link to /usr/ports/packages/amd64/cdrom/tidyp-1.04p1v0.tgz
===>  Verifying specs: c
===>  found c.84.2
===>  Installing tidyp-1.04p1v0 from /usr/ports/packages/amd64/all/
tidyp-1.04p1v0: ok
===> Returning to build of php-5.6.21-no_suhosin
===> php-5.6.21-no_suhosin depends on: tidyp-* -> tidyp-1.04p1v0
===> php-5.6.21-no_suhosin depends on: libxslt-* -> libxslt-1.1.28p3
===>  Verifying specs:  stdc++ ncurses readline c crypto lzma m pthread
ssl xml2>=8 z intl>=5 iconv>=6 ncurses readline stdc++ stdc++ ncurses
readline c crypto lzma m pthread ssl xml2>=8 z intl>=5 iconv>=6 ncurses
readline stdc++ bz2>=10 pthread pthread crypto idn nghttp2 ssl z curl>=2
gdbm>=2 pthread t1>=5 z jpeg>=62 png>=3 pthread X11 Xpm freetype gmp>=4
pthread icudata icui18n icuio icuuc pthread pthread crypto ssl
c-client>=5 pthread ldap>=2 lber mcrypt ltdl>=1 pthread pthread
lib/mysql/mysqlclient crypto m pthread ssl z lib/mysql/mysqlclient
iodbc>=2 pthread iodbcinst pthread crypto m pthread ssl z
lib/mysql/mysqlclient pq>=2 pthread pq>=2 pthread aspell>=16 pspell>=16
pthread pthread iconv>=2 m pthread z xml2>=8 crypto m netsnmp>=6.2
pthread ct pthread sybdb>=6 pthread sybdb>=6 pthread tidyp pthread
iconv>=2 m z xml2>=8 pthread iconv>=2 m xml2 z xslt>=3 exslt pthread z
pthread
===>  found stdc++.57.0 ncurses.14.0 readline.4.0 c.84.2 crypto.37.0
lzma.2.1 m.9.0 pthread.20.1 ssl.38.0 xml2.15.1 z.5.0 intl.6.0 iconv.6.0
bz2.10.4 idn.17.2 nghttp2.0.1 curl.25.3 gdbm.4.1 t1.6.0 jpeg.67.0
png.17.2 X11.16.1 Xpm.9.0 freetype.24.1 gmp.9.0 icudata.9.0 icui18n.9.0
icuio.9.0 icuuc.9.0 c-client.7.0 ldap.13.1 lber.12.0 mcrypt.8.7 ltdl.5.0
lib/mysql/mysqlclient.27.0 iodbc.3.16 iodbcinst.3.15 pq.5.7 aspell.17.0
pspell.17.0 netsnmp.14.0 ct.6.0 sybdb.8.0 tidyp.0.0 xslt.3.8 exslt.9.8
===>  Extracting for php-5.6.21-no_suhosin
===>  Patching for php-5.6.21-no_suhosin
File to patch: No file found--skip this patch? [n] File to patch: No
file found--skip this patch? [n] File to patch:
No file found--skip this patch? [n] y
3 out of 3 hunks ignored--saving rejects to Oops.rej
***>   patch-ext_suhosin_execute_c did not apply cleanly
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2695
'/usr/ports/pobj/php-5.6.21-no_suhosin/.patch_done': @if cd
/usr/ports/lang/...)
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:1959
'/usr/ports/packages/amd64/all/php-5.6.21-no_suhosin.tgz')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:1957
'/usr/ports/packages/amd64/all/php-5.6.21-no_suhosin.tgz')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2512
'subpackage')
*** Error 1 in . (/usr/ports/infrastructure/mk/bsd.port.mk:1973
'/var/db/pkg/php-5.6.21-no_suhosin/+CONTENTS')
*** Error 1 in /usr/ports/lang/php/5.6
(/usr/ports/infrastructure/mk/bsd.port.mk:2495 'install')



The file "/usr/ports/pobj/php-5.6.21-no_suhosin/php-5.6.21/Oops.rej"
contains the following:

@@ -1312,6 +1312,9 @@
   */
  static void suhosin_gen_entropy(php_uint32 *entropybuf TSRMLS_DC)
  {
+#if defined(__OpenBSD__)
+    arc4random_buf(entropybuf, 8 * sizeof(php_uint32));
+#else
      php_uint32 seedbuf[20];
      /* On a modern OS code, stack and heap base are randomized */
      unsigned long code_value  = (unsigned long)suhosin_gen_entropy;
@@ -1335,7 +1338,7 @@
  #endif
      seedbuf[5] = (php_uint32) 0x7fffffff * php_combined_lcg(TSRMLS_C);

-#ifndef PHP_WIN32
+#if !defined(PHP_WIN32)
      fd = VCWD_OPEN("/dev/urandom", O_RDONLY);
      if (fd >= 0) {
          /* ignore error case - if urandom doesn't give us any/enough
random bytes */
@@ -1354,6 +1357,7 @@
          suhosin_SHA256Update(&context, (unsigned
char*)SUHOSIN_G(seedingkey), strlen(SUHOSIN_G(seedingkey)));
      }
      suhosin_SHA256Final((void *)entropybuf, &context);
+#endif /* openbsd */
  }
  /* }}} */


So it looks like this is a suhosin patch of some sort which can't find a
file because it doesn't exist in the no_suhosin flavor...


devin
--
contact info: https://nacredata.com/devin



devin
--
contact info: https://nacredata.com/devin

• Amazing Tie-Dye Tee-shirts: https://www.icedyedesigns.com
• Art/Poetry/Environment: https://secure.extinctionwitness.org/support
• Support progressive climate politics:
https://secure.voteclimatepac.org/donate/
• Forest Protection in Ohio:
https://www.buckeyeforestcouncil.org/donate.php

[Stuart Henderson]

On 2016/06/02 23:22, Devin Ceartas wrote:
> I have a amd64 VM running 5.9-stable.
>
> The command given was: /usr/ports/lang/php/5.6# env FLAVOR=no_suhosin
> SUBPACKAGE="-main" FETCH_PACKAGES=Yes make install
>
> The output stalled at a prompt asking what file to patch. I entered return,
> then "y", and it died. Here's the last screen of the output:

This fixes it, diff is for current but easy to apply to -stable.

Index: Makefile.inc
===================================================================
RCS file: /cvs/ports/lang/php/Makefile.inc,v
retrieving revision 1.84
diff -u -p -u -1 -0 -r1.84 Makefile.inc
--- Makefile.inc 28 Apr 2016 18:19:23 -0000 1.84
+++ Makefile.inc 3 Jun 2016 08:56:59 -0000
@@ -345,20 +345,21 @@ LIB_DEPENDS-main= devel/gettext \
  textproc/libxml
 RUN_DEPENDS-main= mail/femail,-chroot
 LIB_DEPENDS-fastcgi= ${LIB_DEPENDS-main}
 RUN_DEPENDS-fastcgi=
 
 SUHOSIN_V= 0.9.38
 .if ${FLAVOR:Mno_suhosin} || ${PV} == "7.0"
 SUPDISTFILES= suhosin-${SUHOSIN_V}.tar.gz:0
 .else
 DISTFILES+= suhosin-${SUHOSIN_V}.tar.gz:0
+PATCH_LIST= patch-* suhosin-*
 CONFIGURE_ARGS+= --enable-suhosin
 
 pre-patch:
  @mv ${WRKDIR}/suhosin-${SUHOSIN_V} ${WRKSRC}/ext/suhosin
 .endif
 
 pre-fake:
  ${INSTALL_DATA_DIR} ${PREFIX}/${APACHE_MODULE_SUBDIR}/modules
 
 INSTALL_TARGET= install-headers install-build install-programs

[Stuart Henderson]

Oops sorry: also rename patch-ext_suhosin_execute_c to suhosin-ext_suhosin_execute_c.

On 3 June 2016 09:58:55 BST, Stuart Henderson <[hidden email]> wrote:

>On 2016/06/02 23:22, Devin Ceartas wrote:
>> I have a amd64 VM running 5.9-stable.
>>
>> The command given was: /usr/ports/lang/php/5.6# env FLAVOR=no_suhosin
>> SUBPACKAGE="-main" FETCH_PACKAGES=Yes make install
>>
>> The output stalled at a prompt asking what file to patch. I entered
>return,
>> then "y", and it died. Here's the last screen of the output:
>
>This fixes it, diff is for current but easy to apply to -stable.
>
>Index: Makefile.inc
>===================================================================
>RCS file: /cvs/ports/lang/php/Makefile.inc,v
>retrieving revision 1.84
>diff -u -p -u -1 -0 -r1.84 Makefile.inc
>--- Makefile.inc 28 Apr 2016 18:19:23 -0000 1.84
>+++ Makefile.inc 3 Jun 2016 08:56:59 -0000
>@@ -345,20 +345,21 @@ LIB_DEPENDS-main= devel/gettext \
> textproc/libxml
> RUN_DEPENDS-main= mail/femail,-chroot
> LIB_DEPENDS-fastcgi= ${LIB_DEPENDS-main}
> RUN_DEPENDS-fastcgi=
>
> SUHOSIN_V= 0.9.38
> .if ${FLAVOR:Mno_suhosin} || ${PV} == "7.0"
> SUPDISTFILES= suhosin-${SUHOSIN_V}.tar.gz:0
> .else
> DISTFILES+= suhosin-${SUHOSIN_V}.tar.gz:0
>+PATCH_LIST= patch-* suhosin-*
> CONFIGURE_ARGS+= --enable-suhosin
>
> pre-patch:
> @mv ${WRKDIR}/suhosin-${SUHOSIN_V} ${WRKSRC}/ext/suhosin
> .endif
>
> pre-fake:
> ${INSTALL_DATA_DIR} ${PREFIX}/${APACHE_MODULE_SUBDIR}/modules
>
> INSTALL_TARGET= install-headers install-build install-programs