pfctl: zap unused function parameter

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

pfctl: zap unused function parameter

Klemens Nanni-2
Never used, probably just copy/pasta since introduction in 2006.

`-i' and other flags are completely ignored with `-K' anyway.

OK?

Index: pfctl.c
===================================================================
RCS file: /cvs/src/sbin/pfctl/pfctl.c,v
retrieving revision 1.362
diff -u -p -r1.362 pfctl.c
--- pfctl.c 2 Jan 2019 23:08:00 -0000 1.362
+++ pfctl.c 5 Jan 2019 20:55:11 -0000
@@ -67,7 +67,7 @@ void pfctl_clear_rules(int, int, char *
 void pfctl_clear_src_nodes(int, int);
 void pfctl_clear_states(int, const char *, int);
 void pfctl_addrprefix(char *, struct pf_addr *);
-void pfctl_kill_src_nodes(int, const char *, int);
+void pfctl_kill_src_nodes(int, int);
 void pfctl_net_kill_states(int, const char *, int, int);
 void pfctl_label_kill_states(int, const char *, int, int);
 void pfctl_id_kill_states(int, int);
@@ -405,7 +405,7 @@ pfctl_addrprefix(char *addr, struct pf_a
 }
 
 void
-pfctl_kill_src_nodes(int dev, const char *iface, int opts)
+pfctl_kill_src_nodes(int dev, int opts)
 {
  struct pfioc_src_node_kill psnk;
  struct addrinfo *res[2], *resp[2];
@@ -2661,7 +2661,7 @@ main(int argc, char *argv[])
  }
 
  if (src_node_killers)
- pfctl_kill_src_nodes(dev, ifaceopt, opts);
+ pfctl_kill_src_nodes(dev, opts);
 
  if (tblcmdopt != NULL) {
  error = pfctl_table(argc, argv, tableopt,

Reply | Threaded
Open this post in threaded view
|

Re: pfctl: zap unused function parameter

Alexandr Nedvedicky
Hello,

On Sat, Jan 05, 2019 at 10:10:07PM +0100, Klemens Nanni wrote:
> Never used, probably just copy/pasta since introduction in 2006.
>
> `-i' and other flags are completely ignored with `-K' anyway.
>
> OK?
>

OK sashan@

> Index: pfctl.c
> ===================================================================
> RCS file: /cvs/src/sbin/pfctl/pfctl.c,v
> retrieving revision 1.362
> diff -u -p -r1.362 pfctl.c
> --- pfctl.c 2 Jan 2019 23:08:00 -0000 1.362
> +++ pfctl.c 5 Jan 2019 20:55:11 -0000
> @@ -67,7 +67,7 @@ void pfctl_clear_rules(int, int, char *
>  void pfctl_clear_src_nodes(int, int);
>  void pfctl_clear_states(int, const char *, int);
>  void pfctl_addrprefix(char *, struct pf_addr *);
> -void pfctl_kill_src_nodes(int, const char *, int);
> +void pfctl_kill_src_nodes(int, int);
>  void pfctl_net_kill_states(int, const char *, int, int);
>  void pfctl_label_kill_states(int, const char *, int, int);
>  void pfctl_id_kill_states(int, int);
> @@ -405,7 +405,7 @@ pfctl_addrprefix(char *addr, struct pf_a
>  }
>  
>  void
> -pfctl_kill_src_nodes(int dev, const char *iface, int opts)
> +pfctl_kill_src_nodes(int dev, int opts)
>  {
>   struct pfioc_src_node_kill psnk;
>   struct addrinfo *res[2], *resp[2];
> @@ -2661,7 +2661,7 @@ main(int argc, char *argv[])
>   }
>  
>   if (src_node_killers)
> - pfctl_kill_src_nodes(dev, ifaceopt, opts);
> + pfctl_kill_src_nodes(dev, opts);
>  
>   if (tblcmdopt != NULL) {
>   error = pfctl_table(argc, argv, tableopt,
>