pci/i386: Fix typo

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

pci/i386: Fix typo

Christian Ludwig-3
Extents code has its own set of flags and does not use malloc's.
The current code passes in EX_FAST by accident, which does no harm.
That's probably why nobody stumbled upon it, yet.
---
 sys/arch/i386/pci/pci_machdep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/arch/i386/pci/pci_machdep.c b/sys/arch/i386/pci/pci_machdep.c
index b712ff242ed..bfd8055f125 100644
--- a/sys/arch/i386/pci/pci_machdep.c
+++ b/sys/arch/i386/pci/pci_machdep.c
@@ -915,7 +915,7 @@ pci_init_extents(void)
     NULL, 0, EX_NOWAIT | EX_FILLED);
  if (pciio_ex == NULL)
  return;
- extent_free(pciio_ex, 0, 0x10000, M_NOWAIT);
+ extent_free(pciio_ex, 0, 0x10000, EX_NOWAIT);
  }
 
  if (pcimem_ex == NULL) {
--
2.19.2

Reply | Threaded
Open this post in threaded view
|

Re: pci/i386: Fix typo

Mark Kettenis
> From: Christian Ludwig <[hidden email]>
> Cc: Christian Ludwig <[hidden email]>
> Date: Thu, 13 Dec 2018 17:44:47 +0100
>
> Extents code has its own set of flags and does not use malloc's.
> The current code passes in EX_FAST by accident, which does no harm.
> That's probably why nobody stumbled upon it, yet.
> ---
>  sys/arch/i386/pci/pci_machdep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ok kettenis@

> diff --git a/sys/arch/i386/pci/pci_machdep.c b/sys/arch/i386/pci/pci_machdep.c
> index b712ff242ed..bfd8055f125 100644
> --- a/sys/arch/i386/pci/pci_machdep.c
> +++ b/sys/arch/i386/pci/pci_machdep.c
> @@ -915,7 +915,7 @@ pci_init_extents(void)
>      NULL, 0, EX_NOWAIT | EX_FILLED);
>   if (pciio_ex == NULL)
>   return;
> - extent_free(pciio_ex, 0, 0x10000, M_NOWAIT);
> + extent_free(pciio_ex, 0, 0x10000, EX_NOWAIT);
>   }
>  
>   if (pcimem_ex == NULL) {
> --
> 2.19.2
>
>

Reply | Threaded
Open this post in threaded view
|

Re: pci/i386: Fix typo

Christian Ludwig-3
On Thursday, 13. December 2018, 19:52:13 Mark Kettenis wrote:

> > From: Christian Ludwig <[hidden email]>
> > Cc: Christian Ludwig <[hidden email]>
> > Date: Thu, 13 Dec 2018 17:44:47 +0100
> >
> > Extents code has its own set of flags and does not use malloc's.
> > The current code passes in EX_FAST by accident, which does no harm.
> > That's probably why nobody stumbled upon it, yet.
> > ---
> >
> >  sys/arch/i386/pci/pci_machdep.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> ok kettenis@

Anyone in the mood to commit this?

> > diff --git a/sys/arch/i386/pci/pci_machdep.c
> > b/sys/arch/i386/pci/pci_machdep.c index b712ff242ed..bfd8055f125 100644
> > --- a/sys/arch/i386/pci/pci_machdep.c
> > +++ b/sys/arch/i386/pci/pci_machdep.c
> > @@ -915,7 +915,7 @@ pci_init_extents(void)
> >
> >      NULL, 0, EX_NOWAIT | EX_FILLED);
> >  
> >   if (pciio_ex == NULL)
> >  
> >   return;
> >
> > - extent_free(pciio_ex, 0, 0x10000, M_NOWAIT);
> > + extent_free(pciio_ex, 0, 0x10000, EX_NOWAIT);
> >
> >   }
> >  
> >   if (pcimem_ex == NULL) {