[patch] ftpd: unused include

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[patch] ftpd: unused include

Fritjof Bornebusch
Looks like monitor.h doesn't need to be included
in monitor_fdpass.c.

Mentioned by [hidden email].

--f.


Index: monitor_fdpass.c
===================================================================
RCS file: /cvs/src/libexec/ftpd/monitor_fdpass.c,v
retrieving revision 1.7
diff -u -r1.7 monitor_fdpass.c
--- monitor_fdpass.c 29 Feb 2016 20:22:36 -0000 1.7
+++ monitor_fdpass.c 6 Apr 2016 18:16:24 -0000
@@ -26,7 +26,6 @@
 #include <string.h>
 #include <syslog.h>
 #include <unistd.h>
-#include "monitor.h"
 
 void
 send_fd(int sock, int fd)

Reply | Threaded
Open this post in threaded view
|

Re: [patch] ftpd: unused include

Ted Unangst-6
[hidden email] wrote:
> Looks like monitor.h doesn't need to be included
> in monitor_fdpass.c.
>
> Mentioned by [hidden email].

it's better if the declaration and definition of functions always match.