[new] x11/lxterminal - lightweight, vte-based and desktop-independent terminal

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[new] x11/lxterminal - lightweight, vte-based and desktop-independent terminal

Shawn Chiou
Hi ports@,

Attached is the port of lxterminal. It is a GTK based terminal emulator of
LXDE.

Tested on amd64, also pass with portcheck -N.

Any feedback is welcome.

Shawn Chiou
--


[image: --]

Shawn Chiou
[image: https://]about.me/shawn.chiou
<https://about.me/shawn.chiou?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links>

lxterminal.tar.gz (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [new] x11/lxterminal - lightweight, vte-based and desktop-independent terminal

Bjorn Ketelaars
On Thu 17/09/2020 00:25, Shawn Chiou wrote:
> Hi ports@,
>
> Attached is the port of lxterminal. It is a GTK based terminal emulator of
> LXDE.
>
> Tested on amd64, also pass with portcheck -N.
>
> Any feedback is welcome.


Please use a complete email address with a real name for MAINTAINER.
Have a look at /usr/ports/infrastructure/templates/Makefile.template for
an example.

Minor issue: use a tab after 'VARIABLE =' instead of a space. This
makes the Makefile more consistent. Have a look at BUILD_DEPENDS,
CONFIGURE_ARGS and CONFIGURE_STYLE, which use a space after '='.

Builds and runs for me.

Reply | Threaded
Open this post in threaded view
|

Re: [new] x11/lxterminal - lightweight, vte-based and desktop-independent terminal

Shawn Chiou
Hi bket@,

Thanks for your review and advice.

All issues fixed with new attached file.



On Thu, Sep 17, 2020 at 12:36 PM Bjorn Ketelaars <[hidden email]> wrote:

> On Thu 17/09/2020 00:25, Shawn Chiou wrote:
> > Hi ports@,
> >
> > Attached is the port of lxterminal. It is a GTK based terminal emulator
> of
> > LXDE.
> >
> > Tested on amd64, also pass with portcheck -N.
> >
> > Any feedback is welcome.
>
>
> Please use a complete email address with a real name for MAINTAINER.
> Have a look at /usr/ports/infrastructure/templates/Makefile.template for
> an example.
>
> Minor issue: use a tab after 'VARIABLE =' instead of a space. This
> makes the Makefile more consistent. Have a look at BUILD_DEPENDS,
> CONFIGURE_ARGS and CONFIGURE_STYLE, which use a space after '='.
>
> Builds and runs for me.
>

--


[image: --]

Shawn Chiou
[image: https://]about.me/shawn.chiou
<https://about.me/shawn.chiou?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links>

lxterminal.tar.gz (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [new] x11/lxterminal - lightweight, vte-based and desktop-independent terminal

Bjorn Ketelaars
On Thu 17/09/2020 13:56, Shawn Chiou wrote:
> Hi bket@,
>
> Thanks for your review and advice.
>
> All issues fixed with new attached file.

Port looks good, and runs fine on amd64. I'm OK with this if someone
wants to import it.

Reply | Threaded
Open this post in threaded view
|

Re: [new] x11/lxterminal - lightweight, vte-based and desktop-independent terminal

Bjorn Ketelaars
On Fri 18/09/2020 06:21, Bjorn Ketelaars wrote:
> On Thu 17/09/2020 13:56, Shawn Chiou wrote:
> > Hi bket@,
> >
> > Thanks for your review and advice.
> >
> > All issues fixed with new attached file.
>
> Port looks good, and runs fine on amd64. I'm OK with this if someone
> wants to import it.

Hmmm, last minute find that needs to be fixed:

/usr/ports/x11/lxterminal$ ls -ltra .* */.*
-rw-r--r--  1 bket  staff  212 Sep  5 12:01 ._distinfo
-rw-r--r--  1 bket  staff  212 Sep  6 16:50 pkg/._PLIST
-rwxr-xr-x  1 bket  staff  212 Sep  6 16:50 ._pkg
-rw-r--r--  1 bket  staff  212 Sep  6 16:55 pkg/._DESCR
-rw-r--r--  1 bket  staff  212 Sep 17 07:50 ._Makefile

Reply | Threaded
Open this post in threaded view
|

Re: [new] x11/lxterminal - lightweight, vte-based and desktop-independent terminal

Shawn Chiou
Hi bket@,

Thanks for your review.

I'm sorry for the mistake.

All ._* files removed in the new attached file.


On Fri, Sep 18, 2020 at 12:37 PM Bjorn Ketelaars <[hidden email]> wrote:

> On Fri 18/09/2020 06:21, Bjorn Ketelaars wrote:
> > On Thu 17/09/2020 13:56, Shawn Chiou wrote:
> > > Hi bket@,
> > >
> > > Thanks for your review and advice.
> > >
> > > All issues fixed with new attached file.
> >
> > Port looks good, and runs fine on amd64. I'm OK with this if someone
> > wants to import it.
>
> Hmmm, last minute find that needs to be fixed:
>
> /usr/ports/x11/lxterminal$ ls -ltra .* */.*
> -rw-r--r--  1 bket  staff  212 Sep  5 12:01 ._distinfo
> -rw-r--r--  1 bket  staff  212 Sep  6 16:50 pkg/._PLIST
> -rwxr-xr-x  1 bket  staff  212 Sep  6 16:50 ._pkg
> -rw-r--r--  1 bket  staff  212 Sep  6 16:55 pkg/._DESCR
> -rw-r--r--  1 bket  staff  212 Sep 17 07:50 ._Makefile
>

--


[image: --]

Shawn Chiou
[image: https://]about.me/shawn.chiou
<https://about.me/shawn.chiou?promo=email_sig&utm_source=email_sig&utm_medium=email_sig&utm_campaign=external_links>

lxterminal.tar.gz (1K) Download Attachment