mldonkey: use custom build of OCaml 3.12

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

mldonkey: use custom build of OCaml 3.12

Christopher Zimmermann-2
Hi,

Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
Its build system has the option to build against a private build of
OCaml 3.12 and a copy of lablgtk.
I adapted the port to use this option and therefore get rid of the
dependency on a system wide OCaml installation.
Tested to build and start up on amd64.
Not tested on bytecode-only archs.

Is this the way to go? OK to commit?
Is this port still in use?

Christopher



Index: Makefile
===================================================================
RCS file: /cvs/ports/net/mldonkey/Makefile,v
retrieving revision 1.30
diff -u -p -r1.30 Makefile
--- Makefile 20 May 2019 22:15:19 -0000 1.30
+++ Makefile 17 Jun 2019 19:07:35 -0000
@@ -21,13 +21,21 @@ WANTLIB += pthread rsvg-2 ${COMPILER_LIB
 
 COMPILER = base-clang ports-gcc base-gcc
 
-MASTER_SITES = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
+MASTER_SITES0 = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
+MASTER_SITES1 = http://caml.inria.fr/pub/distrib/ocaml-3.12/
+MASTER_SITES2 = http://www.math.nagoya-u.ac.jp/~garrigue/soft/olabl/dist/
 
+OCAML_SRC = ocaml-3.12.0.tar.gz
+LAMLGTK_SRC = lablgtk-2.14.2.tar.gz
 EXTRACT_SUFX = .tar.bz2
+DISTFILES = ${DISTNAME}${EXTRACT_SUFX}:0 ${OCAML_SRC}:1 ${LAMLGTK_SRC}:2
+
 
 CONFIGURE_STYLE = gnu
 CONFIGURE_ARGS += --enable-gui=newgui2 \
- --enable-upnp-natpmp
+ --enable-upnp-natpmp \
+ --enable-force-ocaml \
+ --enable-batch
 CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include -I${X11BASE}/include' \
  LDFLAGS='${LDFLAGS}' \
  ac_cv_prog_RPMBUILD="" \
@@ -44,8 +52,8 @@ MODGNU_CONFIG_GUESS_DIRS = ${WRKSRC}/con
 WRKCONF = ${WRKSRC}/config
 
 USE_GMAKE = Yes
-MODULES = lang/ocaml
-BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
+#MODULES = lang/ocaml
+#BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
 LIB_DEPENDS = archivers/bzip2 \
  devel/gettext,-runtime \
  devel/libmagic \
@@ -53,6 +61,7 @@ LIB_DEPENDS = archivers/bzip2 \
  net/miniupnp/libnatpmp \
  net/miniupnp/miniupnpc>=1.9 \
  x11/gnome/librsvg \
+ devel/libglade2 \
  x11/gtk+2
 
 ALL_TARGET = depend all
@@ -67,6 +76,11 @@ FAKE_FLAGS = OCAML_NATIVE=no
 NO_TEST = Yes
 
 .include <bsd.port.arch.mk>
+
+post-extract:
+ ln -s ${FULLDISTDIR}/${OCAML_SRC} ${WRKSRC}/patches
+ ln -s ${FULLDISTDIR}/${LAMLGTK_SRC} ${WRKSRC}/patches
+
 pre-patch:
  @cd ${WRKSRC}; perl -i -pe 's/\r$$//' `find . -type f`
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/net/mldonkey/distinfo,v
retrieving revision 1.6
diff -u -p -r1.6 distinfo
--- distinfo 17 Aug 2017 10:06:12 -0000 1.6
+++ distinfo 17 Jun 2019 19:07:35 -0000
@@ -1,2 +1,6 @@
+SHA256 (lablgtk-2.14.2.tar.gz) = SYGr7avcRiMD80UQQELIivInzNUP0wqb9I/TU6sC0Lo=
 SHA256 (mldonkey-3.1.6.tar.bz2) = Gza1fAWoPC42PAhb+OgGMIhMbJLs3v/BrV4cOamOBD0=
+SHA256 (ocaml-3.12.0.tar.gz) = 2WSzheEQwVF8neHGMxR21eejWFzGkra2uJc/Opvn2ks=
+SIZE (lablgtk-2.14.2.tar.gz) = 779803
 SIZE (mldonkey-3.1.6.tar.bz2) = 2886916
+SIZE (ocaml-3.12.0.tar.gz) = 3271024
Index: patches/patch-config_Makefile_in
===================================================================
RCS file: /cvs/ports/net/mldonkey/patches/patch-config_Makefile_in,v
retrieving revision 1.6
diff -u -p -r1.6 patch-config_Makefile_in
--- patches/patch-config_Makefile_in 4 Mar 2019 12:51:16 -0000 1.6
+++ patches/patch-config_Makefile_in 17 Jun 2019 19:07:35 -0000
@@ -2,34 +2,6 @@ $OpenBSD: patch-config_Makefile_in,v 1.6
 Index: config/Makefile.in
 --- config/Makefile.in.orig
 +++ config/Makefile.in
-@@ -13,6 +13,9 @@ changequote([[, ]])
-
- include config/Makefile.config
-
-+OCAMLC:=$(OCAMLC) -unsafe-string
-+OCAMLOPT:=$(OCAMLOPT) -unsafe-string
-+
- ifneq ("$(GLIBC_VERSION)" , "")
-   GLIBC_VERSION_ARCH = "_glibc-"$(GLIBC_VERSION)
- endif
-@@ -93,7 +96,7 @@ SRC_FILETP=src/networks/fileTP
- SUBDIRS=$(EXTLIB) $(CDK) $(BITSTRING) $(LIB) $(RSS) $(XML) $(NET) tools \
-    $(COMMON) $(DRIVER) $(MP3) src/config/$(OS_FILES)
-
--INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4
-+INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4 -I +num
-
- CFLAGS:=$(CFLAGS) $(CONFIG_INCLUDES) $(GTKCFLAGS) $(GD_CFLAGS)
-
-@@ -124,7 +127,7 @@ endif
-
- #######################################################################
-
--LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)"
-+LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)" -I +num
-
- ifeq ("$(OS_FILES2)", "mingw")
-   LIBS_flags += -cclib "-lws2_32 -lgdi32 -luser32 -ladvapi32 -lwsock32 -limm32 -lshell32 -lole32 resfile.o"
 @@ -633,6 +636,8 @@ uninstall::
  rm -f $(BINDIR)/mlnet
  rm -f $(BINDIR)/mlgui


--
http://gmerlin.de
OpenPGP: http://gmerlin.de/christopher.pub
CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1

attachment0 (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

Anil Madhavapeddy-2
I think this approach is fine for this particular package, since upstream lags in recent times.

The opam package for mldonkey is on ocaml<4.06, but I'm CCing the current maintainer Ygrek in case there is a 4.08 port in the offing.

cheers,
Anil

> On 17 Jun 2019, at 20:20, Christopher Zimmermann <[hidden email]> wrote:
>
> Hi,
>
> Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
> Its build system has the option to build against a private build of
> OCaml 3.12 and a copy of lablgtk.
> I adapted the port to use this option and therefore get rid of the
> dependency on a system wide OCaml installation.
> Tested to build and start up on amd64.
> Not tested on bytecode-only archs.
>
> Is this the way to go? OK to commit?
> Is this port still in use?
>
> Christopher
>
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/mldonkey/Makefile,v
> retrieving revision 1.30
> diff -u -p -r1.30 Makefile
> --- Makefile 20 May 2019 22:15:19 -0000 1.30
> +++ Makefile 17 Jun 2019 19:07:35 -0000
> @@ -21,13 +21,21 @@ WANTLIB += pthread rsvg-2 ${COMPILER_LIB
>
> COMPILER = base-clang ports-gcc base-gcc
>
> -MASTER_SITES = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
> +MASTER_SITES0 = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
> +MASTER_SITES1 = http://caml.inria.fr/pub/distrib/ocaml-3.12/
> +MASTER_SITES2 = http://www.math.nagoya-u.ac.jp/~garrigue/soft/olabl/dist/
>
> +OCAML_SRC = ocaml-3.12.0.tar.gz
> +LAMLGTK_SRC = lablgtk-2.14.2.tar.gz
> EXTRACT_SUFX = .tar.bz2
> +DISTFILES = ${DISTNAME}${EXTRACT_SUFX}:0 ${OCAML_SRC}:1 ${LAMLGTK_SRC}:2
> +
>
> CONFIGURE_STYLE = gnu
> CONFIGURE_ARGS += --enable-gui=newgui2 \
> - --enable-upnp-natpmp
> + --enable-upnp-natpmp \
> + --enable-force-ocaml \
> + --enable-batch
> CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include -I${X11BASE}/include' \
> LDFLAGS='${LDFLAGS}' \
> ac_cv_prog_RPMBUILD="" \
> @@ -44,8 +52,8 @@ MODGNU_CONFIG_GUESS_DIRS = ${WRKSRC}/con
> WRKCONF = ${WRKSRC}/config
>
> USE_GMAKE = Yes
> -MODULES = lang/ocaml
> -BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
> +#MODULES = lang/ocaml
> +#BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
> LIB_DEPENDS = archivers/bzip2 \
> devel/gettext,-runtime \
> devel/libmagic \
> @@ -53,6 +61,7 @@ LIB_DEPENDS = archivers/bzip2 \
> net/miniupnp/libnatpmp \
> net/miniupnp/miniupnpc>=1.9 \
> x11/gnome/librsvg \
> + devel/libglade2 \
> x11/gtk+2
>
> ALL_TARGET = depend all
> @@ -67,6 +76,11 @@ FAKE_FLAGS = OCAML_NATIVE=no
> NO_TEST = Yes
>
> .include <bsd.port.arch.mk>
> +
> +post-extract:
> + ln -s ${FULLDISTDIR}/${OCAML_SRC} ${WRKSRC}/patches
> + ln -s ${FULLDISTDIR}/${LAMLGTK_SRC} ${WRKSRC}/patches
> +
> pre-patch:
> @cd ${WRKSRC}; perl -i -pe 's/\r$$//' `find . -type f`
>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/net/mldonkey/distinfo,v
> retrieving revision 1.6
> diff -u -p -r1.6 distinfo
> --- distinfo 17 Aug 2017 10:06:12 -0000 1.6
> +++ distinfo 17 Jun 2019 19:07:35 -0000
> @@ -1,2 +1,6 @@
> +SHA256 (lablgtk-2.14.2.tar.gz) = SYGr7avcRiMD80UQQELIivInzNUP0wqb9I/TU6sC0Lo=
> SHA256 (mldonkey-3.1.6.tar.bz2) = Gza1fAWoPC42PAhb+OgGMIhMbJLs3v/BrV4cOamOBD0=
> +SHA256 (ocaml-3.12.0.tar.gz) = 2WSzheEQwVF8neHGMxR21eejWFzGkra2uJc/Opvn2ks=
> +SIZE (lablgtk-2.14.2.tar.gz) = 779803
> SIZE (mldonkey-3.1.6.tar.bz2) = 2886916
> +SIZE (ocaml-3.12.0.tar.gz) = 3271024
> Index: patches/patch-config_Makefile_in
> ===================================================================
> RCS file: /cvs/ports/net/mldonkey/patches/patch-config_Makefile_in,v
> retrieving revision 1.6
> diff -u -p -r1.6 patch-config_Makefile_in
> --- patches/patch-config_Makefile_in 4 Mar 2019 12:51:16 -0000 1.6
> +++ patches/patch-config_Makefile_in 17 Jun 2019 19:07:35 -0000
> @@ -2,34 +2,6 @@ $OpenBSD: patch-config_Makefile_in,v 1.6
> Index: config/Makefile.in
> --- config/Makefile.in.orig
> +++ config/Makefile.in
> -@@ -13,6 +13,9 @@ changequote([[, ]])
> -
> - include config/Makefile.config
> -
> -+OCAMLC:=$(OCAMLC) -unsafe-string
> -+OCAMLOPT:=$(OCAMLOPT) -unsafe-string
> -+
> - ifneq ("$(GLIBC_VERSION)" , "")
> -   GLIBC_VERSION_ARCH = "_glibc-"$(GLIBC_VERSION)
> - endif
> -@@ -93,7 +96,7 @@ SRC_FILETP=src/networks/fileTP
> - SUBDIRS=$(EXTLIB) $(CDK) $(BITSTRING) $(LIB) $(RSS) $(XML) $(NET) tools \
> -    $(COMMON) $(DRIVER) $(MP3) src/config/$(OS_FILES)
> -
> --INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4
> -+INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4 -I +num
> -
> - CFLAGS:=$(CFLAGS) $(CONFIG_INCLUDES) $(GTKCFLAGS) $(GD_CFLAGS)
> -
> -@@ -124,7 +127,7 @@ endif
> -
> - #######################################################################
> -
> --LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)"
> -+LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)" -I +num
> -
> - ifeq ("$(OS_FILES2)", "mingw")
> -   LIBS_flags += -cclib "-lws2_32 -lgdi32 -luser32 -ladvapi32 -lwsock32 -limm32 -lshell32 -lole32 resfile.o"
> @@ -633,6 +636,8 @@ uninstall::
>   rm -f $(BINDIR)/mlnet
>   rm -f $(BINDIR)/mlgui
>
>
> --
> http://gmerlin.de
> OpenPGP: http://gmerlin.de/christopher.pub
> CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1

Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

Stuart Henderson
In reply to this post by Christopher Zimmermann-2
On 2019/06/17 21:20, Christopher Zimmermann wrote:

> Hi,
>
> Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
> Its build system has the option to build against a private build of
> OCaml 3.12 and a copy of lablgtk.
> I adapted the port to use this option and therefore get rid of the
> dependency on a system wide OCaml installation.
> Tested to build and start up on amd64.
> Not tested on bytecode-only archs.
>
> Is this the way to go? OK to commit?
> Is this port still in use?
>
> Christopher

My vote would be for rm..

Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

kwesterback
In reply to this post by Christopher Zimmermann-2
On Mon, Jun 17, 2019 at 09:20:09PM +0200, Christopher Zimmermann wrote:

> Hi,
>
> Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
> Its build system has the option to build against a private build of
> OCaml 3.12 and a copy of lablgtk.
> I adapted the port to use this option and therefore get rid of the
> dependency on a system wide OCaml installation.
> Tested to build and start up on amd64.
> Not tested on bytecode-only archs.
>
> Is this the way to go? OK to commit?
> Is this port still in use?
>
> Christopher

I have never used mldonkey, but I have no objection to this approach.

.... Ken

>
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/mldonkey/Makefile,v
> retrieving revision 1.30
> diff -u -p -r1.30 Makefile
> --- Makefile 20 May 2019 22:15:19 -0000 1.30
> +++ Makefile 17 Jun 2019 19:07:35 -0000
> @@ -21,13 +21,21 @@ WANTLIB += pthread rsvg-2 ${COMPILER_LIB
>  
>  COMPILER = base-clang ports-gcc base-gcc
>  
> -MASTER_SITES = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
> +MASTER_SITES0 = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
> +MASTER_SITES1 = http://caml.inria.fr/pub/distrib/ocaml-3.12/
> +MASTER_SITES2 = http://www.math.nagoya-u.ac.jp/~garrigue/soft/olabl/dist/
>  
> +OCAML_SRC = ocaml-3.12.0.tar.gz
> +LAMLGTK_SRC = lablgtk-2.14.2.tar.gz
>  EXTRACT_SUFX = .tar.bz2
> +DISTFILES = ${DISTNAME}${EXTRACT_SUFX}:0 ${OCAML_SRC}:1 ${LAMLGTK_SRC}:2
> +
>  
>  CONFIGURE_STYLE = gnu
>  CONFIGURE_ARGS += --enable-gui=newgui2 \
> - --enable-upnp-natpmp
> + --enable-upnp-natpmp \
> + --enable-force-ocaml \
> + --enable-batch
>  CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include -I${X11BASE}/include' \
>   LDFLAGS='${LDFLAGS}' \
>   ac_cv_prog_RPMBUILD="" \
> @@ -44,8 +52,8 @@ MODGNU_CONFIG_GUESS_DIRS = ${WRKSRC}/con
>  WRKCONF = ${WRKSRC}/config
>  
>  USE_GMAKE = Yes
> -MODULES = lang/ocaml
> -BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
> +#MODULES = lang/ocaml
> +#BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
>  LIB_DEPENDS = archivers/bzip2 \
>   devel/gettext,-runtime \
>   devel/libmagic \
> @@ -53,6 +61,7 @@ LIB_DEPENDS = archivers/bzip2 \
>   net/miniupnp/libnatpmp \
>   net/miniupnp/miniupnpc>=1.9 \
>   x11/gnome/librsvg \
> + devel/libglade2 \
>   x11/gtk+2
>  
>  ALL_TARGET = depend all
> @@ -67,6 +76,11 @@ FAKE_FLAGS = OCAML_NATIVE=no
>  NO_TEST = Yes
>  
>  .include <bsd.port.arch.mk>
> +
> +post-extract:
> + ln -s ${FULLDISTDIR}/${OCAML_SRC} ${WRKSRC}/patches
> + ln -s ${FULLDISTDIR}/${LAMLGTK_SRC} ${WRKSRC}/patches
> +
>  pre-patch:
>   @cd ${WRKSRC}; perl -i -pe 's/\r$$//' `find . -type f`
>  
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/net/mldonkey/distinfo,v
> retrieving revision 1.6
> diff -u -p -r1.6 distinfo
> --- distinfo 17 Aug 2017 10:06:12 -0000 1.6
> +++ distinfo 17 Jun 2019 19:07:35 -0000
> @@ -1,2 +1,6 @@
> +SHA256 (lablgtk-2.14.2.tar.gz) = SYGr7avcRiMD80UQQELIivInzNUP0wqb9I/TU6sC0Lo=
>  SHA256 (mldonkey-3.1.6.tar.bz2) = Gza1fAWoPC42PAhb+OgGMIhMbJLs3v/BrV4cOamOBD0=
> +SHA256 (ocaml-3.12.0.tar.gz) = 2WSzheEQwVF8neHGMxR21eejWFzGkra2uJc/Opvn2ks=
> +SIZE (lablgtk-2.14.2.tar.gz) = 779803
>  SIZE (mldonkey-3.1.6.tar.bz2) = 2886916
> +SIZE (ocaml-3.12.0.tar.gz) = 3271024
> Index: patches/patch-config_Makefile_in
> ===================================================================
> RCS file: /cvs/ports/net/mldonkey/patches/patch-config_Makefile_in,v
> retrieving revision 1.6
> diff -u -p -r1.6 patch-config_Makefile_in
> --- patches/patch-config_Makefile_in 4 Mar 2019 12:51:16 -0000 1.6
> +++ patches/patch-config_Makefile_in 17 Jun 2019 19:07:35 -0000
> @@ -2,34 +2,6 @@ $OpenBSD: patch-config_Makefile_in,v 1.6
>  Index: config/Makefile.in
>  --- config/Makefile.in.orig
>  +++ config/Makefile.in
> -@@ -13,6 +13,9 @@ changequote([[, ]])
> -
> - include config/Makefile.config
> -
> -+OCAMLC:=$(OCAMLC) -unsafe-string
> -+OCAMLOPT:=$(OCAMLOPT) -unsafe-string
> -+
> - ifneq ("$(GLIBC_VERSION)" , "")
> -   GLIBC_VERSION_ARCH = "_glibc-"$(GLIBC_VERSION)
> - endif
> -@@ -93,7 +96,7 @@ SRC_FILETP=src/networks/fileTP
> - SUBDIRS=$(EXTLIB) $(CDK) $(BITSTRING) $(LIB) $(RSS) $(XML) $(NET) tools \
> -    $(COMMON) $(DRIVER) $(MP3) src/config/$(OS_FILES)
> -
> --INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4
> -+INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4 -I +num
> -
> - CFLAGS:=$(CFLAGS) $(CONFIG_INCLUDES) $(GTKCFLAGS) $(GD_CFLAGS)
> -
> -@@ -124,7 +127,7 @@ endif
> -
> - #######################################################################
> -
> --LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)"
> -+LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)" -I +num
> -
> - ifeq ("$(OS_FILES2)", "mingw")
> -   LIBS_flags += -cclib "-lws2_32 -lgdi32 -luser32 -ladvapi32 -lwsock32 -limm32 -lshell32 -lole32 resfile.o"
>  @@ -633,6 +636,8 @@ uninstall::
>   rm -f $(BINDIR)/mlnet
>   rm -f $(BINDIR)/mlgui
>
>
> --
> http://gmerlin.de
> OpenPGP: http://gmerlin.de/christopher.pub
> CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1


Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

Stuart Henderson
If people do want to keep this port in the tree, I'd suggest rearranging
things so that the changes are grouped together as much as possible (separate
CONFIGURE_ARGS+= / LIB_DEPENDS+= blocks) to make it more obvious which are the
parts for the compiler change and make it easier to switch back to a system
compiler when upstream updates it.

Really not sure about the value of having early 2000's pirac^W file sharing
software in OpenBSD ports though ...


On 2019/06/17 16:24, Kenneth R Westerback wrote:

> On Mon, Jun 17, 2019 at 09:20:09PM +0200, Christopher Zimmermann wrote:
> > Hi,
> >
> > Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
> > Its build system has the option to build against a private build of
> > OCaml 3.12 and a copy of lablgtk.
> > I adapted the port to use this option and therefore get rid of the
> > dependency on a system wide OCaml installation.
> > Tested to build and start up on amd64.
> > Not tested on bytecode-only archs.
> >
> > Is this the way to go? OK to commit?
> > Is this port still in use?
> >
> > Christopher
>
> I have never used mldonkey, but I have no objection to this approach.
>
> .... Ken
>
> >
> >
> >
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/net/mldonkey/Makefile,v
> > retrieving revision 1.30
> > diff -u -p -r1.30 Makefile
> > --- Makefile 20 May 2019 22:15:19 -0000 1.30
> > +++ Makefile 17 Jun 2019 19:07:35 -0000
> > @@ -21,13 +21,21 @@ WANTLIB += pthread rsvg-2 ${COMPILER_LIB
> >  
> >  COMPILER = base-clang ports-gcc base-gcc
> >  
> > -MASTER_SITES = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
> > +MASTER_SITES0 = https://github.com/ygrek/mldonkey/releases/download/release-${VER:S/./-/g}/
> > +MASTER_SITES1 = http://caml.inria.fr/pub/distrib/ocaml-3.12/
> > +MASTER_SITES2 = http://www.math.nagoya-u.ac.jp/~garrigue/soft/olabl/dist/
> >  
> > +OCAML_SRC = ocaml-3.12.0.tar.gz
> > +LAMLGTK_SRC = lablgtk-2.14.2.tar.gz
> >  EXTRACT_SUFX = .tar.bz2
> > +DISTFILES = ${DISTNAME}${EXTRACT_SUFX}:0 ${OCAML_SRC}:1 ${LAMLGTK_SRC}:2
> > +
> >  
> >  CONFIGURE_STYLE = gnu
> >  CONFIGURE_ARGS += --enable-gui=newgui2 \
> > - --enable-upnp-natpmp
> > + --enable-upnp-natpmp \
> > + --enable-force-ocaml \
> > + --enable-batch
> >  CONFIGURE_ENV += CPPFLAGS='-I${LOCALBASE}/include -I${X11BASE}/include' \
> >   LDFLAGS='${LDFLAGS}' \
> >   ac_cv_prog_RPMBUILD="" \
> > @@ -44,8 +52,8 @@ MODGNU_CONFIG_GUESS_DIRS = ${WRKSRC}/con
> >  WRKCONF = ${WRKSRC}/config
> >  
> >  USE_GMAKE = Yes
> > -MODULES = lang/ocaml
> > -BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
> > +#MODULES = lang/ocaml
> > +#BUILD_DEPENDS = lang/ocaml-camlp4 x11/lablgtk2 math/ocaml-num
> >  LIB_DEPENDS = archivers/bzip2 \
> >   devel/gettext,-runtime \
> >   devel/libmagic \
> > @@ -53,6 +61,7 @@ LIB_DEPENDS = archivers/bzip2 \
> >   net/miniupnp/libnatpmp \
> >   net/miniupnp/miniupnpc>=1.9 \
> >   x11/gnome/librsvg \
> > + devel/libglade2 \
> >   x11/gtk+2
> >  
> >  ALL_TARGET = depend all
> > @@ -67,6 +76,11 @@ FAKE_FLAGS = OCAML_NATIVE=no
> >  NO_TEST = Yes
> >  
> >  .include <bsd.port.arch.mk>
> > +
> > +post-extract:
> > + ln -s ${FULLDISTDIR}/${OCAML_SRC} ${WRKSRC}/patches
> > + ln -s ${FULLDISTDIR}/${LAMLGTK_SRC} ${WRKSRC}/patches
> > +
> >  pre-patch:
> >   @cd ${WRKSRC}; perl -i -pe 's/\r$$//' `find . -type f`
> >  
> > Index: distinfo
> > ===================================================================
> > RCS file: /cvs/ports/net/mldonkey/distinfo,v
> > retrieving revision 1.6
> > diff -u -p -r1.6 distinfo
> > --- distinfo 17 Aug 2017 10:06:12 -0000 1.6
> > +++ distinfo 17 Jun 2019 19:07:35 -0000
> > @@ -1,2 +1,6 @@
> > +SHA256 (lablgtk-2.14.2.tar.gz) = SYGr7avcRiMD80UQQELIivInzNUP0wqb9I/TU6sC0Lo=
> >  SHA256 (mldonkey-3.1.6.tar.bz2) = Gza1fAWoPC42PAhb+OgGMIhMbJLs3v/BrV4cOamOBD0=
> > +SHA256 (ocaml-3.12.0.tar.gz) = 2WSzheEQwVF8neHGMxR21eejWFzGkra2uJc/Opvn2ks=
> > +SIZE (lablgtk-2.14.2.tar.gz) = 779803
> >  SIZE (mldonkey-3.1.6.tar.bz2) = 2886916
> > +SIZE (ocaml-3.12.0.tar.gz) = 3271024
> > Index: patches/patch-config_Makefile_in
> > ===================================================================
> > RCS file: /cvs/ports/net/mldonkey/patches/patch-config_Makefile_in,v
> > retrieving revision 1.6
> > diff -u -p -r1.6 patch-config_Makefile_in
> > --- patches/patch-config_Makefile_in 4 Mar 2019 12:51:16 -0000 1.6
> > +++ patches/patch-config_Makefile_in 17 Jun 2019 19:07:35 -0000
> > @@ -2,34 +2,6 @@ $OpenBSD: patch-config_Makefile_in,v 1.6
> >  Index: config/Makefile.in
> >  --- config/Makefile.in.orig
> >  +++ config/Makefile.in
> > -@@ -13,6 +13,9 @@ changequote([[, ]])
> > -
> > - include config/Makefile.config
> > -
> > -+OCAMLC:=$(OCAMLC) -unsafe-string
> > -+OCAMLOPT:=$(OCAMLOPT) -unsafe-string
> > -+
> > - ifneq ("$(GLIBC_VERSION)" , "")
> > -   GLIBC_VERSION_ARCH = "_glibc-"$(GLIBC_VERSION)
> > - endif
> > -@@ -93,7 +96,7 @@ SRC_FILETP=src/networks/fileTP
> > - SUBDIRS=$(EXTLIB) $(CDK) $(BITSTRING) $(LIB) $(RSS) $(XML) $(NET) tools \
> > -    $(COMMON) $(DRIVER) $(MP3) src/config/$(OS_FILES)
> > -
> > --INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4
> > -+INCLUDES += $(foreach file, $(SUBDIRS), -I $(file)) -I +camlp4 -I +num
> > -
> > - CFLAGS:=$(CFLAGS) $(CONFIG_INCLUDES) $(GTKCFLAGS) $(GD_CFLAGS)
> > -
> > -@@ -124,7 +127,7 @@ endif
> > -
> > - #######################################################################
> > -
> > --LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)"
> > -+LIBS_flags += -ccopt "$(LDFLAGS) $(CPPFLAGS)" -cclib "$(LIBS)" -I +num
> > -
> > - ifeq ("$(OS_FILES2)", "mingw")
> > -   LIBS_flags += -cclib "-lws2_32 -lgdi32 -luser32 -ladvapi32 -lwsock32 -limm32 -lshell32 -lole32 resfile.o"
> >  @@ -633,6 +636,8 @@ uninstall::
> >   rm -f $(BINDIR)/mlnet
> >   rm -f $(BINDIR)/mlgui
> >
> >
> > --
> > http://gmerlin.de
> > OpenPGP: http://gmerlin.de/christopher.pub
> > CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1
>
>

Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

Anil Madhavapeddy-2
In reply to this post by Stuart Henderson
On 17 Jun 2019, at 20:35, Stuart Henderson <[hidden email]> wrote:

>
> On 2019/06/17 21:20, Christopher Zimmermann wrote:
>> Hi,
>>
>> Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
>> Its build system has the option to build against a private build of
>> OCaml 3.12 and a copy of lablgtk.
>> I adapted the port to use this option and therefore get rid of the
>> dependency on a system wide OCaml installation.
>> Tested to build and start up on amd64.
>> Not tested on bytecode-only archs.
>>
>> Is this the way to go? OK to commit?
>> Is this port still in use?
>>
>> Christopher
>
> My vote would be for rm..

I have changed my mind after thinking about it a bit.  There have been
_so_ many bugfixes in OCaml since 3.12 that it's probably unsafe to
ship a 3.12 runtime with a modern release of OpenBSD.

I'd vote for disabling the port (in the hope of a 4.08.0 future port) rather
than regressing to an OCaml 3.12.1 build with those potential unsafe
bugs baked into a statically linked binary.

Anil

Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

kwesterback


> On Jun 17, 2019, at 5:18 PM, Anil Madhavapeddy <[hidden email]> wrote:
>
>> On 17 Jun 2019, at 20:35, Stuart Henderson <[hidden email]> wrote:
>>
>>> On 2019/06/17 21:20, Christopher Zimmermann wrote:
>>> Hi,
>>>
>>> Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
>>> Its build system has the option to build against a private build of
>>> OCaml 3.12 and a copy of lablgtk.
>>> I adapted the port to use this option and therefore get rid of the
>>> dependency on a system wide OCaml installation.
>>> Tested to build and start up on amd64.
>>> Not tested on bytecode-only archs.
>>>
>>> Is this the way to go? OK to commit?
>>> Is this port still in use?
>>>
>>> Christopher
>>
>> My vote would be for rm..
>
> I have changed my mind after thinking about it a bit.  There have been
> _so_ many bugfixes in OCaml since 3.12 that it's probably unsafe to
> ship a 3.12 runtime with a modern release of OpenBSD.
>
> I'd vote for disabling the port (in the hope of a 4.08.0 future port) rather
> than regressing to an OCaml 3.12.1 build with those potential unsafe
> bugs baked into a statically linked binary.
>
> Anil
>

No objection to rm from me. :-)

.... Ken


Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

Christopher Zimmermann-2
In reply to this post by Stuart Henderson
On Mon, 17 Jun 2019 21:59:57 +0100
Stuart Henderson <[hidden email]> wrote:

> If people do want to keep this port in the tree, I'd suggest
> rearranging things so that the changes are grouped together as much
> as possible (separate CONFIGURE_ARGS+= / LIB_DEPENDS+= blocks) to
> make it more obvious which are the parts for the compiler change and
> make it easier to switch back to a system compiler when upstream
> updates it.
>
> Really not sure about the value of having early 2000's pirac^W file
> sharing software in OpenBSD ports though ...

I would be ok with removing it, too. Anyone else we should ask before
killing it?

--
http://gmerlin.de
OpenPGP: http://gmerlin.de/christopher.pub
CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1

attachment0 (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

ygrek
In reply to this post by Anil Madhavapeddy-2
On Mon, 17 Jun 2019 20:34:41 +0100
Anil Madhavapeddy <[hidden email]> wrote:

> I think this approach is fine for this particular package, since upstream lags in recent times.
>
> The opam package for mldonkey is on ocaml<4.06, but I'm CCing the current maintainer Ygrek in case there is a 4.08 port in the offing.

4.08 support depends on camlp4 which is not yet available.
I am maintaining git repository at github.com/ygrek/mldonkey - it builds fine with 4.07

> > Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
> > Its build system has the option to build against a private build of
> > OCaml 3.12 and a copy of lablgtk.
> > I adapted the port to use this option and therefore get rid of the
> > dependency on a system wide OCaml installation.
> > Tested to build and start up on amd64.
> > Not tested on bytecode-only archs.
> >
> > Is this the way to go? OK to commit?
> > Is this port still in use?

I don't think this is a good way forward if that package is used on non-x86 archs, there were many bugs there in older ocaml versions.

--

Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

Jeremie Courreges-Anglas-2
On Tue, Jun 18 2019, ygrek <[hidden email]> wrote:
> On Mon, 17 Jun 2019 20:34:41 +0100
> Anil Madhavapeddy <[hidden email]> wrote:
>
>> I think this approach is fine for this particular package, since upstream lags in recent times.
>>
>> The opam package for mldonkey is on ocaml<4.06, but I'm CCing the current maintainer Ygrek in case there is a 4.08 port in the offing.
>
> 4.08 support depends on camlp4 which is not yet available.
> I am maintaining git repository at github.com/ygrek/mldonkey - it builds fine with 4.07

ygrek: I guess you're waiting for diml (https://github.com/diml) to
chime in.

ygrek, chrisz: are there other known ocaml-4.08 problems in mldonkey,
except for a compatible camlp4 release?

>> > Mldonkey in difficult to adapt to the new 4.08.0 release of OCaml.
>> > Its build system has the option to build against a private build of
>> > OCaml 3.12 and a copy of lablgtk.
>> > I adapted the port to use this option and therefore get rid of the
>> > dependency on a system wide OCaml installation.
>> > Tested to build and start up on amd64.
>> > Not tested on bytecode-only archs.
>> >
>> > Is this the way to go? OK to commit?
>> > Is this port still in use?
>
> I don't think this is a good way forward if that package is used on non-x86 archs, there were many bugs there in older ocaml versions.

Seconded.

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

net/mldonkey still in use?

Christopher Zimmermann-2
In reply to this post by ygrek
On Tue, 18 Jun 2019 14:17:49 -0400
ygrek <[hidden email]> wrote:

> On Mon, 17 Jun 2019 20:34:41 +0100
> Anil Madhavapeddy <[hidden email]> wrote:
>
> > I think this approach is fine for this particular package, since
> > upstream lags in recent times.
> >
> > The opam package for mldonkey is on ocaml<4.06, but I'm CCing the
> > current maintainer Ygrek in case there is a 4.08 port in the
> > offing.  
>
> 4.08 support depends on camlp4 which is not yet available.
> I am maintaining git repository at github.com/ygrek/mldonkey - it
> builds fine with 4.07

> > > Is this the way to go? OK to commit?
> > > Is this port still in use?  
>
> I don't think this is a good way forward if that package is used on
> non-x86 archs, there were many bugs there in older ocaml versions.


Ok. So mldonkey is the only port still using deprecated camlp4.
I already adapted camlp5 to OCaml 4.08, because coq needs camlp5.
But I'm reluctant to do the same for deprecated camlp4.

* sthen@, krw@ already consented with removal of mldonkey
* anil@ proposed to disable the port (and therefore camlp4, too)
  until camlp4 catches up.

For the time being I would like to choose the second option and disable
mldonkey and camlp4, but only enable them again on request.
Then when no one complains and they have rotten long enough we can
dispose of them.

OK?


Christopher



--
http://gmerlin.de
OpenPGP: http://gmerlin.de/christopher.pub
CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1

attachment0 (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: mldonkey: use custom build of OCaml 3.12

Jeremie Courreges-Anglas-2
In reply to this post by Christopher Zimmermann-2
On Mon, Jun 17 2019, Christopher Zimmermann <[hidden email]> wrote:

> On Mon, 17 Jun 2019 21:59:57 +0100
> Stuart Henderson <[hidden email]> wrote:
>
>> If people do want to keep this port in the tree, I'd suggest
>> rearranging things so that the changes are grouped together as much
>> as possible (separate CONFIGURE_ARGS+= / LIB_DEPENDS+= blocks) to
>> make it more obvious which are the parts for the compiler change and
>> make it easier to switch back to a system compiler when upstream
>> updates it.
>>
>> Really not sure about the value of having early 2000's pirac^W file
>> sharing software in OpenBSD ports though ...

I see value in having (2 or more) ports to access the eDonkey network,
AFAIK the other solution is net/amule.

> I would be ok with removing it, too. Anyone else we should ask before
> killing it?

I'm not ok with removing it "just like that".

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: net/mldonkey still in use?

Daniel Dickman
In reply to this post by Christopher Zimmermann-2


> On Jun 19, 2019, at 10:48 AM, Christopher Zimmermann <[hidden email]> wrote:
>
> On Tue, 18 Jun 2019 14:17:49 -0400
> ygrek <[hidden email]> wrote:
>
>> On Mon, 17 Jun 2019 20:34:41 +0100
>> Anil Madhavapeddy <[hidden email]> wrote:
>>
>>> I think this approach is fine for this particular package, since
>>> upstream lags in recent times.
>>>
>>> The opam package for mldonkey is on ocaml<4.06, but I'm CCing the
>>> current maintainer Ygrek in case there is a 4.08 port in the
>>> offing.  
>>
>> 4.08 support depends on camlp4 which is not yet available.
>> I am maintaining git repository at github.com/ygrek/mldonkey - it
>> builds fine with 4.07
>
>>>> Is this the way to go? OK to commit?
>>>> Is this port still in use?  
>>
>> I don't think this is a good way forward if that package is used on
>> non-x86 archs, there were many bugs there in older ocaml versions.
>
>
> Ok. So mldonkey is the only port still using deprecated camlp4.
> I already adapted camlp5 to OCaml 4.08, because coq needs camlp5.
> But I'm reluctant to do the same for deprecated camlp4.
>
> * sthen@, krw@ already consented with removal of mldonkey
> * anil@ proposed to disable the port (and therefore camlp4, too)
>  until camlp4 catches up.
>
> For the time being I would like to choose the second option and disable
> mldonkey and camlp4, but only enable them again on request.
> Then when no one complains and they have rotten long enough we can
> dispose of them.
>
> OK?

Perhaps just mark camlp4 as BROKEN (which will effectively disable mldonkey) and then move on with the update of ocaml... ok daniel@ if you want to do that.

If the situation changes, it can be repaired in tree.

I would like to see ocaml 4.08 in the tree and don’t think these should hold things back. Thanks for leading the charge!

>
>
> Christopher
>
>
>
> --
> http://gmerlin.de
> OpenPGP: http://gmerlin.de/christopher.pub
> CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1

Reply | Threaded
Open this post in threaded view
|

Re: net/mldonkey still in use?

Jeremie Courreges-Anglas-2
In reply to this post by Christopher Zimmermann-2
On Wed, Jun 19 2019, Christopher Zimmermann <[hidden email]> wrote:

> On Tue, 18 Jun 2019 14:17:49 -0400
> ygrek <[hidden email]> wrote:
>
>> On Mon, 17 Jun 2019 20:34:41 +0100
>> Anil Madhavapeddy <[hidden email]> wrote:
>>
>> > I think this approach is fine for this particular package, since
>> > upstream lags in recent times.
>> >
>> > The opam package for mldonkey is on ocaml<4.06, but I'm CCing the
>> > current maintainer Ygrek in case there is a 4.08 port in the
>> > offing.  
>>
>> 4.08 support depends on camlp4 which is not yet available.
>> I am maintaining git repository at github.com/ygrek/mldonkey - it
>> builds fine with 4.07
>
>> > > Is this the way to go? OK to commit?
>> > > Is this port still in use?  
>>
>> I don't think this is a good way forward if that package is used on
>> non-x86 archs, there were many bugs there in older ocaml versions.
>
>
> Ok. So mldonkey is the only port still using deprecated camlp4.
> I already adapted camlp5 to OCaml 4.08, because coq needs camlp5.
> But I'm reluctant to do the same for deprecated camlp4.
>
> * sthen@, krw@ already consented with removal of mldonkey
> * anil@ proposed to disable the port (and therefore camlp4, too)
>   until camlp4 catches up.
>
> For the time being I would like to choose the second option and disable
> mldonkey and camlp4, but only enable them again on request.
> Then when no one complains and they have rotten long enough we can
> dispose of them.
>
> OK?
ok jca@ to mark lang/ocaml-camlp4 as BROKEN with ocaml-4.08, which
should be sufficient for now.

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: net/mldonkey still in use?

Jeremie Courreges-Anglas-2
On Wed, Jun 19 2019, Jeremie Courreges-Anglas <[hidden email]> wrote:

> On Wed, Jun 19 2019, Christopher Zimmermann <[hidden email]> wrote:
>> On Tue, 18 Jun 2019 14:17:49 -0400
>> ygrek <[hidden email]> wrote:
>>
>>> On Mon, 17 Jun 2019 20:34:41 +0100
>>> Anil Madhavapeddy <[hidden email]> wrote:
>>>
>>> > I think this approach is fine for this particular package, since
>>> > upstream lags in recent times.
>>> >
>>> > The opam package for mldonkey is on ocaml<4.06, but I'm CCing the
>>> > current maintainer Ygrek in case there is a 4.08 port in the
>>> > offing.  
>>>
>>> 4.08 support depends on camlp4 which is not yet available.
>>> I am maintaining git repository at github.com/ygrek/mldonkey - it
>>> builds fine with 4.07
>>
>>> > > Is this the way to go? OK to commit?
>>> > > Is this port still in use?  
>>>
>>> I don't think this is a good way forward if that package is used on
>>> non-x86 archs, there were many bugs there in older ocaml versions.
>>
>>
>> Ok. So mldonkey is the only port still using deprecated camlp4.
>> I already adapted camlp5 to OCaml 4.08, because coq needs camlp5.
>> But I'm reluctant to do the same for deprecated camlp4.
>>
>> * sthen@, krw@ already consented with removal of mldonkey
>> * anil@ proposed to disable the port (and therefore camlp4, too)
>>   until camlp4 catches up.
>>
>> For the time being I would like to choose the second option and disable
>> mldonkey and camlp4, but only enable them again on request.
>> Then when no one complains and they have rotten long enough we can
>> dispose of them.
>>
>> OK?
>
> ok jca@ to mark lang/ocaml-camlp4 as BROKEN with ocaml-4.08, which
> should be sufficient for now.

And just to make things clear: please don't mark it BROKEN before the
ocaml-4.08 update is committed.

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: net/mldonkey still in use?

kwesterback
In reply to this post by Christopher Zimmermann-2


> On Jun 19, 2019, at 10:48 AM, Christopher Zimmermann <[hidden email]> wrote:
>
> On Tue, 18 Jun 2019 14:17:49 -0400
> ygrek <[hidden email]> wrote:
>
>> On Mon, 17 Jun 2019 20:34:41 +0100
>> Anil Madhavapeddy <[hidden email]> wrote:
>>
>>> I think this approach is fine for this particular package, since
>>> upstream lags in recent times.
>>>
>>> The opam package for mldonkey is on ocaml<4.06, but I'm CCing the
>>> current maintainer Ygrek in case there is a 4.08 port in the
>>> offing.  
>>
>> 4.08 support depends on camlp4 which is not yet available.
>> I am maintaining git repository at github.com/ygrek/mldonkey - it
>> builds fine with 4.07
>
>>>> Is this the way to go? OK to commit?
>>>> Is this port still in use?  
>>
>> I don't think this is a good way forward if that package is used on
>> non-x86 archs, there were many bugs there in older ocaml versions.
>
>
> Ok. So mldonkey is the only port still using deprecated camlp4.
> I already adapted camlp5 to OCaml 4.08, because coq needs camlp5.
> But I'm reluctant to do the same for deprecated camlp4.
>
> * sthen@, krw@ already consented with removal of mldonkey
> * anil@ proposed to disable the port (and therefore camlp4, too)
>  until camlp4 catches up.
>
> For the time being I would like to choose the second option and disable
> mldonkey and camlp4, but only enable them again on request.
> Then when no one complains and they have rotten long enough we can
> dispose of them.
>
> OK?
>
>
> Christopher
>
>
>
> --
> http://gmerlin.de
> OpenPGP: http://gmerlin.de/christopher.pub
> CB07 DA40 B0B6 571D 35E2  0DEF 87E2 92A7 13E5 DEE1

I don't see much difference between disabling and moving to the attic, but this two step approach is ok with me. Dunno what quirks magic (if any) needs to be done for disabling a port.

.... Ken

Reply | Threaded
Open this post in threaded view
|

Re: net/mldonkey still in use?

Jeremie Courreges-Anglas-2
On Wed, Jun 19 2019, [hidden email] wrote:

[...]

> I don't see much difference between disabling and moving to the attic,
> but this two step approach is ok with me.

If the current camlp4 code is compatible with ocaml-4.08 then the fix
would be a two-lines patch for its configure script and removing the
BROKEN line.  Compare that to useless churn due to the unhooking/removal
of two ports, and quirks glue to mark the packages as obsolete.  And
then the people actually willing to fix camlp4/mldonkey would have to
undo all of this.

> Dunno what quirks magic (if any) needs to be done for disabling a port.

No need for quirks magic when you mark a port BROKEN.

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE