missing arg in esample renice man command ?

[Sven F.]

Line 120 , in renice.8

https://github.com/openbsd/src/blob/master/usr.bin/renice/renice.8#L120

# renice -n +1 987 -u daemon root -p 32

should be

# renice -n +1 -g 987 -u daemon root -p 32 ?


--- usr.bin/renice/renice.8.orig       2021-04-06 13:41:09.272347600 -0400
+++ usr.bin/renice/renice.8    2021-04-06 13:41:45.089202200 -0400
@@ -117,7 +117,7 @@
 changes the priority of process IDs 987 and 32,
 and all processes owned by users daemon and root:
 .Bd -literal -offset indent
-# renice -n +1 987 -u daemon root -p 32
+# renice -n +1 -g 987 -u daemon root -p 32
 .Ed
 .Sh SEE ALSO
 .Xr nice 1 ,


--
--
---------------------------------------------------------------------------------------------------------------------
Knowing is not enough; we must apply. Willing is not enough; we must do

[Jason McIntyre-2]

On Tue, Apr 06, 2021 at 01:42:51PM -0400, Sven F. wrote:

> Line 120 , in renice.8
>
> https://github.com/openbsd/src/blob/master/usr.bin/renice/renice.8#L120
>
> # renice -n +1 987 -u daemon root -p 32
>
> should be
>
> # renice -n +1 -g 987 -u daemon root -p 32 ?
>
>
> --- usr.bin/renice/renice.8.orig       2021-04-06 13:41:09.272347600 -0400
> +++ usr.bin/renice/renice.8    2021-04-06 13:41:45.089202200 -0400
> @@ -117,7 +117,7 @@
>  changes the priority of process IDs 987 and 32,
>  and all processes owned by users daemon and root:
>  .Bd -literal -offset indent
> -# renice -n +1 987 -u daemon root -p 32
> +# renice -n +1 -g 987 -u daemon root -p 32
>  .Ed
>  .Sh SEE ALSO
>  .Xr nice 1 ,
>

hi.

i don;t think the example is wrong. it says it alters the priority of
process IDs 987 and 32. and the man page notes:

         If none of the -gpu options are specified, the default is
         to select by process ID.

having said that, i do think the example is a really weird way to
specify IDs 987 and 32 and users daemon and root. and since it does give
both -u and -p, it might not be entirely obvious to link it back to the
text sating that -p is the default. it would be saner to do:

        # renice -n +1 -p 987 32 -u daemon root
or
        # renice -n +1 987 32 -u daemon root

(not tested!)

both netbsd and freebsd have the same example that we currently have, so
they're probably pretty old. so not sure if it's worth changing. or leaving
as an exercise to the reader...

jmc

[Sven F.]

On Tue, Apr 6, 2021 at 2:29 PM Jason McIntyre <[hidden email]> wrote:

>
> On Tue, Apr 06, 2021 at 01:42:51PM -0400, Sven F. wrote:
> > Line 120 , in renice.8
> >
> > https://github.com/openbsd/src/blob/master/usr.bin/renice/renice.8#L120
> >
> > # renice -n +1 987 -u daemon root -p 32
> >
> > should be
> >
> > # renice -n +1 -g 987 -u daemon root -p 32 ?
> >
> >
> > --- usr.bin/renice/renice.8.orig       2021-04-06 13:41:09.272347600 -0400
> > +++ usr.bin/renice/renice.8    2021-04-06 13:41:45.089202200 -0400
> > @@ -117,7 +117,7 @@
> >  changes the priority of process IDs 987 and 32,
> >  and all processes owned by users daemon and root:
> >  .Bd -literal -offset indent
> > -# renice -n +1 987 -u daemon root -p 32
> > +# renice -n +1 -g 987 -u daemon root -p 32
> >  .Ed
> >  .Sh SEE ALSO
> >  .Xr nice 1 ,
> >
>
> hi.
>
> i don;t think the example is wrong. it says it alters the priority of
> process IDs 987 and 32. and the man page notes:
>
>          If none of the -gpu options are specified, the default is
>          to select by process ID.
>
> having said that, i do think the example is a really weird way to
> specify IDs 987 and 32 and users daemon and root. and since it does give
> both -u and -p, it might not be entirely obvious to link it back to the
> text sating that -p is the default. it would be saner to do:
>
>         # renice -n +1 -p 987 32 -u daemon root
> or
>         # renice -n +1 987 32 -u daemon root
>
> (not tested!)
>
> both netbsd and freebsd have the same example that we currently have, so
> they're probably pretty old. so not sure if it's worth changing. or leaving
> as an exercise to the reader...
>
> jmc
>

example is fine, i got confused doing more than one thing at a time
bit confusing the 987 is not after the option like in SYNOPSIS

On a helping / clarity point of vue,changing
`The following example changes the priority of process`
by something like
`The following raise the priority of process to allocate more
resources to it by 1 `
may be more helping to someone in a hurry


--
--
---------------------------------------------------------------------------------------------------------------------
Knowing is not enough; we must apply. Willing is not enough; we must do

[Jason McIntyre-2]

On Tue, Apr 06, 2021 at 02:41:28PM -0400, Sven F. wrote:

> On Tue, Apr 6, 2021 at 2:29 PM Jason McIntyre <[hidden email]> wrote:
> >
> > On Tue, Apr 06, 2021 at 01:42:51PM -0400, Sven F. wrote:
> > > Line 120 , in renice.8
> > >
> > > https://github.com/openbsd/src/blob/master/usr.bin/renice/renice.8#L120
> > >
> > > # renice -n +1 987 -u daemon root -p 32
> > >
> > > should be
> > >
> > > # renice -n +1 -g 987 -u daemon root -p 32 ?
> > >
> > >
> > > --- usr.bin/renice/renice.8.orig       2021-04-06 13:41:09.272347600 -0400
> > > +++ usr.bin/renice/renice.8    2021-04-06 13:41:45.089202200 -0400
> > > @@ -117,7 +117,7 @@
> > >  changes the priority of process IDs 987 and 32,
> > >  and all processes owned by users daemon and root:
> > >  .Bd -literal -offset indent
> > > -# renice -n +1 987 -u daemon root -p 32
> > > +# renice -n +1 -g 987 -u daemon root -p 32
> > >  .Ed
> > >  .Sh SEE ALSO
> > >  .Xr nice 1 ,
> > >
> >
> > hi.
> >
> > i don;t think the example is wrong. it says it alters the priority of
> > process IDs 987 and 32. and the man page notes:
> >
> >          If none of the -gpu options are specified, the default is
> >          to select by process ID.
> >
> > having said that, i do think the example is a really weird way to
> > specify IDs 987 and 32 and users daemon and root. and since it does give
> > both -u and -p, it might not be entirely obvious to link it back to the
> > text sating that -p is the default. it would be saner to do:
> >
> >         # renice -n +1 -p 987 32 -u daemon root
> > or
> >         # renice -n +1 987 32 -u daemon root
> >
> > (not tested!)
> >
> > both netbsd and freebsd have the same example that we currently have, so
> > they're probably pretty old. so not sure if it's worth changing. or leaving
> > as an exercise to the reader...
> >
> > jmc
> >
>
> example is fine, i got confused doing more than one thing at a time
> bit confusing the 987 is not after the option like in SYNOPSIS
>
> On a helping / clarity point of vue,changing
> `The following example changes the priority of process`
> by something like
> `The following raise the priority of process to allocate more
> resources to it by 1 `
> may be more helping to someone in a hurry
>

i think it's fine as it is.
jmc