mg docs ownership

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

mg docs ownership

Martin Natano
We should be explicit about owner/group when using install, so this also
works correctly with noperm. Ok?

natano


Index: usr.bin/mg/Makefile
===================================================================
RCS file: /cvs/src/usr.bin/mg/Makefile,v
retrieving revision 1.31
diff -u -p -r1.31 Makefile
--- usr.bin/mg/Makefile 29 Sep 2015 03:50:58 -0000 1.31
+++ usr.bin/mg/Makefile 10 Sep 2016 17:45:11 -0000
@@ -24,8 +24,8 @@ SRCS= autoexec.c basic.c bell.c buffer.c
 SRCS+= cmode.c cscope.c dired.c grep.c tags.c theo.c
 
 afterinstall:
- ${INSTALL} -d ${DESTDIR}${DOCDIR}/mg
- ${INSTALL} -m ${DOCMODE} -c ${.CURDIR}/tutorial \
- ${DESTDIR}${DOCDIR}/mg
+ ${INSTALL} -d -o root -g wheel ${DESTDIR}${DOCDIR}/mg
+ ${INSTALL} ${INSTALL_COPY} -o root -g wheel -m ${DOCMODE} \
+    ${.CURDIR}/tutorial ${DESTDIR}${DOCDIR}/mg
 
 .include <bsd.prog.mk>

Reply | Threaded
Open this post in threaded view
|

Re: mg docs ownership

Florian Obser-2
Maybe we should just not install it? Mark?

On Sat, Sep 10, 2016 at 07:47:30PM +0200, Martin Natano wrote:

> We should be explicit about owner/group when using install, so this also
> works correctly with noperm. Ok?
>
> natano
>
>
> Index: usr.bin/mg/Makefile
> ===================================================================
> RCS file: /cvs/src/usr.bin/mg/Makefile,v
> retrieving revision 1.31
> diff -u -p -r1.31 Makefile
> --- usr.bin/mg/Makefile 29 Sep 2015 03:50:58 -0000 1.31
> +++ usr.bin/mg/Makefile 10 Sep 2016 17:45:11 -0000
> @@ -24,8 +24,8 @@ SRCS= autoexec.c basic.c bell.c buffer.c
>  SRCS+= cmode.c cscope.c dired.c grep.c tags.c theo.c
>  
>  afterinstall:
> - ${INSTALL} -d ${DESTDIR}${DOCDIR}/mg
> - ${INSTALL} -m ${DOCMODE} -c ${.CURDIR}/tutorial \
> - ${DESTDIR}${DOCDIR}/mg
> + ${INSTALL} -d -o root -g wheel ${DESTDIR}${DOCDIR}/mg
> + ${INSTALL} ${INSTALL_COPY} -o root -g wheel -m ${DOCMODE} \
> +    ${.CURDIR}/tutorial ${DESTDIR}${DOCDIR}/mg
>  
>  .include <bsd.prog.mk>
>

--
I'm not entirely sure you are real.

Reply | Threaded
Open this post in threaded view
|

Re: mg docs ownership

Mark Lumsden-2
In reply to this post by Martin Natano
> Maybe we should just not install it? Mark?

A couple of years ago when the tutorial started being installed there
were no dissenting voices, so unless there are objections, I'd carry
on doing that. And Martin's diff makes sense I think.

Mark

Reply | Threaded
Open this post in threaded view
|

Re: mg docs ownership

Florian Obser-2
On Sun, Sep 11, 2016 at 12:15:28PM +0000, Mark Lumsden wrote:
> > Maybe we should just not install it? Mark?
>
> A couple of years ago when the tutorial started being installed there
> were no dissenting voices, so unless there are objections, I'd carry
> on doing that. And Martin's diff makes sense I think.
>

yes, OK florian@

I was a bit surprised that we have that file. I don't want to bikeshed
this, Martin's work is much more important.

> Mark

--
I'm not entirely sure you are real.