make update-plist with @comment unwanted-file broken

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

make update-plist with @comment unwanted-file broken

Alexander Bluhm
Hi,

It seems that make update-plist with @comment unwanted-file does
not work as expected.  When updating p5-Devel-NYTProf I got this
error:

make-plist: comment "${P5ARCH}/Devel/benchmark.pl" position in pkg/PLIST guessed

After that, benchmark.pl is in the PLIST together with @comment
benchmark.pl.

+@comment ${P5ARCH}/Devel/benchmark.pl
...
-@comment ${P5ARCH}/Devel/benchmark.pl
+${P5ARCH}/Devel/benchmark.pl

Somewhere in ports/infrastructure/bin/make-plist ${P5ARCH} gets not
substituted properly.  The regression was introduced in
src/usr.sbin/pkg_add/OpenBSD/Subst.pm:

revision 1.15
date: 2011/11/13 15:41:57;  author: nigel;  state: Exp;  lines: +10 -6
The pkg_subst / SUBST_CMD has caused issues for some ports where
the $\ in files was replaced by $. Now only removes the \
in $\{[A-Za-z_]

Without this change make update-plist works as expected.

bluhm