install.sub: Typofixes in comments

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

install.sub: Typofixes in comments

Klemens Nanni-2
OK?

Index: install.sub
===================================================================
RCS file: /cvs/src/distrib/miniroot/install.sub,v
retrieving revision 1.1136
diff -u -p -r1.1136 install.sub
--- install.sub 6 Aug 2019 10:07:45 -0000 1.1136
+++ install.sub 11 Aug 2019 11:20:02 -0000
@@ -1506,9 +1506,9 @@ install_files() {
  # Fetch sets from local sources (disk, cdrom, nfs) as root.
  [[ $_src == file://* ]] && _srclocal=true _unpriv=
 
- # Based on the file list in $_files, create two list for select_sets().
+ # Based on the file list in $_files, create two lists for select_sets().
  # _sets:     the list of files the user can select from
- # _get_sets: the list of files that are shown as pre-selectd
+ # _get_sets: the list of files that are shown as pre-selected
  #
  # Sets will be installed in the order given in ALLSETS to ensure proper
  # installation.  So, to minimize user confusion display the sets in the
@@ -1592,7 +1592,7 @@ install_files() {
  ! $_unpriv ftp -D "$_t" -Vmo - "$_src/SHA256.sig" >"$_cfile.sig" &&
  _issue="Cannot fetch SHA256.sig" && break
 
- # The bsd.rd only download/verify/install assumes that the sets
+ # The bsd.rd only download/verify/install assumes the sets
  # location of the next release. So use the right signature file.
  $UPGRADE_BSDRD &&
  PUB_KEY=/mnt/etc/signify/openbsd-$((VERSION + 1))-base.pub

Reply | Threaded
Open this post in threaded view
|

Re: install.sub: Typofixes in comments

Pablo Méndez Hernández
Hi Klemens:

Minimal suggestion inline:

On Sun, Aug 11, 2019, 13:27 Klemens Nanni <[hidden email]> wrote:

> OK?
>
> Index: install.sub
> ===================================================================
> RCS file: /cvs/src/distrib/miniroot/install.sub,v
> retrieving revision 1.1136
> diff -u -p -r1.1136 install.sub
> --- install.sub 6 Aug 2019 10:07:45 -0000       1.1136
> +++ install.sub 11 Aug 2019 11:20:02 -0000
> @@ -1506,9 +1506,9 @@ install_files() {
>         # Fetch sets from local sources (disk, cdrom, nfs) as root.
>         [[ $_src == file://* ]] && _srclocal=true _unpriv=
>
> -       # Based on the file list in $_files, create two list for
> select_sets().
> +       # Based on the file list in $_files, create two lists for
> select_sets().
>         # _sets:     the list of files the user can select from
> -       # _get_sets: the list of files that are shown as pre-selectd
> +       # _get_sets: the list of files that are shown as pre-selected
>

Maybe add an ending-sentence period there?

        #

>         # Sets will be installed in the order given in ALLSETS to ensure
> proper
>         # installation.  So, to minimize user confusion display the sets
> in the
> @@ -1592,7 +1592,7 @@ install_files() {
>                 ! $_unpriv ftp -D "$_t" -Vmo - "$_src/SHA256.sig"
> >"$_cfile.sig" &&
>                         _issue="Cannot fetch SHA256.sig" && break
>
> -               # The bsd.rd only download/verify/install assumes that the
> sets
> +               # The bsd.rd only download/verify/install assumes the sets
>                 # location of the next release. So use the right signature
> file.
>                 $UPGRADE_BSDRD &&
>                         PUB_KEY=/mnt/etc/signify/openbsd-$((VERSION +
> 1))-base.pub
>
>
Reply | Threaded
Open this post in threaded view
|

Re: install.sub: Typofixes in comments

Stuart Henderson
In reply to this post by Klemens Nanni-2
On 2019/08/11 13:23, Klemens Nanni wrote:

> OK?
>
> Index: install.sub
> ===================================================================
> RCS file: /cvs/src/distrib/miniroot/install.sub,v
> retrieving revision 1.1136
> diff -u -p -r1.1136 install.sub
> --- install.sub 6 Aug 2019 10:07:45 -0000 1.1136
> +++ install.sub 11 Aug 2019 11:20:02 -0000
> @@ -1506,9 +1506,9 @@ install_files() {
>   # Fetch sets from local sources (disk, cdrom, nfs) as root.
>   [[ $_src == file://* ]] && _srclocal=true _unpriv=
>  
> - # Based on the file list in $_files, create two list for select_sets().
> + # Based on the file list in $_files, create two lists for select_sets().
>   # _sets:     the list of files the user can select from
> - # _get_sets: the list of files that are shown as pre-selectd
> + # _get_sets: the list of files that are shown as pre-selected
>   #
>   # Sets will be installed in the order given in ALLSETS to ensure proper
>   # installation.  So, to minimize user confusion display the sets in the

ok

> @@ -1592,7 +1592,7 @@ install_files() {
>   ! $_unpriv ftp -D "$_t" -Vmo - "$_src/SHA256.sig" >"$_cfile.sig" &&
>   _issue="Cannot fetch SHA256.sig" && break
>  
> - # The bsd.rd only download/verify/install assumes that the sets
> + # The bsd.rd only download/verify/install assumes the sets
>   # location of the next release. So use the right signature file.
>   $UPGRADE_BSDRD &&
>   PUB_KEY=/mnt/etc/signify/openbsd-$((VERSION + 1))-base.pub
>

this took me a few attempts to parse. s/bsd.rd only/bsd.rd-only/ maybe?

Reply | Threaded
Open this post in threaded view
|

Re: install.sub: Typofixes in comments

Klemens Nanni-2
In reply to this post by Pablo Méndez Hernández
On Sun, Aug 11, 2019 at 01:51:25PM +0200, Pablo Méndez Hernández wrote:

> > @@ -1506,9 +1506,9 @@ install_files() {
> >         # Fetch sets from local sources (disk, cdrom, nfs) as root.
> >         [[ $_src == file://* ]] && _srclocal=true _unpriv=
> >
> > -       # Based on the file list in $_files, create two list for
> > select_sets().
> > +       # Based on the file list in $_files, create two lists for
> > select_sets().
> >         # _sets:     the list of files the user can select from
> > -       # _get_sets: the list of files that are shown as pre-selectd
> > +       # _get_sets: the list of files that are shown as pre-selected
> >
>
> Maybe add an ending-sentence period there?
Contrary to the other comments, these are no valid sentences as the verb
is missing, so a period would seem misplaced here.

Reply | Threaded
Open this post in threaded view
|

Re: install.sub: Typofixes in comments

Pablo Méndez Hernández
Fair enough (not a native speaker, so good to know :) ).


Regards.
Pabll

On Sun, Aug 11, 2019, 15:31 Klemens Nanni <[hidden email]> wrote:

> On Sun, Aug 11, 2019 at 01:51:25PM +0200, Pablo Méndez Hernández wrote:
> > > @@ -1506,9 +1506,9 @@ install_files() {
> > >         # Fetch sets from local sources (disk, cdrom, nfs) as root.
> > >         [[ $_src == file://* ]] && _srclocal=true _unpriv=
> > >
> > > -       # Based on the file list in $_files, create two list for
> > > select_sets().
> > > +       # Based on the file list in $_files, create two lists for
> > > select_sets().
> > >         # _sets:     the list of files the user can select from
> > > -       # _get_sets: the list of files that are shown as pre-selectd
> > > +       # _get_sets: the list of files that are shown as pre-selected
> > >
> >
> > Maybe add an ending-sentence period there?
> Contrary to the other comments, these are no valid sentences as the verb
> is missing, so a period would seem misplaced here.
>