i3: drop unneeded builddir, set debug conditionally

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

i3: drop unneeded builddir, set debug conditionally

Klemens Nanni-2
CONFIGURE_STYLE=gnu and the port already handle SEPARATE_BUILD
gracefully, there's not need to pass the directory explicitly.

Also, when passing DEBUG, I'd like to enable the debug switch for
obvious reasons; that's how we do it for other ports already such as
mail/mutt for example.

OK?

Index: x11/i3/Makefile
===================================================================
RCS file: /cvs/ports/x11/i3/Makefile,v
retrieving revision 1.115
diff -u -p -r1.115 Makefile
--- x11/i3/Makefile 18 Jan 2019 11:34:20 -0000 1.115
+++ x11/i3/Makefile 16 Mar 2019 21:52:23 -0000
@@ -46,12 +46,14 @@ FAKE_FLAGS = i3confdir="${PREFIX}/share/
 SEPARATE_BUILD =Yes
 USE_GMAKE = Yes
 CONFIGURE_STYLE =gnu
-CONFIGURE_ARGS =--enable-builddir=${WRKBUILD} \
- --enable-debug=no
 CONFIGURE_ENV = CPPFLAGS="-I${X11BASE}/include \
   -I${LOCALBASE}/include" \
  LDFLAGS="-L${X11BASE}/lib \
  -L${LOCALBASE}/lib"
+
+.if defined(DEBUG)
+CONFIGURE_ARGS +=--enable-debug
+.endif
 
 pre-configure:
  ${SUBST_CMD} ${WRKSRC}/etc/config \

Reply | Threaded
Open this post in threaded view
|

Re: i3: drop unneeded builddir, set debug conditionally

Giovanni Bechis-7
On Sat, Mar 16, 2019 at 11:02:04PM +0100, Klemens Nanni wrote:
> CONFIGURE_STYLE=gnu and the port already handle SEPARATE_BUILD
> gracefully, there's not need to pass the directory explicitly.
>
> Also, when passing DEBUG, I'd like to enable the debug switch for
> obvious reasons; that's how we do it for other ports already such as
> mail/mutt for example.
>
committed with i3 update, thanks
 Giovanni

> OK?
>
> Index: x11/i3/Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/i3/Makefile,v
> retrieving revision 1.115
> diff -u -p -r1.115 Makefile
> --- x11/i3/Makefile 18 Jan 2019 11:34:20 -0000 1.115
> +++ x11/i3/Makefile 16 Mar 2019 21:52:23 -0000
> @@ -46,12 +46,14 @@ FAKE_FLAGS = i3confdir="${PREFIX}/share/
>  SEPARATE_BUILD =Yes
>  USE_GMAKE = Yes
>  CONFIGURE_STYLE =gnu
> -CONFIGURE_ARGS =--enable-builddir=${WRKBUILD} \
> - --enable-debug=no
>  CONFIGURE_ENV = CPPFLAGS="-I${X11BASE}/include \
>    -I${LOCALBASE}/include" \
>   LDFLAGS="-L${X11BASE}/lib \
>   -L${LOCALBASE}/lib"
> +
> +.if defined(DEBUG)
> +CONFIGURE_ARGS +=--enable-debug
> +.endif
>  
>  pre-configure:
>   ${SUBST_CMD} ${WRKSRC}/etc/config \
>

signature.asc (817 bytes) Download Attachment