[graphics/ffmpeg DASH Demuxing support]

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[graphics/ffmpeg DASH Demuxing support]

Paco Esteban
Hi ports@,

I sent this email to Brad Smith, maintainer of graphics/ffmpeg 2 weeks
ago but did not have any answer.

I'm forwarding it here so maybe somebody can take a look.

Thanks.

----- Forwarded message -----

...

I had a problem the other day trying to watch a video stream using mpv
(and later tried ffplay). I discovered that the OpenBSD package for
ffmpeg does not support DASH demuxing, and that was the problem.

I prepared a diff to add that support, find it at the end of the email.

Just one thing, I'm not so experienced with ports (just built one and
was really easy). I have a message like this when creating the package:

  LIB_DEPENDS textproc/libxml not needed for graphics/ffmpeg ?

I added that dependency myself, because DASH support is enabled via
--enable-libxml2 at configure time ...
Am I doing something wrong ?

Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/ffmpeg/Makefile,v
retrieving revision 1.182
diff -u -p -r1.182 Makefile
--- Makefile    2 Apr 2019 18:42:11 -0000       1.182
+++ Makefile    26 Apr 2019 08:05:11 -0000
@@ -8,6 +8,7 @@ CATEGORIES=     graphics multimedia
 MASTER_SITES=  https://ffmpeg.org/releases/
 EXTRACT_SUFX=  .tar.xz
 EPOCH=         0
+REVISION=      0

 SHARED_LIBS=   avcodec         23.0 \
                avdevice        11.0 \
@@ -50,7 +51,8 @@ LIB_DEPENDS=  archivers/bzip2 \
                multimedia/libvpx \
                multimedia/x264 \
                multimedia/x265 \
-               multimedia/xvidcore
+               multimedia/xvidcore \
+               textproc/libxml

 # inter-library dependencies for the current configuration
 LIBavcodec_EXTRALIBS=-L${LOCALBASE}/lib -ldav1d -lgsm -lmp3lame -lopus -lspeex -lvorbis -lvorbisenc -lvpx -lx264 -lx265 -lxvidcore -lm -lz -pthread
@@ -109,6 +111,7 @@ CONFIGURE_ARGS+= --enable-shared \
                --enable-libx264 \
                --enable-libx265 \
                --enable-libxvid \
+               --enable-libxml2 \
                --enable-nonfree \
                --enable-openssl \
                --extra-cflags="-I${LOCALBASE}/include -I${X11BASE}/include" \

...
----- End forwarded message -----

--
Paco Esteban.
https://onna.be/gpgkey.asc
9A6B 6083 AD9E FDC2 0EAF  5CB3 5818 130B 8A6D BC03

Reply | Threaded
Open this post in threaded view
|

Re: [graphics/ffmpeg DASH Demuxing support]

Rafael Sadowski
On Thu May 09, 2019 at 08:38:00PM +0200, Paco Esteban wrote:

> Hi ports@,
>
> I sent this email to Brad Smith, maintainer of graphics/ffmpeg 2 weeks
> ago but did not have any answer.
>
> I'm forwarding it here so maybe somebody can take a look.
>
> Thanks.
>
> ----- Forwarded message -----
>
> ...
>
> I had a problem the other day trying to watch a video stream using mpv
> (and later tried ffplay). I discovered that the OpenBSD package for
> ffmpeg does not support DASH demuxing, and that was the problem.
>
> I prepared a diff to add that support, find it at the end of the email.
>
> Just one thing, I'm not so experienced with ports (just built one and
> was really easy). I have a message like this when creating the package:
>
>   LIB_DEPENDS textproc/libxml not needed for graphics/ffmpeg ?
>
> I added that dependency myself, because DASH support is enabled via
> --enable-libxml2 at configure time ...
> Am I doing something wrong ?
>

I like the improvement and it works for me. New diff with to two tweaks:

- Regen WANTLIB
- Minor bump libavformat because new symbols have been added.

RS

Index: Makefile
===================================================================
RCS file: /cvs/ports/graphics/ffmpeg/Makefile,v
retrieving revision 1.182
diff -u -p -u -p -r1.182 Makefile
--- Makefile 2 Apr 2019 18:42:11 -0000 1.182
+++ Makefile 10 May 2019 05:06:24 -0000
@@ -8,11 +8,12 @@ CATEGORIES= graphics multimedia
 MASTER_SITES= https://ffmpeg.org/releases/
 EXTRACT_SUFX= .tar.xz
 EPOCH= 0
+REVISION= 0
 
 SHARED_LIBS= avcodec 23.0 \
  avdevice 11.0 \
  avfilter 8.0 \
- avformat 20.0 \
+ avformat 20.1 \
  avresample 2.0 \
  avutil 13.0 \
  postproc 17.0 \
@@ -30,7 +31,7 @@ PERMIT_PACKAGE_FTP= Yes
 WANTLIB= SDL2 X11 Xext Xv ass bz2 c crypto dav1d>=2.0 fontconfig freetype \
  fribidi gsm m mp3lame opus pthread sndio speex ssl v4l2 \
  vorbis vorbisenc vpx x264 x265 xcb xcb-shape xcb-shm \
- xcb-xfixes xvidcore z
+ xcb-xfixes xml2 xvidcore z
 
 BUILD_DEPENDS= textproc/texi2html \
  multimedia/frei0r-plugins
@@ -38,11 +39,11 @@ BUILD_DEPENDS= textproc/texi2html \
 BUILD_DEPENDS+= devel/nasm
 .endif
 LIB_DEPENDS= archivers/bzip2 \
+ audio/gsm \
  audio/lame \
  audio/libvorbis \
  audio/opus \
  audio/speex \
- audio/gsm \
  devel/sdl2 \
  multimedia/dav1d>=0.2.1 \
  multimedia/libass \
@@ -50,7 +51,8 @@ LIB_DEPENDS= archivers/bzip2 \
  multimedia/libvpx \
  multimedia/x264 \
  multimedia/x265 \
- multimedia/xvidcore
+ multimedia/xvidcore \
+ textproc/libxml
 
 # inter-library dependencies for the current configuration
 LIBavcodec_EXTRALIBS=-L${LOCALBASE}/lib -ldav1d -lgsm -lmp3lame -lopus -lspeex -lvorbis -lvorbisenc -lvpx -lx264 -lx265 -lxvidcore -lm -lz -pthread
@@ -110,6 +112,7 @@ CONFIGURE_ARGS+= --enable-shared \
  --enable-libx265 \
  --enable-libxvid \
  --enable-nonfree \
+ --enable-libxml2 \
  --enable-openssl \
  --extra-cflags="-I${LOCALBASE}/include -I${X11BASE}/include" \
  --extra-libs="-L${LOCALBASE}/lib -L${X11BASE}/lib" \

Reply | Threaded
Open this post in threaded view
|

Re: [graphics/ffmpeg DASH Demuxing support]

Klemens Nanni-2
OK kn

Reply | Threaded
Open this post in threaded view
|

Re: [graphics/ffmpeg DASH Demuxing support]

Brad Smith-14
In reply to this post by Paco Esteban
Hi Paco,

I saw this, but I forgot to reply.

I'm all for additional functionality, but FFmpeg in particular I have
been trying to balance functionality, but not try to pull in the
whole kitchen sink too.

I don't really like the idea of pulling this in as it adds a dependency on 3
new libraries. If we go in this direction the diff needs a bunch of
additional
changes.


On 5/9/2019 2:38 PM, Paco Esteban wrote:

> Hi ports@,
>
> I sent this email to Brad Smith, maintainer of graphics/ffmpeg 2 weeks
> ago but did not have any answer.
>
> I'm forwarding it here so maybe somebody can take a look.
>
> Thanks.
>
> ----- Forwarded message -----
>
> ...
>
> I had a problem the other day trying to watch a video stream using mpv
> (and later tried ffplay). I discovered that the OpenBSD package for
> ffmpeg does not support DASH demuxing, and that was the problem.
>
> I prepared a diff to add that support, find it at the end of the email.
>
> Just one thing, I'm not so experienced with ports (just built one and
> was really easy). I have a message like this when creating the package:
>
>    LIB_DEPENDS textproc/libxml not needed for graphics/ffmpeg ?
>
> I added that dependency myself, because DASH support is enabled via
> --enable-libxml2 at configure time ...
> Am I doing something wrong ?
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/graphics/ffmpeg/Makefile,v
> retrieving revision 1.182
> diff -u -p -r1.182 Makefile
> --- Makefile    2 Apr 2019 18:42:11 -0000       1.182
> +++ Makefile    26 Apr 2019 08:05:11 -0000
> @@ -8,6 +8,7 @@ CATEGORIES=     graphics multimedia
>   MASTER_SITES=  https://ffmpeg.org/releases/
>   EXTRACT_SUFX=  .tar.xz
>   EPOCH=         0
> +REVISION=      0
>
>   SHARED_LIBS=   avcodec         23.0 \
>                  avdevice        11.0 \
> @@ -50,7 +51,8 @@ LIB_DEPENDS=  archivers/bzip2 \
>                  multimedia/libvpx \
>                  multimedia/x264 \
>                  multimedia/x265 \
> -               multimedia/xvidcore
> +               multimedia/xvidcore \
> +               textproc/libxml
>
>   # inter-library dependencies for the current configuration
>   LIBavcodec_EXTRALIBS=-L${LOCALBASE}/lib -ldav1d -lgsm -lmp3lame -lopus -lspeex -lvorbis -lvorbisenc -lvpx -lx264 -lx265 -lxvidcore -lm -lz -pthread
> @@ -109,6 +111,7 @@ CONFIGURE_ARGS+= --enable-shared \
>                  --enable-libx264 \
>                  --enable-libx265 \
>                  --enable-libxvid \
> +               --enable-libxml2 \
>                  --enable-nonfree \
>                  --enable-openssl \
>                  --extra-cflags="-I${LOCALBASE}/include -I${X11BASE}/include" \
>
> ...
> ----- End forwarded message -----
>

Reply | Threaded
Open this post in threaded view
|

Re: [graphics/ffmpeg DASH Demuxing support]

Paco Esteban
Hi Brad,

On Fri, 10 May 2019, Brad Smith wrote:

> Hi Paco,
>
> I saw this, but I forgot to reply.

No worries !

> I'm all for additional functionality, but FFmpeg in particular I have
> been trying to balance functionality, but not try to pull in the
> whole kitchen sink too.

I understand.

> I don't really like the idea of pulling this in as it adds a dependency on 3
> new libraries. If we go in this direction the diff needs a bunch of
> additional
> changes.

As far as I understand it's "only" one more dependency textproc/libxml,
isn't it ?

I think supporting those kind of streams on the players that depend on
ffmpeg is a good thing and would be used by many (or not, who knows).

Anyway, you're the maintainer. I can always apply my patch and rebuild
if a new version comes around.

Thanks for your time !

--
Paco Esteban.
https://onna.be/gpgkey.asc
9A6B 6083 AD9E FDC2 0EAF  5CB3 5818 130B 8A6D BC03