flake8 -> py-flake8 + py3 flavor

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

flake8 -> py-flake8 + py3 flavor

Daniel Jakots-3
Hi,

The only way to add a py3 flavor to flake8 is by renaming the port.

Plan is:

1. import a py-flake8 which is flake8 + py-flake8.diff.
2. hook py{,3}-flake8 and unhook flake8 in devel/Makefile
3. commit devel/quirks
4. commit net/py-libcloud and www/youtube-dl (I didn't rev bump as it's
TDEP only)
5. cvs rm devel/flake8

According to cvsweb, there have never been any py-flake8 before so
things should be smoother than last time (-:

Cheers,
Daniel

py-libcloud.diff (492 bytes) Download Attachment
youtube-dl.diff (451 bytes) Download Attachment
quirks.diff (960 bytes) Download Attachment
py-flake8.diff (10K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: flake8 -> py-flake8 + py3 flavor

Alexander Shadchin
On Wed, Feb 22, 2017 at 09:11:30PM -0500, Daniel Jakots wrote:

> Hi,
>
> The only way to add a py3 flavor to flake8 is by renaming the port.
>
> Plan is:
>
> 1. import a py-flake8 which is flake8 + py-flake8.diff.
> 2. hook py{,3}-flake8 and unhook flake8 in devel/Makefile
> 3. commit devel/quirks
> 4. commit net/py-libcloud and www/youtube-dl (I didn't rev bump as it's
> TDEP only)
> 5. cvs rm devel/flake8
>
> According to cvsweb, there have never been any py-flake8 before so
> things should be smoother than last time (-:
>
> Cheers,
> Daniel

Thank you for add py3 flavor :-)

ok shadchin@

Small comment below.

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/flake8/Makefile,v
> retrieving revision 1.11
> diff -u -p -r1.11 Makefile
> --- Makefile 19 Feb 2017 20:15:42 -0000 1.11
> +++ Makefile 23 Feb 2017 01:38:41 -0000
> @@ -4,6 +4,8 @@ COMMENT = modular python code checker w
>  
>  MODPY_EGG_VERSION = 3.3.0
>  DISTNAME = flake8-${MODPY_EGG_VERSION}
> +PKGNAME = py-${DISTNAME}
> +REVISION = 0
>  

I think that REVISION is not need, PKGNAME will change.

--
Alexandr Shadchin

Reply | Threaded
Open this post in threaded view
|

Re: flake8 -> py-flake8 + py3 flavor

Stuart Henderson
On 2017/02/23 16:41, Alexandr Shadchin wrote:

> On Wed, Feb 22, 2017 at 09:11:30PM -0500, Daniel Jakots wrote:
> > Hi,
> >
> > The only way to add a py3 flavor to flake8 is by renaming the port.
> >
> > Plan is:
> >
> > 1. import a py-flake8 which is flake8 + py-flake8.diff.
> > 2. hook py{,3}-flake8 and unhook flake8 in devel/Makefile
> > 3. commit devel/quirks
> > 4. commit net/py-libcloud and www/youtube-dl (I didn't rev bump as it's
> > TDEP only)
> > 5. cvs rm devel/flake8
> >
> > According to cvsweb, there have never been any py-flake8 before so
> > things should be smoother than last time (-:
> >
> > Cheers,
> > Daniel
>
> Thank you for add py3 flavor :-)
>
> ok shadchin@

OK with me too, and thanks :)

> Small comment below.
>
> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/flake8/Makefile,v
> > retrieving revision 1.11
> > diff -u -p -r1.11 Makefile
> > --- Makefile 19 Feb 2017 20:15:42 -0000 1.11
> > +++ Makefile 23 Feb 2017 01:38:41 -0000
> > @@ -4,6 +4,8 @@ COMMENT = modular python code checker w
> >  
> >  MODPY_EGG_VERSION = 3.3.0
> >  DISTNAME = flake8-${MODPY_EGG_VERSION}
> > +PKGNAME = py-${DISTNAME}
> > +REVISION = 0
> >  
>
> I think that REVISION is not need, PKGNAME will change.

Quirks won't pick up the update unless it thinks the version is newer.