[fix] net/bitlbee: fix pidfile path

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[fix] net/bitlbee: fix pidfile path

Landry Breuil-5
Hi,

noticed when upgrading my server from 6.6 to 6.7 in the logs:

bitlbee[47042]: Warning: Couldn't write PID to `/var/run/bitlbee.pid'

since th rc script runs as unpriviledged user, this fails. Sure, that's
just a warning, and from code inspection it doesnt see used anywhere
(nor cleaned up upon exit ?), and rc.d framework doesnt rely on it, but
other sotware might (sysutils/monit likes to use pidfiles for example)
so why not fix it ?

Thought, feedback ?

Landry

Index: Makefile
===================================================================
RCS file: /cvs/ports/net/bitlbee/Makefile,v
retrieving revision 1.73
diff -u -r1.73 Makefile
--- Makefile    20 Mar 2020 16:44:25 -0000      1.73
+++ Makefile    23 May 2020 08:31:27 -0000
@@ -6,7 +6,7 @@
 DISTNAME=              bitlbee-$V
 PKGSPEC=               bitlbee-=$V
 CATEGORIES=            net
-REVISION=              0
+REVISION=              1
 
 HOMEPAGE=              https://bitlbee.org/
 
@@ -37,6 +37,7 @@
 CONFIGURE_ARGS+=       --bindir=${PREFIX}/libexec \
                        --mandir=${PREFIX}/man \
                        --config=${DB_DIR} \
+                       --pidfile=${DB_DIR}/bitlbee.pid \
                        --etcdir=${ETCDIR} \
                        --ssl=openssl \
                        --pie=0