[fix] kamailio on sparc64

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[fix] kamailio on sparc64

Jeremie Courreges-Anglas-2

Hi,

kamailio doesn't build on sparc64, please see:

  http://build-failures.rhaalovely.net//sparc64/2017-07-24/telephony/kamailio.log

I've already fixed this kind of issue in textproc/calibre earlier, the
patch is patches/patch-src_duktape_duktape_duk_config_h.

Test-built on amd64 only.  ok?


Index: patches/patch-src_modules_app_jsdt_duk_config_h
===================================================================
RCS file: patches/patch-src_modules_app_jsdt_duk_config_h
diff -N patches/patch-src_modules_app_jsdt_duk_config_h
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-src_modules_app_jsdt_duk_config_h 10 Aug 2017 04:53:41 -0000
@@ -0,0 +1,19 @@
+$OpenBSD$
+
+We do have inttypes.h, but gcc-4.2.1 doesn't default to C99 and
+thus doesn't #define __STDC_VERSION__ 199901L.
+
+Index: src/modules/app_jsdt/duk_config.h
+--- src/modules/app_jsdt/duk_config.h.orig
++++ src/modules/app_jsdt/duk_config.h
+@@ -1557,6 +1557,10 @@
+ #define DUK_F_HAVE_INTTYPES
+ #endif
+
++#ifndef DUK_F_HAVE_INTTYPES
++#define DUK_F_HAVE_INTTYPES
++#endif
++
+ /* Basic integer typedefs and limits, preferably from inttypes.h, otherwise
+  * through automatic detection.
+  */



--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: [fix] kamailio on sparc64

Roman Kravchuk
Hi,

If it works for you - maintainer ok.

2017-08-10 19:10 GMT+03:00 Jeremie Courreges-Anglas <[hidden email]>:

>
> Hi,
>
> kamailio doesn't build on sparc64, please see:
>
>   http://build-failures.rhaalovely.net//sparc64/2017-
> 07-24/telephony/kamailio.log
>
> I've already fixed this kind of issue in textproc/calibre earlier, the
> patch is patches/patch-src_duktape_duktape_duk_config_h.
>
> Test-built on amd64 only.  ok?
>
>
> Index: patches/patch-src_modules_app_jsdt_duk_config_h
> ===================================================================
> RCS file: patches/patch-src_modules_app_jsdt_duk_config_h
> diff -N patches/patch-src_modules_app_jsdt_duk_config_h
> --- /dev/null   1 Jan 1970 00:00:00 -0000
> +++ patches/patch-src_modules_app_jsdt_duk_config_h     10 Aug 2017
> 04:53:41 -0000
> @@ -0,0 +1,19 @@
> +$OpenBSD$
> +
> +We do have inttypes.h, but gcc-4.2.1 doesn't default to C99 and
> +thus doesn't #define __STDC_VERSION__ 199901L.
> +
> +Index: src/modules/app_jsdt/duk_config.h
> +--- src/modules/app_jsdt/duk_config.h.orig
> ++++ src/modules/app_jsdt/duk_config.h
> +@@ -1557,6 +1557,10 @@
> + #define DUK_F_HAVE_INTTYPES
> + #endif
> +
> ++#ifndef DUK_F_HAVE_INTTYPES
> ++#define DUK_F_HAVE_INTTYPES
> ++#endif
> ++
> + /* Basic integer typedefs and limits, preferably from inttypes.h,
> otherwise
> +  * through automatic detection.
> +  */
>
>
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE
>
Reply | Threaded
Open this post in threaded view
|

Re: [fix] kamailio on sparc64

Jeremie Courreges-Anglas-2
On Thu, Aug 10 2017, Roman Kravchuk <[hidden email]> wrote:
> Hi,
>
> If it works for you - maintainer ok.

Well, as I said I didn't test it on sparc64 (and other archiectures
potentially affected), but it can't be worse. :)

I'll commit this later, thanks.

--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: [fix] kamailio on sparc64

Kaashif Hymabaccus-2
On Thu, Aug 10, 2017 at 02:28:23PM -0400, Jeremie Courreges-Anglas wrote:
> Well, as I said I didn't test it on sparc64 (and other archiectures
> potentially affected), but it can't be worse. :)

In case you are wondering, I was able to build and run on sparc64 with
your new patch, so there's nothing to worry about as far as I can
tell.

--
Kaashif Hymabaccus
GPG: 3E810B04