files.pci: sis missing dependency for mii_phy

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

files.pci: sis missing dependency for mii_phy

Alexander von Gernler
Just like other interfaces, sis depends on mii_phy in order to
configure it via config(8).  Found out the hard way while building a custom
kernel for my Soekris net4501.

In GENERIC, this missing dependency is shadowed by many other
interfaces pulling in mii_phy in the first place.

Index: files.pci
===================================================================
RCS file: /cvs/openbsd/src/sys/dev/pci/files.pci,v
retrieving revision 1.337
diff -u -p -u -p -r1.337 files.pci
--- files.pci   29 Jul 2019 00:40:49 -0000      1.337
+++ files.pci   4 Aug 2019 15:21:47 -0000
@@ -448,7 +448,7 @@ attach      sf at pci with sf_pci
 file   dev/pci/if_sf_pci.c             sf_pci
 
 # SiS 900/7016 ethernet
-device sis: ether, ifnet, mii, ifmedia
+device sis: ether, ifnet, mii, ifmedia, mii_phy
 attach sis at pci
 file   dev/pci/if_sis.c                sis
 

Reply | Threaded
Open this post in threaded view
|

Re: files.pci: sis missing dependency for mii_phy

Stefan Sperling-5
On Sun, Aug 04, 2019 at 05:26:40PM +0200, Alexander von Gernler wrote:
> Just like other interfaces, sis depends on mii_phy in order to
> configure it via config(8).  Found out the hard way while building a custom
> kernel for my Soekris net4501.
>
> In GENERIC, this missing dependency is shadowed by many other
> interfaces pulling in mii_phy in the first place.

Thanks, committed.

Your patch had tabs replaced by spaces so it didn't apply as-is.
I had to apply it manually.

> Index: files.pci
> ===================================================================
> RCS file: /cvs/openbsd/src/sys/dev/pci/files.pci,v
> retrieving revision 1.337
> diff -u -p -u -p -r1.337 files.pci
> --- files.pci   29 Jul 2019 00:40:49 -0000      1.337
> +++ files.pci   4 Aug 2019 15:21:47 -0000
> @@ -448,7 +448,7 @@ attach      sf at pci with sf_pci
>  file   dev/pci/if_sf_pci.c             sf_pci
>  
>  # SiS 900/7016 ethernet
> -device sis: ether, ifnet, mii, ifmedia
> +device sis: ether, ifnet, mii, ifmedia, mii_phy
>  attach sis at pci
>  file   dev/pci/if_sis.c                sis
>  
>

Reply | Threaded
Open this post in threaded view
|

Re: files.pci: sis missing dependency for mii_phy

Alexander von Gernler
* Stefan Sperling <[hidden email]> [2019-08-05 10:33]:
> Your patch had tabs replaced by spaces so it didn't apply as-is.
> I had to apply it manually.

Sorry for that.  I guess something went wrong when pasting it inline.