dwm runs xterm

classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

dwm runs xterm

Ted Unangst-6
We have a local patch to dwm so that it runs xterm instead of uxterm. That's
fine, but the man page isn't patched, which is confusing.

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Gleydson Soares-3
On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> fine, but the man page isn't patched, which is confusing.

yes,
here is a diff to fix that.
 

Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/dwm/Makefile,v
retrieving revision 1.25
diff -u -p -u -p -r1.25 Makefile
--- Makefile 28 Oct 2014 08:23:06 -0000 1.25
+++ Makefile 8 Oct 2015 15:51:44 -0000
@@ -3,7 +3,7 @@
 COMMENT= dynamic window manager
 
 DISTNAME= dwm-6.0
-REVISION= 0
+REVISION= 1
 
 CATEGORIES= x11
 
Index: patches/patch-dwm_1
===================================================================
RCS file: patches/patch-dwm_1
diff -N patches/patch-dwm_1
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ patches/patch-dwm_1 8 Oct 2015 15:51:44 -0000
@@ -0,0 +1,12 @@
+$OpenBSD$
+--- dwm.1.orig Tue Oct  6 02:30:02 2015
++++ dwm.1 Tue Oct  6 02:30:17 2015
+@@ -57,7 +57,7 @@ click on a tag label adds/removes that tag to/from the
+ .TP
+ .B Mod1\-Shift\-Return
+ Start
+-.BR uxterm (1).
++.BR xterm (1).
+ .TP
+ .B Mod1\-,
+ Focus previous screen, if any.
Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Matthieu Herrb-7
On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > fine, but the man page isn't patched, which is confusing.
>
> yes,
> here is a diff to fix that.

Given that we want to support more of UTF-8, this patch seems
conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
time now.

What was the reason for that ?

>  

> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/dwm/Makefile,v
> retrieving revision 1.25
> diff -u -p -u -p -r1.25 Makefile
> --- Makefile 28 Oct 2014 08:23:06 -0000 1.25
> +++ Makefile 8 Oct 2015 15:51:44 -0000
> @@ -3,7 +3,7 @@
>  COMMENT= dynamic window manager
>  
>  DISTNAME= dwm-6.0
> -REVISION= 0
> +REVISION= 1
>  
>  CATEGORIES= x11
>  
> Index: patches/patch-dwm_1
> ===================================================================
> RCS file: patches/patch-dwm_1
> diff -N patches/patch-dwm_1
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ patches/patch-dwm_1 8 Oct 2015 15:51:44 -0000
> @@ -0,0 +1,12 @@
> +$OpenBSD$
> +--- dwm.1.orig Tue Oct  6 02:30:02 2015
> ++++ dwm.1 Tue Oct  6 02:30:17 2015
> +@@ -57,7 +57,7 @@ click on a tag label adds/removes that tag to/from the
> + .TP
> + .B Mod1\-Shift\-Return
> + Start
> +-.BR uxterm (1).
> ++.BR xterm (1).
> + .TP
> + .B Mod1\-,
> + Focus previous screen, if any.

--
Matthieu Herrb

attachment0 (476 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Ted Unangst-6
Matthieu Herrb wrote:

> On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > fine, but the man page isn't patched, which is confusing.
> >
> > yes,
> > here is a diff to fix that.
>
> Given that we want to support more of UTF-8, this patch seems
> conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> time now.
>
> What was the reason for that ?

I think some people don't want to use utf-8 yet? (although we are moving that
way...)

But I've had no trouble using xterm with "XTerm*locale:true" in .Xdefaults and
setting CTYPE.

Forcing people to use uxterm seems meaner than letting them configure xterm
how they like. Also, it's confusing (imo) that all the resources are named
UXTerm, since nearly every web page about xterm you'll find online talks about
XTerm. Seems like just one more gotcha.

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Jack J. Woehr
Ted Unangst wrote:
> Given that we want to support more of UTF-8, this patch seems
> conterproductive to me.
As a longtime user of dwm, taking the trouble to patch such a thing seems more trouble than it's worth.

Everyone who habitually uses DWM patches the hotkey functions all up anyway and rebuilds.


--
Jack J. Woehr     # Science is more than a body of knowledge. It's a way of
www.well.com/~jax # thinking, a way of skeptically interrogating the universe
www.softwoehr.com # with a fine understanding of human fallibility. - Carl Sagan

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Joerg Jung
In reply to this post by Matthieu Herrb-7
On Thu, Oct 08, 2015 at 07:05:34PM +0200, Matthieu Herrb wrote:

> On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > fine, but the man page isn't patched, which is confusing.
> >
> > yes,
> > here is a diff to fix that.
>
> Given that we want to support more of UTF-8, this patch seems
> conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> time now.

Sure, let's drop the patch, diff below.
 
> What was the reason for that ?

I have no idea.

Regards,
Joerg


Index: Makefile
===================================================================
RCS file: /cvs/ports/x11/dwm/Makefile,v
retrieving revision 1.25
diff -u -p -r1.25 Makefile
--- Makefile 28 Oct 2014 08:23:06 -0000 1.25
+++ Makefile 8 Oct 2015 19:05:37 -0000
@@ -3,7 +3,7 @@
 COMMENT= dynamic window manager
 
 DISTNAME= dwm-6.0
-REVISION= 0
+REVISION= 1
 
 CATEGORIES= x11
 
Index: patches/patch-config_def_h
===================================================================
RCS file: /cvs/ports/x11/dwm/patches/patch-config_def_h,v
retrieving revision 1.9
diff -u -p -r1.9 patch-config_def_h
--- patches/patch-config_def_h 9 Jul 2012 16:33:40 -0000 1.9
+++ patches/patch-config_def_h 8 Oct 2015 19:05:37 -0000
@@ -1,6 +1,6 @@
 $OpenBSD: patch-config_def_h,v 1.9 2012/07/09 16:33:40 zinke Exp $
 --- config.def.h.orig Mon Dec 19 16:02:46 2011
-+++ config.def.h Sat Jul  7 22:28:18 2012
++++ config.def.h Thu Oct  8 20:58:14 2015
 @@ -1,13 +1,13 @@
  /* See LICENSE file for copyright and license details. */
 
@@ -31,12 +31,3 @@ $OpenBSD: patch-config_def_h,v 1.9 2012/
  };
 
  /* layout(s) */
-@@ -47,7 +49,7 @@ static const Layout layouts[] = {
-
- /* commands */
- static const char *dmenucmd[] = { "dmenu_run", "-fn", font, "-nb", normbgcolor, "-nf", normfgcolor, "-sb", selbgcolor, "-sf", selfgcolor, NULL };
--static const char *termcmd[]  = { "uxterm", NULL };
-+static const char *termcmd[]  = { "xterm", NULL };
-
- static Key keys[] = {
- /* modifier                     key        function        argument */

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Ted Unangst-6
Joerg Jung wrote:

> On Thu, Oct 08, 2015 at 07:05:34PM +0200, Matthieu Herrb wrote:
> > On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > > fine, but the man page isn't patched, which is confusing.
> > >
> > > yes,
> > > here is a diff to fix that.
> >
> > Given that we want to support more of UTF-8, this patch seems
> > conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> > time now.
>
> Sure, let's drop the patch, diff below.

ok, i guess. this will annoy me because now I have to stick a dozen Us in
Xdefaults after some random pkg_add, but less divergence from upstream seems
like a good thing.

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Stuart Henderson-6
On 2015/10/08 21:03, Ted Unangst wrote:

> Joerg Jung wrote:
> > On Thu, Oct 08, 2015 at 07:05:34PM +0200, Matthieu Herrb wrote:
> > > On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > > > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > > > fine, but the man page isn't patched, which is confusing.
> > > >
> > > > yes,
> > > > here is a diff to fix that.
> > >
> > > Given that we want to support more of UTF-8, this patch seems
> > > conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> > > time now.
> >
> > Sure, let's drop the patch, diff below.
>
> ok, i guess. this will annoy me because now I have to stick a dozen Us in
> Xdefaults after some random pkg_add, but less divergence from upstream seems
> like a good thing.
>

Upstream actively encourages people to diverge, the recommended
(indeed, only...) way to configure it is by editing the config.def.h
file and recompiling.

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Joerg Jung
On Fri, Oct 09, 2015 at 10:07:52AM +0100, Stuart Henderson wrote:

> On 2015/10/08 21:03, Ted Unangst wrote:
> > Joerg Jung wrote:
> > > On Thu, Oct 08, 2015 at 07:05:34PM +0200, Matthieu Herrb wrote:
> > > > On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > > > > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > > > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > > > > fine, but the man page isn't patched, which is confusing.
> > > > >
> > > > > yes,
> > > > > here is a diff to fix that.
> > > >
> > > > Given that we want to support more of UTF-8, this patch seems
> > > > conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> > > > time now.
> > >
> > > Sure, let's drop the patch, diff below.
> >
> > ok, i guess. this will annoy me because now I have to stick a dozen Us in
> > Xdefaults after some random pkg_add, but less divergence from upstream seems
> > like a good thing.
> >
>
> Upstream actively encourages people to diverge, the recommended
> (indeed, only...) way to configure it is by editing the config.def.h
> file and recompiling.

There was the idea floating around (from czarkoff?), to provide a
suckless port-modules(5) to make the reconfiguration in config.def.h
and re-compiling easier.

Other (Linux) package build systems do support such customizations
already.

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Joerg Jung
In reply to this post by Ted Unangst-6
On Thu, Oct 08, 2015 at 09:03:10PM -0400, Ted Unangst wrote:

> Joerg Jung wrote:
> > On Thu, Oct 08, 2015 at 07:05:34PM +0200, Matthieu Herrb wrote:
> > > On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > > > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > > > fine, but the man page isn't patched, which is confusing.
> > > >
> > > > yes,
> > > > here is a diff to fix that.
> > >
> > > Given that we want to support more of UTF-8, this patch seems
> > > conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> > > time now.
> >
> > Sure, let's drop the patch, diff below.
>
> ok, i guess. this will annoy me because now I have to stick a dozen Us in
> Xdefaults

You might want to try to add asterisks (as wildcards) instead of Us.

> after some random pkg_add, but less divergence from upstream seems
> like a good thing.

Is that an OK? :)

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Dmitrij D. Czarkoff-2
In reply to this post by Joerg Jung
Joerg Jung said:
> There was the idea floating around (from czarkoff?), to provide a
> suckless port-modules(5) to make the reconfiguration in config.def.h
> and re-compiling easier.

Indeed, it was my plan.  But I got distracted.

> Other (Linux) package build systems do support such customizations
> already.

FWIW which?

--
Dmitrij D. Czarkoff

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Dimitris Papastamos
In reply to this post by Stuart Henderson-6
On Fri, Oct 09, 2015 at 10:07:52AM +0100, Stuart Henderson wrote:

> On 2015/10/08 21:03, Ted Unangst wrote:
> > Joerg Jung wrote:
> > > On Thu, Oct 08, 2015 at 07:05:34PM +0200, Matthieu Herrb wrote:
> > > > On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > > > > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > > > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > > > > fine, but the man page isn't patched, which is confusing.
> > > > >
> > > > > yes,
> > > > > here is a diff to fix that.
> > > >
> > > > Given that we want to support more of UTF-8, this patch seems
> > > > conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> > > > time now.
> > >
> > > Sure, let's drop the patch, diff below.
> >
> > ok, i guess. this will annoy me because now I have to stick a dozen Us in
> > Xdefaults after some random pkg_add, but less divergence from upstream seems
> > like a good thing.
> >
>
> Upstream actively encourages people to diverge, the recommended
> (indeed, only...) way to configure it is by editing the config.def.h
> file and recompiling.

Upstream encourages editing config.h not config.def.h.

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Joerg Jung
In reply to this post by Dmitrij D. Czarkoff-2


> Am 09.10.2015 um 11:51 schrieb Dmitrij D. Czarkoff <[hidden email]>:
>
> Joerg Jung said:
>> There was the idea floating around (from czarkoff?), to provide a
>> suckless port-modules(5) to make the reconfiguration in config.def.h
>> and re-compiling easier.
>
> Indeed, it was my plan.  But I got distracted.
>
>> Other (Linux) package build systems do support such customizations
>> already.
>
> FWIW which?

AFAIK, gentoo emerge ebuilds (header config file),
slackware (patches/ folder), arch pacman, and
debian apt.

Reply | Threaded
Open this post in threaded view
|

Re: dwm runs xterm

Joerg Jung
In reply to this post by Joerg Jung
On Thu, Oct 08, 2015 at 09:02:40PM +0200, Joerg Jung wrote:

> On Thu, Oct 08, 2015 at 07:05:34PM +0200, Matthieu Herrb wrote:
> > On Thu, Oct 08, 2015 at 12:58:42PM -0300, Gleydson Soares wrote:
> > > On Thu, Oct 08, 2015 at 08:39:13AM -0400, Ted Unangst wrote:
> > > > We have a local patch to dwm so that it runs xterm instead of uxterm. That's
> > > > fine, but the man page isn't patched, which is confusing.
> > >
> > > yes,
> > > here is a diff to fix that.
> >
> > Given that we want to support more of UTF-8, this patch seems
> > conterproductive to me.  uxterm is in /usr/X11R6/bin for quite a long
> > time now.
>
> Sure, let's drop the patch, diff below.

So anyone, willing to OK the diff below?

Or should we go the initially suggested route and add a patch to fix the
man page instead?

Regards,
Joerg


> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/x11/dwm/Makefile,v
> retrieving revision 1.25
> diff -u -p -r1.25 Makefile
> --- Makefile 28 Oct 2014 08:23:06 -0000 1.25
> +++ Makefile 8 Oct 2015 19:05:37 -0000
> @@ -3,7 +3,7 @@
>  COMMENT= dynamic window manager
>
>  DISTNAME= dwm-6.0
> -REVISION= 0
> +REVISION= 1
>
>  CATEGORIES= x11
>
> Index: patches/patch-config_def_h
> ===================================================================
> RCS file: /cvs/ports/x11/dwm/patches/patch-config_def_h,v
> retrieving revision 1.9
> diff -u -p -r1.9 patch-config_def_h
> --- patches/patch-config_def_h 9 Jul 2012 16:33:40 -0000 1.9
> +++ patches/patch-config_def_h 8 Oct 2015 19:05:37 -0000
> @@ -1,6 +1,6 @@
>  $OpenBSD: patch-config_def_h,v 1.9 2012/07/09 16:33:40 zinke Exp $
>  --- config.def.h.orig Mon Dec 19 16:02:46 2011
> -+++ config.def.h Sat Jul  7 22:28:18 2012
> ++++ config.def.h Thu Oct  8 20:58:14 2015
>  @@ -1,13 +1,13 @@
>   /* See LICENSE file for copyright and license details. */
>
> @@ -31,12 +31,3 @@ $OpenBSD: patch-config_def_h,v 1.9 2012/
>   };
>
>   /* layout(s) */
> -@@ -47,7 +49,7 @@ static const Layout layouts[] = {
> -
> - /* commands */
> - static const char *dmenucmd[] = { "dmenu_run", "-fn", font, "-nb", normbgcolor, "-nf", normfgcolor, "-sb", selbgcolor, "-sf", selfgcolor, NULL };
> --static const char *termcmd[]  = { "uxterm", NULL };
> -+static const char *termcmd[]  = { "xterm", NULL };
> -
> - static Key keys[] = {
> - /* modifier                     key        function        argument */
>