Re: don't hand-roll bpf_mtap_hdr for radiotap in wireless drivers
On Thu, Sep 12, 2019 at 01:21:46PM +1000, David Gwynne wrote:
> radiotap code puts an mbuf on the stack so it can build a chain that
> includes a radiotap header for bpf_mtap to chew on. bpf_mtap_hdr can do
> that for you though.
> bpf_mtap_hdr also cheats by using an m_hdr instead of a full mbuf,
> which makes the stack usage less, but im arguing for the diff because it
> makes the calling code simpler.
> this only tweaks the intel wireless drivers, there's a handful of other
> ones that could be fixed too if this diff goes in.
> tests? ok?