documentation/5191: pf.conf.5: a comma implied as mandatory for optional 2nd argument

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

documentation/5191: pf.conf.5: a comma implied as mandatory for optional 2nd argument

jared rr spiegel
>Number:         5191
>Category:       documentation
>Synopsis:       does the comma need its ow
>Confidential:   yes
>Severity:       non-critical
>Priority:       low
>Responsible:    bugs
>State:          open
>Quarter:        
>Keywords:      
>Date-Required:
>Class:          doc-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 31 04:20:01 GMT 2006
>Closed-Date:
>Last-Modified:
>Originator:     jared rr spiegel
>Release:        pf.conf.5,v 1.351 2006/07/25 16:59:25
>Organization:
net
>Environment:
       
        System      : OpenBSD 4.0
        Architecture: OpenBSD.i386
        Machine     : i386
>Description:
        does the comma need its own brackets?  it seems like it should
        have its own brackets, as it is entirely optional
>How-To-Repeat:
        the comma doesn't need to be in the config file:

$ echo "block return-icmp ( 0 0 ) all" | pfctl -nvvf-
@0 block return-icmp(net-unr, noroute-unr) all

>Fix:
       
        either this is right, or i'm wrong <G>

Index: pf.conf.5
===================================================================
RCS file: /cvs/src/share/man/man5/pf.conf.5,v
retrieving revision 1.351
diff -u -u -r1.351 pf.conf.5
--- pf.conf.5 25 Jul 2006 16:59:25 -0000 1.351
+++ pf.conf.5 31 Jul 2006 02:41:50 -0000
@@ -2777,7 +2777,7 @@
 
 action         = "pass" | "block" [ return ] | [ "no" ] "scrub"
 return         = "drop" | "return" | "return-rst" [ "( ttl" number ")" ] |
-                 "return-icmp" [ "(" icmpcode ["," icmp6code ] ")" ] |
+                 "return-icmp" [ "(" icmpcode [ [ "," ] icmp6code ] ")" ] |
                  "return-icmp6" [ "(" icmp6code ")" ]
 icmpcode       = ( icmp-code-name | icmp-code-number )
 icmp6code      = ( icmp6-code-name | icmp6-code-number )


>Release-Note:
>Audit-Trail:
>Unformatted: