diff: i386 kernel make should fail on genassym failure

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

diff: i386 kernel make should fail on genassym failure

Vladimir Kirillov-2
Hello, tech@!

I've tweaked i386 Makefile to fail if genassym.sh fails.
It's usually hard to notice when it comes before the bunch of
make output of mkdep commandline.

Index: conf/Makefile.i386
===================================================================
RCS file: /cvs/src/sys/arch/i386/conf/Makefile.i386,v
retrieving revision 1.78
diff -u -p -r1.78 Makefile.i386
--- conf/Makefile.i386 2 Dec 2010 20:57:08 -0000 1.78
+++ conf/Makefile.i386 30 Dec 2010 17:05:52 -0000
@@ -97,9 +97,8 @@ LINKFLAGS+= -S -x
 assym.h: $S/kern/genassym.sh Makefile \
  ${_archdir}/${_arch}/genassym.cf ${_machdir}/${_mach}/genassym.cf
  cat ${_archdir}/${_arch}/genassym.cf ${_machdir}/${_mach}/genassym.cf | \
-    sh $S/kern/genassym.sh ${CC} ${CFLAGS} ${CPPFLAGS} | \
-    sort -u > assym.h.tmp && \
-    mv -f assym.h.tmp assym.h
+    sh $S/kern/genassym.sh ${CC} ${CFLAGS} ${CPPFLAGS} > assym.h.tmp
+ sort -u -o assym.h assym.h.tmp
 
 param.c: $S/conf/param.c
  rm -f param.c