devel/boost,-md: simplify conditional

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

devel/boost,-md: simplify conditional

Jeremie Courreges-Anglas-2

I took a look at enabling -md on sparc64, to no avail, and stumbled upon
this double negative.  afaik ONLY_FOR_ARCHS-subpackage should do the same
but is more readable.  ok?


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/boost/Makefile,v
retrieving revision 1.88
diff -u -p -r1.88 Makefile
--- Makefile 18 Jul 2019 20:27:25 -0000 1.88
+++ Makefile 8 Aug 2019 14:48:40 -0000
@@ -1,5 +1,7 @@
 # $OpenBSD: Makefile,v 1.88 2019/07/18 20:27:25 sthen Exp $
 
+ONLY_FOR_ARCHS-md = aarch64 amd64 arm i386 powerpc
+
 COMMENT-main= free peer-reviewed portable C++ source libraries
 COMMENT-md= machine-dependent libraries for boost
 
@@ -95,12 +97,6 @@ WANTLIB-md+= boost_chrono-mt boost_files
 WANTLIB-md+= boost_system boost_thread-mt
 
 .include <bsd.port.arch.mk>
-
-.if !(${MACHINE_ARCH} == "aarch64" || ${MACHINE_ARCH} == "amd64" || \
-      ${MACHINE_ARCH} == "arm" || ${MACHINE_ARCH} == "i386" || \
-      ${MACHINE_ARCH} == "powerpc")
-BUILD_PACKAGES= ${MULTI_PACKAGES:N-md}
-.endif
 
 .if ${PROPERTIES:Mclang}
 TOOLSET= clang


--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply | Threaded
Open this post in threaded view
|

Re: devel/boost,-md: simplify conditional

Stuart Henderson
On 2019/08/09 01:57, Jeremie Courreges-Anglas wrote:
>
> I took a look at enabling -md on sparc64, to no avail, and stumbled upon
> this double negative.  afaik ONLY_FOR_ARCHS-subpackage should do the same
> but is more readable.  ok?

ok.

Reply | Threaded
Open this post in threaded view
|

Re: devel/boost,-md: simplify conditional

Brad Smith-14
In reply to this post by Jeremie Courreges-Anglas-2
OK.

On August 8, 2019 8:00:18 p.m. Jeremie Courreges-Anglas <[hidden email]> wrote:

> I took a look at enabling -md on sparc64, to no avail, and stumbled upon
> this double negative.  afaik ONLY_FOR_ARCHS-subpackage should do the same
> but is more readable.  ok?
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/boost/Makefile,v
> retrieving revision 1.88
> diff -u -p -r1.88 Makefile
> --- Makefile 18 Jul 2019 20:27:25 -0000 1.88
> +++ Makefile 8 Aug 2019 14:48:40 -0000
> @@ -1,5 +1,7 @@
> # $OpenBSD: Makefile,v 1.88 2019/07/18 20:27:25 sthen Exp $
>
> +ONLY_FOR_ARCHS-md = aarch64 amd64 arm i386 powerpc
> +
> COMMENT-main= free peer-reviewed portable C++ source libraries
> COMMENT-md= machine-dependent libraries for boost
>
> @@ -95,12 +97,6 @@ WANTLIB-md+= boost_chrono-mt boost_files
> WANTLIB-md+= boost_system boost_thread-mt
>
> .include <bsd.port.arch.mk>
> -
> -.if !(${MACHINE_ARCH} == "aarch64" || ${MACHINE_ARCH} == "amd64" || \
> -      ${MACHINE_ARCH} == "arm" || ${MACHINE_ARCH} == "i386" || \
> -      ${MACHINE_ARCH} == "powerpc")
> -BUILD_PACKAGES= ${MULTI_PACKAGES:N-md}
> -.endif
>
> .if ${PROPERTIES:Mclang}
> TOOLSET= clang
>
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE


Sent with AquaMail for Android
https://www.mobisystems.com/aqua-mail