dev/fdt/sxi{mmc,twi}.c: better english - err printf()s s/can't to/failed to/

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

dev/fdt/sxi{mmc,twi}.c: better english - err printf()s s/can't to/failed to/

Artturi Alm
Hi,

spotted these while looking at x_attach() printf()s for something else.

-Artturi


diff --git a/sys/dev/fdt/sximmc.c b/sys/dev/fdt/sximmc.c
index eb5cf7f353e..9fa831d955a 100644
--- a/sys/dev/fdt/sximmc.c
+++ b/sys/dev/fdt/sximmc.c
@@ -418,7 +418,7 @@ sximmc_attach(struct device *parent, struct device *self, void *aux)
  sc->sc_ih = fdt_intr_establish(faa->fa_node, IPL_BIO,
     sximmc_intr, sc, sc->sc_dev.dv_xname);
  if (sc->sc_ih == NULL) {
- printf(": can't to establish interrupt\n");
+ printf(": failed to establish interrupt\n");
  return;
  }
 
diff --git a/sys/dev/fdt/sxitwi.c b/sys/dev/fdt/sxitwi.c
index 3c261d7cc5b..36d06aa5a15 100644
--- a/sys/dev/fdt/sxitwi.c
+++ b/sys/dev/fdt/sxitwi.c
@@ -278,7 +278,7 @@ sxitwi_attach(struct device *parent, struct device *self, void *aux)
  sc->sc_ih = fdt_intr_establish(faa->fa_node, IPL_BIO,
     sxitwi_intr, sc, sc->sc_dev.dv_xname);
  if (sc->sc_ih == NULL) {
- printf(": can't to establish interrupt\n");
+ printf(": failed to establish interrupt\n");
  return;
  }
 

Reply | Threaded
Open this post in threaded view
|

Re: dev/fdt/sxi{mmc,twi}.c: better english - err printf()s s/can't to/failed to/

Mark Kettenis
> Date: Tue, 4 Dec 2018 11:53:57 +0200
> From: Artturi Alm <[hidden email]>
>
> Hi,
>
> spotted these while looking at x_attach() printf()s for something else.

Thanks, I unified all these messages to "can't establish interrupt".

> diff --git a/sys/dev/fdt/sximmc.c b/sys/dev/fdt/sximmc.c
> index eb5cf7f353e..9fa831d955a 100644
> --- a/sys/dev/fdt/sximmc.c
> +++ b/sys/dev/fdt/sximmc.c
> @@ -418,7 +418,7 @@ sximmc_attach(struct device *parent, struct device *self, void *aux)
>   sc->sc_ih = fdt_intr_establish(faa->fa_node, IPL_BIO,
>      sximmc_intr, sc, sc->sc_dev.dv_xname);
>   if (sc->sc_ih == NULL) {
> - printf(": can't to establish interrupt\n");
> + printf(": failed to establish interrupt\n");
>   return;
>   }
>  
> diff --git a/sys/dev/fdt/sxitwi.c b/sys/dev/fdt/sxitwi.c
> index 3c261d7cc5b..36d06aa5a15 100644
> --- a/sys/dev/fdt/sxitwi.c
> +++ b/sys/dev/fdt/sxitwi.c
> @@ -278,7 +278,7 @@ sxitwi_attach(struct device *parent, struct device *self, void *aux)
>   sc->sc_ih = fdt_intr_establish(faa->fa_node, IPL_BIO,
>      sxitwi_intr, sc, sc->sc_dev.dv_xname);
>   if (sc->sc_ih == NULL) {
> - printf(": can't to establish interrupt\n");
> + printf(": failed to establish interrupt\n");
>   return;
>   }
>  
>
>