> On Sun, Apr 05, 2015 at 11:48:21AM +0200, Alexandr Nedvedicky wrote:
>> when we ran PF sources through coverity we got an error
>> as follows:
>> 8310 if (ri->r->dst.addr.type == PF_ADDR_TABLE)
>> 8311 pfr_update_stats(ri->r->dst.addr.p.tbl,
>> 8312 &s->key[(s->direction == PF_IN)]->
>> 8313 addr[(s->direction == PF_IN)],
>> CID 38100 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR)copy_paste_error: src
>> in ri->r->src.neg looks like a copy-paste error.
>> Should it say dst instead?
>> 8314 pd, ri->r->action, ri->r->src.neg);
>> 8315 }
>> 8316 }
>> (note: line numbers won't match line numbers in OpenBSD).
>> It seems to me coveirty is right. Patch against CURRENT is attached.
>> kind regards