comms/p5-Device-Gsm: fix RUN_DEPENDS

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

comms/p5-Device-Gsm: fix RUN_DEPENDS

Charlene Wendling
While testing that port i'm greeted with:

> # Failed test 1 in t/01basic.t at line 3
> #  t/01basic.t line 3 is: END { ok(0) unless $loaded }
> t/01basic.t .......
> Dubious, test returned 2 (wstat 512, 0x200)
> Failed 2/2 subtests
> Can't locate Device/SerialPort.pm in @INC (you may need to install
> the Device::SerialPort module)

With the below diff, tests pass (but i have no device to really test
it). While here i've removed the useless BUILD_DEPENDS line.

OK ?

Charlène.


Index: Makefile
===================================================================
RCS file: /cvs/ports/comms/p5-Device-Gsm/Makefile,v
retrieving revision 1.14
diff -u -p -u -p -r1.14 Makefile
--- Makefile 3 Jul 2020 21:44:31 -0000 1.14
+++ Makefile 29 Aug 2020 14:19:32 -0000
@@ -4,7 +4,7 @@ COMMENT= Perl extension to interface GSM
 
 DISTNAME = Device-Gsm-1.61
 CATEGORIES= comms
-REVISION = 0
+REVISION = 1
 
 MODULES= cpan
 PKG_ARCH= *
@@ -12,7 +12,7 @@ PKG_ARCH= *
 # Artistic
 PERMIT_PACKAGE= Yes
 
-RUN_DEPENDS= comms/p5-Device-Modem
-BUILD_DEPENDS= comms/p5-Device-Modem
+RUN_DEPENDS= comms/p5-Device-Modem \
+ comms/p5-Device-SerialPort
 
 .include <bsd.port.mk>

Reply | Threaded
Open this post in threaded view
|

Re: comms/p5-Device-Gsm: fix RUN_DEPENDS

Andrew Hewus Fresh
On Sat, Aug 29, 2020 at 05:25:05PM +0200, Charlene Wendling wrote:

> While testing that port i'm greeted with:
>
> > # Failed test 1 in t/01basic.t at line 3
> > #  t/01basic.t line 3 is: END { ok(0) unless $loaded }
> > t/01basic.t .......
> > Dubious, test returned 2 (wstat 512, 0x200)
> > Failed 2/2 subtests
> > Can't locate Device/SerialPort.pm in @INC (you may need to install
> > the Device::SerialPort module)
>
> With the below diff, tests pass (but i have no device to really test
> it). While here i've removed the useless BUILD_DEPENDS line.
>
> OK ?

OK afresh1@


> Charlène.
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/comms/p5-Device-Gsm/Makefile,v
> retrieving revision 1.14
> diff -u -p -u -p -r1.14 Makefile
> --- Makefile 3 Jul 2020 21:44:31 -0000 1.14
> +++ Makefile 29 Aug 2020 14:19:32 -0000
> @@ -4,7 +4,7 @@ COMMENT= Perl extension to interface GSM
>  
>  DISTNAME = Device-Gsm-1.61
>  CATEGORIES= comms
> -REVISION = 0
> +REVISION = 1
>  
>  MODULES= cpan
>  PKG_ARCH= *
> @@ -12,7 +12,7 @@ PKG_ARCH= *
>  # Artistic
>  PERMIT_PACKAGE= Yes
>  
> -RUN_DEPENDS= comms/p5-Device-Modem
> -BUILD_DEPENDS= comms/p5-Device-Modem
> +RUN_DEPENDS= comms/p5-Device-Modem \
> + comms/p5-Device-SerialPort
>  
>  .include <bsd.port.mk>
>

--
andrew - http://afresh1.com

($do || !$do) && undef($try) ;  # Master of Perl, Yoda is.  Hmmmm?