bump p5-Devel-CheckLib to newer version ?

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

bump p5-Devel-CheckLib to newer version ?

sven falempin
Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Devel-CheckLib/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- Makefile    29 Dec 2017 07:24:49 -0000      1.3
+++ Makefile    7 Jan 2019 19:48:13 -0000
@@ -3,7 +3,7 @@
 COMMENT =      module to check for C library availablity
 MODULES =      cpan
-DISTNAME =     Devel-CheckLib-1.02
+DISTNAME =     Devel-CheckLib-1.12
 CATEGORIES =   devel
 REVISION =     0
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/p5-Devel-CheckLib/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo    2 Jan 2015 14:23:29 -0000       1.1.1.1
+++ distinfo    7 Jan 2019 19:48:13 -0000
@@ -1,2 +1,2 @@
-SHA256 (Devel-CheckLib-1.02.tar.gz) =
72/Ef77zbIOeM4V4iKfO2BY4IwW4C/NH/1upvw9d7EM=
-SIZE (Devel-CheckLib-1.02.tar.gz) = 13277
+SHA256 (Devel-CheckLib-1.12.tar.gz) =
qQq+a1RC3AoxtM9SMcYTh3ZYivwUbQrW6Nmoq8u9lVE=
+SIZE (Devel-CheckLib-1.12.tar.gz) = 15222
cvs server: Diffing pkg


--
--
---------------------------------------------------------------------------------------------------------------------
Knowing is not enough; we must apply. Willing is not enough; we must do
Reply | Threaded
Open this post in threaded view
|

Re: bump p5-Devel-CheckLib to newer version ?

Andrew Hewus Fresh
On Mon, Jan 07, 2019 at 02:50:43PM -0500, sven falempin wrote:
> -DISTNAME =     Devel-CheckLib-1.02
> +DISTNAME =     Devel-CheckLib-1.12

Had to patch this manually as it wouldn't apply, but after that this
seems fine, although I did remove the REVISION as it's no longer needed.

However, version 1.13 is on the CPAN, so I think we should pick up that
one.

OK?


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Devel-CheckLib/Makefile,v
retrieving revision 1.3
diff -u -p -r1.3 Makefile
--- Makefile 29 Dec 2017 07:24:49 -0000 1.3
+++ Makefile 25 Jan 2019 02:50:17 -0000
@@ -3,9 +3,8 @@
 COMMENT = module to check for C library availablity
 
 MODULES = cpan
-DISTNAME = Devel-CheckLib-1.02
+DISTNAME = Devel-CheckLib-1.13
 CATEGORIES = devel
-REVISION = 0
 
 # perl
 PERMIT_PACKAGE_CDROM = Yes
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/p5-Devel-CheckLib/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -r1.1.1.1 distinfo
--- distinfo 2 Jan 2015 14:23:29 -0000 1.1.1.1
+++ distinfo 25 Jan 2019 02:50:17 -0000
@@ -1,2 +1,2 @@
-SHA256 (Devel-CheckLib-1.02.tar.gz) = 72/Ef77zbIOeM4V4iKfO2BY4IwW4C/NH/1upvw9d7EM=
-SIZE (Devel-CheckLib-1.02.tar.gz) = 13277
+SHA256 (Devel-CheckLib-1.13.tar.gz) = JK39kIcF36xLsyBxF2PzcSa3XPVLNWbCwnx83vnEKag=
+SIZE (Devel-CheckLib-1.13.tar.gz) = 15450
Reply | Threaded
Open this post in threaded view
|

Re: bump p5-Devel-CheckLib to newer version ?

Charlene Wendling
On Thu, 24 Jan 2019 19:51:45 -0700
Andrew Hewus Fresh wrote:

> On Mon, Jan 07, 2019 at 02:50:43PM -0500, sven falempin wrote:
> > -DISTNAME =     Devel-CheckLib-1.02
> > +DISTNAME =     Devel-CheckLib-1.12
>
> Had to patch this manually as it wouldn't apply, but after that this
> seems fine, although I did remove the REVISION as it's no longer
> needed.
>
> However, version 1.13 is on the CPAN, so I think we should pick up
> that one.
>
> OK?
>

Hi everyone,

It may need some tiny tweaks, i'm joining a diff with them.

It requires a new test dependency. The test runs differently [1] with
Mock::Config. It's still passing :)

Also WANTLIB is here, and i don't get why because the module is pure
Perl. Maybe there is something i don't know about yet?

'make port-lib-depends-check' and portgen(1) agree with the 2 changes,
consumers have been built successfully.

What do you think about it?

Charlène.


[1]
https://metacpan.org/source/MATTN/Devel-CheckLib-1.13/t/multi-word-compiler.t


Index: Makefile
===================================================================
RCS file: /cvs/ports/devel/p5-Devel-CheckLib/Makefile,v
retrieving revision 1.3
diff -u -p -u -p -r1.3 Makefile
--- Makefile 29 Dec 2017 07:24:49 -0000 1.3
+++ Makefile 8 Feb 2019 22:58:13 -0000
@@ -3,15 +3,15 @@
 COMMENT = module to check for C library availablity
 
 MODULES = cpan
-DISTNAME = Devel-CheckLib-1.02
+DISTNAME = Devel-CheckLib-1.13
 CATEGORIES = devel
-REVISION = 0
 
 # perl
 PERMIT_PACKAGE_CDROM = Yes
 
-WANTLIB= perl
+TEST_DEPENDS = devel/p5-IO-CaptureOutput>=1.0801 \
+ devel/p5-Mock-Config>=0.02
 
-TEST_DEPENDS = devel/p5-IO-CaptureOutput>=1.0801
+PKG_ARCH = *
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /cvs/ports/devel/p5-Devel-CheckLib/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 distinfo
--- distinfo 2 Jan 2015 14:23:29 -0000 1.1.1.1
+++ distinfo 8 Feb 2019 22:58:13 -0000
@@ -1,2 +1,2 @@
-SHA256 (Devel-CheckLib-1.02.tar.gz) = 72/Ef77zbIOeM4V4iKfO2BY4IwW4C/NH/1upvw9d7EM=
-SIZE (Devel-CheckLib-1.02.tar.gz) = 13277
+SHA256 (Devel-CheckLib-1.13.tar.gz) = JK39kIcF36xLsyBxF2PzcSa3XPVLNWbCwnx83vnEKag=
+SIZE (Devel-CheckLib-1.13.tar.gz) = 15450

Reply | Threaded
Open this post in threaded view
|

Re: bump p5-Devel-CheckLib to newer version ?

Andrew Hewus Fresh
On Sun, Feb 10, 2019 at 12:07:52AM +0100, Charlene Wendling wrote:

> On Thu, 24 Jan 2019 19:51:45 -0700
> Andrew Hewus Fresh wrote:
>
> > On Mon, Jan 07, 2019 at 02:50:43PM -0500, sven falempin wrote:
> > > -DISTNAME =     Devel-CheckLib-1.02
> > > +DISTNAME =     Devel-CheckLib-1.12
> >
> > Had to patch this manually as it wouldn't apply, but after that this
> > seems fine, although I did remove the REVISION as it's no longer
> > needed.
> >
> > However, version 1.13 is on the CPAN, so I think we should pick up
> > that one.
> >
> > OK?
> >
>
> Hi everyone,
>
> It may need some tiny tweaks, i'm joining a diff with them.

OK afresh1@, this seems fine with me and I don't see any reason it would
need a WANTLIB either.  I did have trouble with the patch applying, not
sure what I did wrong there, but it seems fine.



> It requires a new test dependency. The test runs differently [1] with
> Mock::Config. It's still passing :)
>
> Also WANTLIB is here, and i don't get why because the module is pure
> Perl. Maybe there is something i don't know about yet?
>
> 'make port-lib-depends-check' and portgen(1) agree with the 2 changes,
> consumers have been built successfully.
>
> What do you think about it?
>
> Charlène.
>
>
> [1]
> https://metacpan.org/source/MATTN/Devel-CheckLib-1.13/t/multi-word-compiler.t
>
>
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/p5-Devel-CheckLib/Makefile,v
> retrieving revision 1.3
> diff -u -p -u -p -r1.3 Makefile
> --- Makefile 29 Dec 2017 07:24:49 -0000 1.3
> +++ Makefile 8 Feb 2019 22:58:13 -0000
> @@ -3,15 +3,15 @@
>  COMMENT = module to check for C library availablity
>  
>  MODULES = cpan
> -DISTNAME = Devel-CheckLib-1.02
> +DISTNAME = Devel-CheckLib-1.13
>  CATEGORIES = devel
> -REVISION = 0
>  
>  # perl
>  PERMIT_PACKAGE_CDROM = Yes
>  
> -WANTLIB= perl
> +TEST_DEPENDS = devel/p5-IO-CaptureOutput>=1.0801 \
> + devel/p5-Mock-Config>=0.02
>  
> -TEST_DEPENDS = devel/p5-IO-CaptureOutput>=1.0801
> +PKG_ARCH = *
>  
>  .include <bsd.port.mk>
> Index: distinfo
> ===================================================================
> RCS file: /cvs/ports/devel/p5-Devel-CheckLib/distinfo,v
> retrieving revision 1.1.1.1
> diff -u -p -u -p -r1.1.1.1 distinfo
> --- distinfo 2 Jan 2015 14:23:29 -0000 1.1.1.1
> +++ distinfo 8 Feb 2019 22:58:13 -0000
> @@ -1,2 +1,2 @@
> -SHA256 (Devel-CheckLib-1.02.tar.gz) = 72/Ef77zbIOeM4V4iKfO2BY4IwW4C/NH/1upvw9d7EM=
> -SIZE (Devel-CheckLib-1.02.tar.gz) = 13277
> +SHA256 (Devel-CheckLib-1.13.tar.gz) = JK39kIcF36xLsyBxF2PzcSa3XPVLNWbCwnx83vnEKag=
> +SIZE (Devel-CheckLib-1.13.tar.gz) = 15450

--
andrew - http://afresh1.com

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the Universe
trying to produce bigger and better idiots. So far, the Universe is
winning."             -- Rich Cook

Reply | Threaded
Open this post in threaded view
|

Re: bump p5-Devel-CheckLib to newer version ?

Stuart Henderson
> > Also WANTLIB is here, and i don't get why because the module is pure
> > Perl. Maybe there is something i don't know about yet?

Previously we had SHARED_ONLY for ports that only work on architectures
with shared libraries.

For perl ports this was mostly due to XS modules (and ports infrastructure
automatically added the perl WANTLIB for ports marked SHARED_ONLY).

When SHARED_ONLY was retired the WANTLIBs were re-added.

But this port is a corner case - it was marked SHARED_ONLY because it
deals with shared libs, not because it's an XS module. So removing
the WANTLIB is correct.