[base-gcc] Unbreak sysutils/usmb

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[base-gcc] Unbreak sysutils/usmb

Charlene Wendling

> http://build-failures.rhaalovely.net/sparc64/2019-11-07/sysutils/usmb.log

This is once again a port built with `-Werror' that is breaking after
the glib2 update.

On macppc, it builds fine [1] once removed.

HOMEPAGE [0] returns "Forbidden", and pages on the whole domain are
empty. Maybe we should remove that line?

Comments/feedback are welcome,

Charlène.


[0] http://ametros.net/code.html
[1] https://bin.charlenew.xyz/usmb.log


Index: Makefile
===================================================================
RCS file: /cvs/ports/sysutils/usmb/Makefile,v
retrieving revision 1.10
diff -u -p -u -p -r1.10 Makefile
--- Makefile 12 Jul 2019 20:49:54 -0000 1.10
+++ Makefile 9 Nov 2019 07:42:19 -0000
@@ -3,7 +3,7 @@
 COMMENT= mount SMB shares from userland via FUSE
 
 DISTNAME= usmb-20130204
-REVISION= 6
+REVISION= 7
 
 CATEGORIES= sysutils
 
Index: patches/patch-Makefile_in
===================================================================
RCS file: /cvs/ports/sysutils/usmb/patches/patch-Makefile_in,v
retrieving revision 1.1.1.1
diff -u -p -u -p -r1.1.1.1 patch-Makefile_in
--- patches/patch-Makefile_in 5 Jun 2014 15:40:09 -0000 1.1.1.1
+++ patches/patch-Makefile_in 9 Nov 2019 07:42:19 -0000
@@ -1,7 +1,8 @@
 $OpenBSD: patch-Makefile_in,v 1.1.1.1 2014/06/05 15:40:09 sthen Exp $
---- Makefile.in.orig Mon Feb  4 19:32:17 2013
-+++ Makefile.in Tue Jun  3 10:36:28 2014
-@@ -22,7 +22,7 @@ prefix = ${DESTDIR}@prefix@
+Index: Makefile.in
+--- Makefile.in.orig
++++ Makefile.in
+@@ -22,10 +22,10 @@ prefix = ${DESTDIR}@prefix@
  exec_prefix = @exec_prefix@
  bindir = @bindir@
  datarootdir = @datarootdir@
@@ -9,7 +10,11 @@ $OpenBSD: patch-Makefile_in,v 1.1.1.1 20
 +mandir = ${DESTDIR}@mandir@
  man1dir = $(mandir)/man1
 
- CFLAGS = @CFLAGS@ -I@srcdir@ -I@builddir@ -Werror
+-CFLAGS = @CFLAGS@ -I@srcdir@ -I@builddir@ -Werror
++CFLAGS = @CFLAGS@ -I@srcdir@ -I@builddir@
+ LDFLAGS = @LDFLAGS@
+ LIBS = @LIBS@
+
 @@ -65,7 +65,7 @@ install-strip: STRIPFLAGS = -s
  install install-strip: $(PROGRAM)
  @MKDIR_P@ $(bindir) $(man1dir)

Reply | Threaded
Open this post in threaded view
|

Re: [base-gcc] Unbreak sysutils/usmb

Landry Breuil-5
On Sat, Nov 09, 2019 at 09:16:49AM +0100, Charlene Wendling wrote:

>
> > http://build-failures.rhaalovely.net/sparc64/2019-11-07/sysutils/usmb.log
>
> This is once again a port built with `-Werror' that is breaking after
> the glib2 update.
>
> On macppc, it builds fine [1] once removed.
>
> HOMEPAGE [0] returns "Forbidden", and pages on the whole domain are
> empty. Maybe we should remove that line?

I wonder if we shouldnt rather remove the port itself. Iirc i tried it
at some point and failed at accessing an smb share, and even if the code
uses samba libs, it feels awkward to use a project which had no releases
in 6 years (and seems dead upstream) for something a bit 'critical'...
and our fuse isnt that great.

Do people actually rely on this, and it works for them ? I've been using
gvfs-smb since forever..

Landry

Reply | Threaded
Open this post in threaded view
|

Re: [base-gcc] Unbreak sysutils/usmb

Stuart Henderson
On 2019/11/09 09:35, Landry Breuil wrote:

> On Sat, Nov 09, 2019 at 09:16:49AM +0100, Charlene Wendling wrote:
> >
> > > http://build-failures.rhaalovely.net/sparc64/2019-11-07/sysutils/usmb.log
> >
> > This is once again a port built with `-Werror' that is breaking after
> > the glib2 update.
> >
> > On macppc, it builds fine [1] once removed.
> >
> > HOMEPAGE [0] returns "Forbidden", and pages on the whole domain are
> > empty. Maybe we should remove that line?
>
> I wonder if we shouldnt rather remove the port itself. Iirc i tried it
> at some point and failed at accessing an smb share, and even if the code
> uses samba libs, it feels awkward to use a project which had no releases
> in 6 years (and seems dead upstream) for something a bit 'critical'...
> and our fuse isnt that great.
>
> Do people actually rely on this, and it works for them ? I've been using
> gvfs-smb since forever..

It worked last time I needed it (and our FUSE support improved a bit
since then). If someone can find a better FUSE CIFS/SMB mount tool and
can make it work on OpenBSD I'm ok with removing it though - it was very
much "this is a bit ugly but none of the others work" port ;)

I agree gvfs-smb is better for those programs that can use gvfs.

Reply | Threaded
Open this post in threaded view
|

Re: [base-gcc] Unbreak sysutils/usmb

Marcus MERIGHI
In reply to this post by Landry Breuil-5
Hello!

[hidden email] (Landry Breuil), 2019.11.09 (Sat) 09:35 (CET):

> On Sat, Nov 09, 2019 at 09:16:49AM +0100, Charlene Wendling wrote:
> > > http://build-failures.rhaalovely.net/sparc64/2019-11-07/sysutils/usmb.log
>
> I wonder if we shouldnt rather remove the port itself. Iirc i tried it
> at some point and failed at accessing an smb share, and even if the code
> uses samba libs, it feels awkward to use a project which had no releases
> in 6 years (and seems dead upstream) for something a bit 'critical'...
> and our fuse isnt that great.
>
> Do people actually rely on this, and it works for them ? I've been using
> gvfs-smb since forever..

I used it more often quite some time ago; tested it now: it works if I
run it as root (kern.usermount removed) and if I do some wild dances
with doas(1) to access the files.

my testing was: copy a file to the share, copy one from the share;
delete on share; copy 800MB from share. I copied over wifi, the speed
seemed to be capped by the connection quality, not the software.

I've tried gvfs-smb as a substitute; it works if I use GIO programs
like pcmanfm or gimp. But no real mounting, right?

Marcus