audio/potamus

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

audio/potamus

Björn Ketelaars
Diff below brings potamus to the latest version. While here add
SEPARATE_BUILD=Yes to Makefile.

Tested OK by Rage Against The Machine

OK?



Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/potamus/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- Makefile 16 Nov 2017 19:52:09 -0000 1.6
+++ Makefile 13 Feb 2018 17:32:10 -0000
@@ -1,9 +1,8 @@
 # $OpenBSD: Makefile,v 1.6 2017/11/16 19:52:09 kirby Exp $
 
 COMMENT = lightweight audio player with a simple interface
-DISTNAME = potamus-16
+DISTNAME = potamus-17
 CATEGORIES = audio x11
-REVISION = 2
 
 HOMEPAGE = http://offog.org/code/potamus/
 
@@ -33,6 +32,7 @@ LIB_DEPENDS = audio/libao \
 RUN_DEPENDS = devel/desktop-file-utils \
  x11/gtk+3,-guic
 
+SEPARATE_BUILD= Yes
 CONFIGURE_STYLE = gnu
 CONFIGURE_ARGS = --disable-output-jack
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/audio/potamus/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo 22 Nov 2014 06:42:39 -0000 1.3
+++ distinfo 13 Feb 2018 17:32:10 -0000
@@ -1,2 +1,2 @@
-SHA256 (potamus-16.tar.gz) = CzGVX1SVR31oBIkVVg5SjRPXQRePuQ7znj/y28rXrmM=
-SIZE (potamus-16.tar.gz) = 144874
+SHA256 (potamus-17.tar.gz) = zRBISxZwZHyu+z1YYjpsF6e68EfiMFn7KDRF4X1Qa4o=
+SIZE (potamus-17.tar.gz) = 146822

Reply | Threaded
Open this post in threaded view
|

Re: audio/potamus

Landry Breuil-5
On Tue, Feb 13, 2018 at 06:37:47PM +0100, Björn Ketelaars wrote:
> Diff below brings potamus to the latest version. While here add
> SEPARATE_BUILD=Yes to Makefile.

What is it with this ? I see you're adding it to Makefiles, is there a
particular reason for it ? If it's *better* generally, then maybe a
(much larger) task would be to switch it by default and only set it to
no for broken ports..

Besides that, looks okay to me.

Reply | Threaded
Open this post in threaded view
|

Re: audio/potamus

Björn Ketelaars
On Tue 13/02/2018 20:01, Landry Breuil wrote:
> On Tue, Feb 13, 2018 at 06:37:47PM +0100, Björn Ketelaars wrote:
> > Diff below brings potamus to the latest version. While here add
> > SEPARATE_BUILD=Yes to Makefile.
>
> What is it with this ? I see you're adding it to Makefiles, is there a
> particular reason for it ? If it's *better* generally, then maybe a
> (much larger) task would be to switch it by default and only set it to
> no for broken ports..

It has some advantages, and testing it while working on a port is cheap.
From https://www.openbsd.org/faq/ports/guide.html:

- If the port can build with object files outside its source tree, this
  is cleaner (many programs using CONFIGURE_STYLE=gnu can), and may help
  people who mount their ports tree on several arches.
- This can also spare you some effort, as you will possibly be able to
  restart the cycle at configure most of the time.

Reply | Threaded
Open this post in threaded view
|

Re: audio/potamus

Antoine Jacoutot-7
On Tue, Feb 13, 2018 at 07:24:58PM +0000, Björn Ketelaars wrote:

> On Tue 13/02/2018 20:01, Landry Breuil wrote:
> > On Tue, Feb 13, 2018 at 06:37:47PM +0100, Björn Ketelaars wrote:
> > > Diff below brings potamus to the latest version. While here add
> > > SEPARATE_BUILD=Yes to Makefile.
> >
> > What is it with this ? I see you're adding it to Makefiles, is there a
> > particular reason for it ? If it's *better* generally, then maybe a
> > (much larger) task would be to switch it by default and only set it to
> > no for broken ports..
>
> It has some advantages, and testing it while working on a port is cheap.
> From https://www.openbsd.org/faq/ports/guide.html:
>
> - If the port can build with object files outside its source tree, this
>   is cleaner (many programs using CONFIGURE_STYLE=gnu can), and may help
>   people who mount their ports tree on several arches.

You still can. Just use a local partition for your objdir.

> - This can also spare you some effort, as you will possibly be able to
>   restart the cycle at configure most of the time.

I agree with Landry.
I don't like to start adding this to ports unless this is required. Now, if we
want to make it a default, than fine, someone starts the effort...

--
Antoine

Reply | Threaded
Open this post in threaded view
|

Re: audio/potamus

Björn Ketelaars
On Tue 13/02/2018 20:59, Antoine Jacoutot wrote:

> On Tue, Feb 13, 2018 at 07:24:58PM +0000, Björn Ketelaars wrote:
> > On Tue 13/02/2018 20:01, Landry Breuil wrote:
> > > On Tue, Feb 13, 2018 at 06:37:47PM +0100, Björn Ketelaars wrote:
> > > > Diff below brings potamus to the latest version. While here add
> > > > SEPARATE_BUILD=Yes to Makefile.
> > >
> > > What is it with this ? I see you're adding it to Makefiles, is there a
> > > particular reason for it ? If it's *better* generally, then maybe a
> > > (much larger) task would be to switch it by default and only set it to
> > > no for broken ports..
> >
> > It has some advantages, and testing it while working on a port is cheap.
> > From https://www.openbsd.org/faq/ports/guide.html:
> >
> > - If the port can build with object files outside its source tree, this
> >   is cleaner (many programs using CONFIGURE_STYLE=gnu can), and may help
> >   people who mount their ports tree on several arches.
>
> You still can. Just use a local partition for your objdir.
>
> > - This can also spare you some effort, as you will possibly be able to
> >   restart the cycle at configure most of the time.
>
> I agree with Landry.
> I don't like to start adding this to ports unless this is required. Now, if we
> want to make it a default, than fine, someone starts the effort...

Clear! Until I understand the internals better I'm not going to start
the effort.

Attached a new diff without the SEPARATE_BUILD bit.

OK?


Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/potamus/Makefile,v
retrieving revision 1.6
diff -u -p -r1.6 Makefile
--- Makefile 16 Nov 2017 19:52:09 -0000 1.6
+++ Makefile 13 Feb 2018 20:25:26 -0000
@@ -1,9 +1,8 @@
 # $OpenBSD: Makefile,v 1.6 2017/11/16 19:52:09 kirby Exp $
 
 COMMENT = lightweight audio player with a simple interface
-DISTNAME = potamus-16
+DISTNAME = potamus-17
 CATEGORIES = audio x11
-REVISION = 2
 
 HOMEPAGE = http://offog.org/code/potamus/
 
Index: distinfo
===================================================================
RCS file: /cvs/ports/audio/potamus/distinfo,v
retrieving revision 1.3
diff -u -p -r1.3 distinfo
--- distinfo 22 Nov 2014 06:42:39 -0000 1.3
+++ distinfo 13 Feb 2018 20:25:26 -0000
@@ -1,2 +1,2 @@
-SHA256 (potamus-16.tar.gz) = CzGVX1SVR31oBIkVVg5SjRPXQRePuQ7znj/y28rXrmM=
-SIZE (potamus-16.tar.gz) = 144874
+SHA256 (potamus-17.tar.gz) = zRBISxZwZHyu+z1YYjpsF6e68EfiMFn7KDRF4X1Qa4o=
+SIZE (potamus-17.tar.gz) = 146822

Reply | Threaded
Open this post in threaded view
|

Re: audio/potamus

Stuart Henderson
In reply to this post by Antoine Jacoutot-7
On 2018/02/13 20:59, Antoine Jacoutot wrote:

> On Tue, Feb 13, 2018 at 07:24:58PM +0000, Björn Ketelaars wrote:
> > On Tue 13/02/2018 20:01, Landry Breuil wrote:
> > > On Tue, Feb 13, 2018 at 06:37:47PM +0100, Björn Ketelaars wrote:
> > > > Diff below brings potamus to the latest version. While here add
> > > > SEPARATE_BUILD=Yes to Makefile.
> > >
> > > What is it with this ? I see you're adding it to Makefiles, is there a
> > > particular reason for it ? If it's *better* generally, then maybe a
> > > (much larger) task would be to switch it by default and only set it to
> > > no for broken ports..
> >
> > It has some advantages, and testing it while working on a port is cheap.
> > From https://www.openbsd.org/faq/ports/guide.html:
> >
> > - If the port can build with object files outside its source tree, this
> >   is cleaner (many programs using CONFIGURE_STYLE=gnu can), and may help
> >   people who mount their ports tree on several arches.
>
> You still can. Just use a local partition for your objdir.
>
> > - This can also spare you some effort, as you will possibly be able to
> >   restart the cycle at configure most of the time.
>
> I agree with Landry.
> I don't like to start adding this to ports unless this is required. Now, if we
> want to make it a default, than fine, someone starts the effort...
>
> --
> Antoine
>

I do like it on ports that take a long time to extract, as long as it
doesn't need any extra faffing around (extra patches etc).

Definitely don't want to do it by default, fixing things for that is
going to be about as much fun as patching for ${LOCALBASE} etc. :-)

Reply | Threaded
Open this post in threaded view
|

Re: audio/potamus

Landry Breuil-5
In reply to this post by Björn Ketelaars
On Tue, Feb 13, 2018 at 09:26:22PM +0100, Björn Ketelaars wrote:

> On Tue 13/02/2018 20:59, Antoine Jacoutot wrote:
> > On Tue, Feb 13, 2018 at 07:24:58PM +0000, Björn Ketelaars wrote:
> > > On Tue 13/02/2018 20:01, Landry Breuil wrote:
> > > > On Tue, Feb 13, 2018 at 06:37:47PM +0100, Björn Ketelaars wrote:
> > > > > Diff below brings potamus to the latest version. While here add
> > > > > SEPARATE_BUILD=Yes to Makefile.
> > > >
> > > > What is it with this ? I see you're adding it to Makefiles, is there a
> > > > particular reason for it ? If it's *better* generally, then maybe a
> > > > (much larger) task would be to switch it by default and only set it to
> > > > no for broken ports..
> > >
> > > It has some advantages, and testing it while working on a port is cheap.
> > > From https://www.openbsd.org/faq/ports/guide.html:
> > >
> > > - If the port can build with object files outside its source tree, this
> > >   is cleaner (many programs using CONFIGURE_STYLE=gnu can), and may help
> > >   people who mount their ports tree on several arches.
> >
> > You still can. Just use a local partition for your objdir.
> >
> > > - This can also spare you some effort, as you will possibly be able to
> > >   restart the cycle at configure most of the time.
> >
> > I agree with Landry.
> > I don't like to start adding this to ports unless this is required. Now, if we
> > want to make it a default, than fine, someone starts the effort...
>
> Clear! Until I understand the internals better I'm not going to start
> the effort.
>
> Attached a new diff without the SEPARATE_BUILD bit.
>
> OK?

ok